From b068e18adad0d0086436b840e10085403d16a152 Mon Sep 17 00:00:00 2001
From: Antonin Delpeuch <antonin@delpeuch.eu>
Date: Tue, 19 Feb 2019 14:37:11 +0000
Subject: [PATCH] Make suggest items clickable with the middle button.

Clicking on an item with the middle button leads the user to the page
for this item. This lets users inspect items without selecting them.
Closes #1934.
---
 .../modules/core/externals/suggest/suggest-4_3.js  | 14 ++++++++++++++
 .../core/scripts/views/data-table/cell-ui.js       |  3 +++
 .../scripts/views/data-table/menu-reconcile.js     |  3 +++
 3 files changed, 20 insertions(+)

diff --git a/main/webapp/modules/core/externals/suggest/suggest-4_3.js b/main/webapp/modules/core/externals/suggest/suggest-4_3.js
index bb10c3689..a630affc8 100644
--- a/main/webapp/modules/core/externals/suggest/suggest-4_3.js
+++ b/main/webapp/modules/core/externals/suggest/suggest-4_3.js
@@ -1299,6 +1299,20 @@
           name.append($("<span></span>").text(data.description));
       }
 
+      // If we know of a view URL for this suggest service,
+      // clicking with the middle button sends the user to
+      // the view page.
+      if('view_url' in this.options && data.id) {
+        var view_url = this.options.view_url.replace('{{id}}', data.id);
+        li.on('mousedown', function(e) {
+           if (e.which == 2) {
+              var win = window.open(view_url, '_blank');
+              win.focus();
+              e.preventDefault();
+           }
+        });
+      }
+
       //console.log("create_item", li);
       return li;
     },
diff --git a/main/webapp/modules/core/scripts/views/data-table/cell-ui.js b/main/webapp/modules/core/scripts/views/data-table/cell-ui.js
index be5a9d29f..e399737e5 100644
--- a/main/webapp/modules/core/scripts/views/data-table/cell-ui.js
+++ b/main/webapp/modules/core/scripts/views/data-table/cell-ui.js
@@ -200,6 +200,9 @@ DataTableCellUI.prototype._render = function() {
         var addSuggest = false;
         if ((service) && (service.suggest) && (service.suggest.entity)) {
           suggestOptions = service.suggest.entity;
+          if ('view' in service && 'url' in service.view && !('view_url' in suggestOptions)) {
+            suggestOptions.view_url = service.view.url;
+          }
           addSuggest = true;
         }
 
diff --git a/main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js b/main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js
index 7845334fd..ffd021c3f 100644
--- a/main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js
+++ b/main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js
@@ -85,6 +85,9 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
     if (service && service.suggest && service.suggest.entity) {
        suggestOptions = $.extend({}, service.suggest.entity);
        suggestOptions.query_param_name = "prefix";
+       if ('view' in service && 'url' in service.view && !('view_url' in suggestOptions)) {
+          suggestOptions.formatter_url = service.view.url;
+       }
     }
 
     var frame = DialogSystem.createDialog();