Merge pull request #1937 from OpenRefine/issue1936
Provide default identifierSpace and schemaSpace for reconciliation services
This commit is contained in:
commit
b2124d5bb4
@ -75,6 +75,9 @@ import com.google.refine.util.ParsingUtilities;
|
|||||||
public class StandardReconConfig extends ReconConfig {
|
public class StandardReconConfig extends ReconConfig {
|
||||||
final static Logger logger = LoggerFactory.getLogger("refine-standard-recon");
|
final static Logger logger = LoggerFactory.getLogger("refine-standard-recon");
|
||||||
|
|
||||||
|
private static final String DEFAULT_SCHEMA_SPACE = "http://localhost/schema";
|
||||||
|
private static final String DEFAULT_IDENTIFIER_SPACE = "http://localhost/identifier";
|
||||||
|
|
||||||
static public class ColumnDetail {
|
static public class ColumnDetail {
|
||||||
@JsonProperty("column")
|
@JsonProperty("column")
|
||||||
final public String columnName;
|
final public String columnName;
|
||||||
@ -208,8 +211,8 @@ public class StandardReconConfig extends ReconConfig {
|
|||||||
int limit
|
int limit
|
||||||
) {
|
) {
|
||||||
this.service = service;
|
this.service = service;
|
||||||
this.identifierSpace = identifierSpace;
|
this.identifierSpace = identifierSpace != null ? identifierSpace : DEFAULT_IDENTIFIER_SPACE;
|
||||||
this.schemaSpace = schemaSpace;
|
this.schemaSpace = schemaSpace != null ? schemaSpace : DEFAULT_SCHEMA_SPACE;
|
||||||
|
|
||||||
this.typeID = typeID;
|
this.typeID = typeID;
|
||||||
this.typeName = typeName;
|
this.typeName = typeName;
|
||||||
|
@ -154,6 +154,19 @@ public class StandardReconConfigTests extends RefineTest {
|
|||||||
assertNull(config.typeName);
|
assertNull(config.typeName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testReconstructNoIdentifierSchemaSpaces() throws IOException {
|
||||||
|
String json = "{\"mode\":\"standard-service\","
|
||||||
|
+ "\"service\":\"https://tools.wmflabs.org/openrefine-wikidata/en/api\","
|
||||||
|
+ "\"type\":null,"
|
||||||
|
+ "\"autoMatch\":true,"
|
||||||
|
+ "\"columnDetails\":[],"
|
||||||
|
+ "\"limit\":0}";
|
||||||
|
StandardReconConfig config = StandardReconConfig.reconstruct(json);
|
||||||
|
assertEquals(config.identifierSpace, "http://localhost/identifier");
|
||||||
|
assertEquals(config.schemaSpace, "http://localhost/schema");
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void formulateQueryTest() throws IOException {
|
public void formulateQueryTest() throws IOException {
|
||||||
Project project = createCSVProject("title,director\n"
|
Project project = createCSVProject("title,director\n"
|
||||||
|
Loading…
Reference in New Issue
Block a user