From b33c6cc0fd43d8e705b54fbbac1898bb3f4cee7b Mon Sep 17 00:00:00 2001 From: Tom Morris Date: Sat, 5 Jan 2013 18:22:25 -0500 Subject: [PATCH] Ask Freebase Suggest to fetch expected type - fixes #646 - get Suggest to fetch the expected type of property and save it so that constraints and other operations work correctly --- .../scripts/dialogs/extend-data-preview-dialog.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/extensions/freebase/module/scripts/dialogs/extend-data-preview-dialog.js b/extensions/freebase/module/scripts/dialogs/extend-data-preview-dialog.js index 067a40576..23fdc9b0b 100644 --- a/extensions/freebase/module/scripts/dialogs/extend-data-preview-dialog.js +++ b/extensions/freebase/module/scripts/dialogs/extend-data-preview-dialog.js @@ -1,6 +1,6 @@ /* -Copyright 2010, Google Inc. +Copyright 2010,2012 Google Inc. and other contributors All rights reserved. Redistribution and use in source and binary forms, with or without @@ -139,7 +139,9 @@ ExtendDataPreviewDialog.prototype._show = function(properties) { } var suggestConfig = { - filter: '(all type:/type/property)' + filter: '(all type:/type/property)', + // Default returns id, lang, mid, name, notable {id,name}, score + mql_output : JSON.stringify({'name':null,'id':null,'mid':null, '/type/property/expected_type':{'name':null,'id':null}}), }; if ((this._column.reconConfig) && (this._column.reconConfig.type)) { suggestConfig.filter = '(all type:/type/property (any namespace:/type/object namespace:' + this._column.reconConfig.type.id + '))'; @@ -149,10 +151,7 @@ ExtendDataPreviewDialog.prototype._show = function(properties) { self._addProperty({ id : data.id, name: data.name, - expected: { - id: "/type/object", - name: "Object" - } + expected: data["/type/property/expected_type"] }); }); };