Merge pull request #1329 from jackyq2015/feature/metadata

add tests for SetProjectMetadataCommand
This commit is contained in:
Thad Guidry 2017-11-15 08:58:49 -06:00 committed by GitHub
commit b496b0b374
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -0,0 +1,212 @@
/*
Copyright 2010, Google Inc.
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following disclaimer
in the documentation and/or other materials provided with the
distribution.
* Neither the name of Google Inc. nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
package com.google.refine.tests.commands.project;
import static org.mockito.Matchers.anyLong;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import java.io.IOException;
import java.io.PrintWriter;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;
import org.slf4j.LoggerFactory;
import org.testng.Assert;
import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
import com.google.refine.ProjectManager;
import com.google.refine.ProjectMetadata;
import com.google.refine.commands.project.SetProjectMetadataCommand;
import com.google.refine.model.Project;
import com.google.refine.tests.RefineTest;
public class SetProjectMetadataCommandTests extends RefineTest {
@Override
@BeforeTest
public void init() {
logger = LoggerFactory.getLogger(this.getClass());
}
// System Under Test
SetProjectMetadataCommand SUT = null;
// variables
long PROJECT_ID_LONG = 1234;
String PROJECT_ID = "1234";
String SUBJECT = "subject for project";
// mocks
HttpServletRequest request = null;
HttpServletResponse response = null;
ProjectManager projMan = null;
Project proj = null;
PrintWriter pw = null;
@BeforeMethod
public void SetUp() throws JSONException {
projMan = mock(ProjectManager.class);
ProjectManager.singleton = projMan;
proj = mock(Project.class);
pw = mock(PrintWriter.class);
request = mock(HttpServletRequest.class);
response = mock(HttpServletResponse.class);
SUT = new SetProjectMetadataCommand();
ProjectMetadata metadata = new ProjectMetadata();
metadata.setUserMetadata(new JSONArray("[ {name: clientID, display: true} ]"));
// mock dependencies
when(request.getParameter("project")).thenReturn(PROJECT_ID);
when(projMan.getProject(anyLong())).thenReturn(proj);
when(proj.getMetadata()).thenReturn(metadata);
try {
when(response.getWriter()).thenReturn(pw);
} catch (IOException e1) {
Assert.fail();
}
}
@AfterMethod
public void TearDown() {
SUT = null;
projMan = null;
ProjectManager.singleton = null;
proj = null;
pw = null;
request = null;
response = null;
}
/**
* Contract for a complete working post
*/
@Test
public void setMetadataTest() {
when(request.getParameter("name")).thenReturn("subject");
when(request.getParameter("value")).thenReturn(SUBJECT);
// run
try {
SUT.doPost(request, response);
} catch (ServletException e) {
Assert.fail();
} catch (IOException e) {
Assert.fail();
}
// verify
verify(request, times(2)).getParameter("project");
verify(projMan, times(1)).getProject(PROJECT_ID_LONG);
verify(response, times(1))
.setHeader("Content-Type", "application/json");
verify(proj, times(1)).getMetadata();
try {
verify(response, times(1)).getWriter();
} catch (IOException e) {
Assert.fail();
}
verify(pw, times(1)).write("{ \"code\" : \"ok\" }");
Assert.assertEquals(proj.getMetadata().getSubject(), SUBJECT);
}
/**
* set a user defined metadata field
* @throws JSONException
*/
@Test
public void setUserMetadataFieldTest() throws JSONException {
when(request.getParameter("name")).thenReturn("clientID");
when(request.getParameter("value")).thenReturn("IBM");
// run
try {
SUT.doPost(request, response);
} catch (ServletException e) {
Assert.fail();
} catch (IOException e) {
Assert.fail();
}
// verify
verify(request, times(2)).getParameter("project");
verify(projMan, times(1)).getProject(PROJECT_ID_LONG);
verify(response, times(1))
.setHeader("Content-Type", "application/json");
verify(proj, times(1)).getMetadata();
try {
verify(response, times(1)).getWriter();
} catch (IOException e) {
Assert.fail();
}
verify(pw, times(1)).write("{ \"code\" : \"ok\" }");
JSONObject obj = (JSONObject) proj.getMetadata().getUserMetadata().get(0);
Assert.assertEquals(obj.get("name"), "clientID");
Assert.assertEquals(obj.get("value"), "IBM");
}
@Test
public void doPostThrowsIfCommand_getProjectReturnsNull(){
// run
try {
SUT.doPost(request, response);
} catch (ServletException e) {
//expected
} catch (IOException e) {
Assert.fail();
}
// verify
verify(request, times(2)).getParameter("project");
verify(projMan, times(1)).getProject(PROJECT_ID_LONG);
}
}