From b7652e9036b5d8298346766febd04f0e50be3418 Mon Sep 17 00:00:00 2001
From: Florian Giroud <6267288+fgiroud@users.noreply.github.com>
Date: Mon, 30 Aug 2021 12:47:26 +0200
Subject: [PATCH] Attempt to fix flaky reconciliation tests (#4091)

Attempt to fix flaky reconciliation tests
---
 .../project/grid/column/reconcile/reconcile.spec.js          | 5 +++--
 main/tests/cypress/cypress/support/commands.js               | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/main/tests/cypress/cypress/integration/project/grid/column/reconcile/reconcile.spec.js b/main/tests/cypress/cypress/integration/project/grid/column/reconcile/reconcile.spec.js
index a1105a318..fcb1912ed 100644
--- a/main/tests/cypress/cypress/integration/project/grid/column/reconcile/reconcile.spec.js
+++ b/main/tests/cypress/cypress/integration/project/grid/column/reconcile/reconcile.spec.js
@@ -89,7 +89,7 @@ describe('Base reconciliation tests', () => {
       .siblings('input')
       .uncheck();
     cy.get('.dialog-container button').contains('Start Reconciling...').click();
-    cy.assertNotificationContainingText('Reconcile cells in column species');
+    cy.wait(10000); // eslint-disable-line
     cy.assertColumnIsReconciled('species');
 
     // "Choose new match" appear when there is a match, if it's not there it means nothing is matched
@@ -110,7 +110,7 @@ describe('Base reconciliation tests', () => {
       .siblings('input')
       .check();
     cy.get('.dialog-container button').contains('Start Reconciling...').click();
-    cy.assertNotificationContainingText('Reconcile cells in column species');
+    cy.wait(10000); // eslint-disable-line
     cy.assertColumnIsReconciled('species');
 
     // 4 rows should have been automatched
@@ -130,6 +130,7 @@ describe('Base reconciliation tests', () => {
     cy.get('.recon-dialog-service-panel.recon-dialog-standard-service-panel').should('be.visible');
     cy.get('.dialog-container input[bind="maxCandidates"]').type(2);
     cy.get('.dialog-container button').contains('Start Reconciling...').click();
+    cy.wait(10000); // eslint-disable-line
     cy.assertColumnIsReconciled('species');
     cy.get('.data-table-cell-content .data-table-recon-topic').should(
       'have.length',
diff --git a/main/tests/cypress/cypress/support/commands.js b/main/tests/cypress/cypress/support/commands.js
index 4273fd430..10112868d 100644
--- a/main/tests/cypress/cypress/support/commands.js
+++ b/main/tests/cypress/cypress/support/commands.js
@@ -349,7 +349,7 @@ Cypress.Commands.add(
 );
 
 Cypress.Commands.add('assertNotificationContainingText', (text) => {
-  cy.get('#notification-container');
+  cy.get('#notification-container').should('be.visible');
   cy.get('#notification').should('be.visible').should('to.contain', text);
 });