s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #2062 from OpenRefine/issue-2046-entity-cache

Browse Source 
Fix datavalue rendering cache in Wikidata preview
This commit is contained in:
Antonin Delpeuch 2019-07-02 10:18:37 +02:00 committed by GitHub
commit c062641698
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/wikidata/module/scripts/previewrenderer.js
View File

@ -224,8 +224,9 @@ EditRenderer._renderValue = function(json, container) {
EditRenderer._renderEntity(json.datavalue, container); EditRenderer._renderEntity(json.datavalue, container);
} else { } else {
var jsonValue = JSON.stringify(json.datavalue); var jsonValue = JSON.stringify(json.datavalue);
if (jsonValue in EditRenderer.renderedValueCache) { var fullJsonValue = JSON.stringify(json);
$('<span>'+EditRenderer.renderedValueCache[jsonValue]+'</span>').appendTo(container); if (fullJsonValue in EditRenderer.renderedValueCache) {
$('<span>'+EditRenderer.renderedValueCache[fullJsonValue]+'</span>').appendTo(container);
} else { } else {
var params = { var params = {
action: 'wbformatvalue', action: 'wbformatvalue',
@ -244,7 +245,7 @@ EditRenderer._renderValue = function(json, container) {
params, params,
function (data) { function (data) {
if('result' in data) { if('result' in data) {
EditRenderer.renderedValueCache[jsonValue] = data.result; EditRenderer.renderedValueCache[fullJsonValue] = data.result;
$('<span>'+data.result+'</span>').appendTo(container); $('<span>'+data.result+'</span>').appendTo(container);
} }
}, },