From d0eff4c5a8194ac17215a291b5cf7fafcbd68ea1 Mon Sep 17 00:00:00 2001 From: Antonin Delpeuch Date: Sun, 30 Dec 2018 21:55:58 +0100 Subject: [PATCH] Update Apache POI to 4.0.1 --- main/pom.xml | 2 +- .../com/google/refine/importers/ExcelImporter.java | 13 +++++++------ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/main/pom.xml b/main/pom.xml index cd7be95e9..447f81cb1 100644 --- a/main/pom.xml +++ b/main/pom.xml @@ -349,7 +349,7 @@ org.apache.poi poi - 3.8 + 4.0.1 org.apache.poi diff --git a/main/src/com/google/refine/importers/ExcelImporter.java b/main/src/com/google/refine/importers/ExcelImporter.java index 173fc1e73..4ce4d4792 100644 --- a/main/src/com/google/refine/importers/ExcelImporter.java +++ b/main/src/com/google/refine/importers/ExcelImporter.java @@ -50,6 +50,7 @@ import org.apache.poi.common.usermodel.Hyperlink; import org.apache.poi.hssf.usermodel.HSSFDateUtil; import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.apache.poi.poifs.filesystem.POIFSFileSystem; +import org.apache.poi.ss.usermodel.CellType; import org.apache.poi.ss.usermodel.Sheet; import org.apache.poi.ss.usermodel.Workbook; import org.apache.poi.xssf.usermodel.XSSFWorkbook; @@ -239,19 +240,19 @@ public class ExcelImporter extends TabularImportingParserBase { } static protected Serializable extractCell(org.apache.poi.ss.usermodel.Cell cell) { - int cellType = cell.getCellType(); - if (cellType == org.apache.poi.ss.usermodel.Cell.CELL_TYPE_FORMULA) { + CellType cellType = cell.getCellType(); + if (cellType.equals(CellType.FORMULA)) { cellType = cell.getCachedFormulaResultType(); } - if (cellType == org.apache.poi.ss.usermodel.Cell.CELL_TYPE_ERROR || - cellType == org.apache.poi.ss.usermodel.Cell.CELL_TYPE_BLANK) { + if (cellType.equals(CellType.ERROR) || + cellType.equals(CellType.BLANK)) { return null; } Serializable value = null; - if (cellType == org.apache.poi.ss.usermodel.Cell.CELL_TYPE_BOOLEAN) { + if (cellType.equals(CellType.BOOLEAN)) { value = cell.getBooleanCellValue(); - } else if (cellType == org.apache.poi.ss.usermodel.Cell.CELL_TYPE_NUMERIC) { + } else if (cellType.equals(CellType.NUMERIC)) { double d = cell.getNumericCellValue(); if (HSSFDateUtil.isCellDateFormatted(cell)) {