s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed: Issue 167 in google-refine: 'No syntax error' is alarming

Browse Source 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1659 7d457c2a-affb-35e4-300a-418c747d4874
This commit is contained in:
David Huynh 2010-10-25 17:27:38 +00:00
parent a193f9acf7
commit d4969e02ee
4 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
main/webapp/modules/core/scripts/dialogs/expression-preview-dialog.html
View File

@ -6,7 +6,7 @@
</tr>
<tr>
<td colspan="3"><div class="input-container"><textarea class="expression-preview-code" bind="expressionPreviewTextarea" /></div></td>
<td class="expression-preview-error-container" bind="expressionPreviewErrorContainer" width="150" style="vertical-align: top;"></td>
<td class="expression-preview-parsing-status" bind="expressionPreviewParsingStatus" width="150" style="vertical-align: top;"></td>
</tr>
<tr>
<td colspan="4">

4
main/webapp/modules/core/scripts/dialogs/expression-preview-dialog.js
View File

@ -354,10 +354,10 @@ ExpressionPreviewDialog.Widget.prototype._renderPreview = function(expression, d
};
if (this._results !== null) {
this._elmts.expressionPreviewErrorContainer.empty().text("No syntax error.");
this._elmts.expressionPreviewParsingStatus.empty().removeClass("error").text("No syntax error.");
} else {
var message = (data.type == "parser") ? data.message : "Internal error";
this._elmts.expressionPreviewErrorContainer.empty().text(message);
this._elmts.expressionPreviewParsingStatus.empty().addClass("error").text(message);
}
for (var i = 0; i < this._values.length; i++) {

2
main/webapp/modules/core/scripts/views/data-table/text-transform-dialog.html
View File

@ -8,7 +8,7 @@
<td width="1%">On error</td>
<td><input type="radio" name="text-transform-dialog-onerror-choice" value="set-to-blank" checked /> set to blank<br/><input type="radio" name="text-transform-dialog-onerror-choice" value="store-error" /> store error<br/><input type="radio" name="text-transform-dialog-onerror-choice" value="keep-original" /> keep original</td>
<td width="1%"><input type="checkbox" bind="repeatCheckbox" /></td>
<td>Re-transform until no change<br/>up to <input bind="repeatCountInput" value="10" size="3" /> times</td>
<td>Re-transform up to <input bind="repeatCountInput" value="10" size="2" /> times until no change</td>
</tr>
</table>
</div>

5
main/webapp/modules/core/styles/dialogs/expression-preview-dialog.less
View File

@ -43,7 +43,10 @@ textarea.expression-preview-code {
vertical-align: top;
}
.expression-preview-error-container {
.expression-preview-parsing-status {
color: @light_grey;
}
.expression-preview-parsing-status.error {
color: red;
}