s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Adapt test about #1214 to show how the function currently works.

Browse Source 
With this test, if someone tries to fix this "bug" in the future, they will realize this use case should be preserved.
This commit is contained in:
Antonin Delpeuch 2017-07-26 18:07:52 +01:00
parent 453d35032b
commit d941320f5e
1 changed files with 27 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
main/tests/server/src/com/google/refine/tests/model/KeyValueColumnizeTests.java
View File

@ -98,13 +98,6 @@ public class KeyValueColumnizeTests extends RefineTest {
pm.setName("KeyValueColumnize test"); pm.setName("KeyValueColumnize test");
ProjectManager.singleton.registerProject(project, pm); ProjectManager.singleton.registerProject(project, pm);
options = mock(JSONObject.class); options = mock(JSONObject.class);
/*
int index = project.columnModel.allocateNewCellIndex();
Column column1 = new Column(index,"Column1");
Column column2 = new Column(index,"Column2");
project.columnModel.addColumn(index, column1, true);
project.columnModel.addColumn(index, column2, true);
*/
job = ImportingManager.createJob(); job = ImportingManager.createJob();
importer = new SeparatorBasedImporter(); importer = new SeparatorBasedImporter();
@ -121,59 +114,47 @@ public class KeyValueColumnizeTests extends RefineTest {
} }
/** /**
* Test for issue #1214: * Test to demonstrate the intended behaviour of the function, for issue #1214
* https://github.com/OpenRefine/OpenRefine/issues/1214 * https://github.com/OpenRefine/OpenRefine/issues/1214
*/ */
@Test @Test
public void testKeyValueColumnize() throws Exception { public void testKeyValueColumnize() throws Exception {
String csv = "Column1;Column2\n" String csv = "Key,Value\n"
+ "SourceFile1;2\n" + "merchant,Katie\n"
+ "SourceFile1;3\n" + "fruit,apple\n"
+ "SourceFile1;-1\n" + "price,1.2\n"
+ "SourceFile2;3\n" + "fruit,pear\n"
+ "SourceFile2;4\n" + "price,1.5\n"
+ "SourceFile2;6\n" + "merchant,John\n"
+ "SourceFile3;-3\n" + "fruit,banana\n"
+ "SourceFile3;4\n" + "price,3.1\n";
+ "SourceFile3;1\n"; prepareOptions(",", 20, 0, 0, 1, false, false);
prepareOptions(";", 20, 0, 0, 1, false, false);
List<Exception> exceptions = new ArrayList<Exception>(); List<Exception> exceptions = new ArrayList<Exception>();
importer.parseOneFile(project, pm, job, "filesource", new StringReader(csv), -1, options, exceptions); importer.parseOneFile(project, pm, job, "filesource", new StringReader(csv), -1, options, exceptions);
project.update(); project.update();
ProjectManager.singleton.registerProject(project, pm); ProjectManager.singleton.registerProject(project, pm);
for (int i = 0; i < 9; i++) {
for (int j = 0; j < 2; j++) {
Object val = project.rows.get(i).getCellValue(j);
if (val != null) {
System.out.println(String.format("%d %d %s", i, j, val.toString()));
}
}
}
AbstractOperation op = new KeyValueColumnizeOperation( AbstractOperation op = new KeyValueColumnizeOperation(
"Column1", "Key",
"Column2", "Value",
null); null);
Process process = op.createProcess(project, new Properties()); Process process = op.createProcess(project, new Properties());
HistoryEntry historyEntry = process.performImmediate(); HistoryEntry historyEntry = process.performImmediate();
for (int i = 0; i < 3; i++) { int merchantCol = project.columnModel.getColumnByName("merchant").getCellIndex();
for (int j = 0; j < 3; j++) { int fruitCol = project.columnModel.getColumnByName("fruit").getCellIndex();
Object val = project.rows.get(i).getCellValue(j); int priceCol = project.columnModel.getColumnByName("price").getCellIndex();
if (val != null) {
System.out.println(String.format("%d %d %s", i, j, val.toString())); Assert.assertEquals(project.rows.get(0).getCellValue(merchantCol), "Katie");
} Assert.assertEquals(project.rows.get(1).getCellValue(merchantCol), null);
} Assert.assertEquals(project.rows.get(2).getCellValue(merchantCol), "John");
} Assert.assertEquals(project.rows.get(0).getCellValue(fruitCol), "apple");
Assert.assertEquals(project.rows.get(1).getCellValue(fruitCol), "pear");
for (int i = 0; i < 3; i++) { Assert.assertEquals(project.rows.get(2).getCellValue(fruitCol), "banana");
for (int j = 0; j < 3; j++) { Assert.assertEquals(project.rows.get(0).getCellValue(priceCol), "1.2");
Assert.assertEquals(project.rows.get(1).getCellValue(priceCol), "1.5");
Assert.assertTrue(project.rows.get(i).getCellValue(j) != null); Assert.assertEquals(project.rows.get(2).getCellValue(priceCol), "3.1");
}
}
} }
private void prepareOptions( private void prepareOptions(