s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #4 from OpenRefine/master

Browse Source 
Range check column move. Delete dead code.  Fixes #602
This commit is contained in:
Blakko 2013-07-25 01:07:38 -07:00
commit e0f16dede9
1 changed files with 12 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js
View File

@ -70,15 +70,6 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
}
);
});
var o = DataTableView.sampleVisibleRows(column);
var previewWidget = new ExpressionPreviewDialog.Widget(
elmts,
column.cellIndex,
o.rowIndices,
o.values,
null
);
};
var doAddColumnByFetchingURLs = function() {
@ -115,15 +106,6 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
);
dismiss();
});
var o = DataTableView.sampleVisibleRows(column);
var previewWidget = new ExpressionPreviewDialog.Widget(
elmts,
column.cellIndex,
o.rowIndices,
o.values,
null
);
};
var doRemoveColumn = function() {
@ -165,15 +147,18 @@ DataTableColumnHeaderUI.extendMenu(function(column, columnHeaderUI, menu) {
};
var doMoveColumnBy = function(change) {
Refine.postCoreProcess(
"move-column",
{
columnName: column.name,
index: Refine.columnNameToColumnIndex(column.name) + change
},
null,
{ modelsChanged: true }
);
var newidx = Refine.columnNameToColumnIndex(column.name) + change;
if (newidx > 0 && newidx < Refine.columnNameToColumnIndex(column.name)) {
Refine.postCoreProcess(
"move-column",
{
columnName: column.name,
index: newidx
},
null,
{ modelsChanged: true }
);
}
};
var doSplitColumn = function() {