Make codacy happy
This commit is contained in:
Antonin Delpeuch
parent
81fa6093f4
commit
f2612b0d12
@ -55,7 +55,7 @@ function ExtendReconciledDataPreviewDialog(column, columnIndex, rowIndices, onDo
|
||||
self._onDone(self._extension,
|
||||
self._service,
|
||||
self._serviceMetadata.identifierSpace,
|
||||
self._serviceMetadata.schemaSpace);
|
||||
self._serviceMetadata.schemaSpace);
|
||||
}
|
||||
});
|
||||
this._elmts.cancelButton.click(function() {
|
||||
@ -76,7 +76,7 @@ function ExtendReconciledDataPreviewDialog(column, columnIndex, rowIndices, onDo
|
||||
if ("extend" in serviceMetadata) {
|
||||
extend = serviceMetadata.extend;
|
||||
if ("propose_properties" in extend) {
|
||||
var endpoint = extend.propose_properties;
|
||||
var endpoint = extend.propose_properties;
|
||||
this._proposePropertiesUrl = endpoint.service_url + endpoint.service_path;
|
||||
}
|
||||
}
|
||||
@ -101,32 +101,32 @@ ExtendReconciledDataPreviewDialog.getAllProperties = function(url, typeID, onDon
|
||||
} else {
|
||||
var done = false;
|
||||
$.getJSON(
|
||||
url +"?type=" + typeID + "&callback=?",
|
||||
null,
|
||||
function(data) {
|
||||
if (done) return;
|
||||
done = true;
|
||||
url +"?type=" + typeID + "&callback=?",
|
||||
null,
|
||||
function(data) {
|
||||
if (done) return;
|
||||
done = true;
|
||||
|
||||
var allProperties = [];
|
||||
for (var i = 0; i < data.properties.length; i++) {
|
||||
var property = data.properties[i];
|
||||
var property2 = {
|
||||
id: property.id,
|
||||
name: property.name
|
||||
};
|
||||
allProperties.push(property2);
|
||||
}
|
||||
allProperties.sort(function(a, b) { return a.name.localeCompare(b.name); });
|
||||
var allProperties = [];
|
||||
for (var i = 0; i < data.properties.length; i++) {
|
||||
var property = data.properties[i];
|
||||
var property2 = {
|
||||
id: property.id,
|
||||
name: property.name
|
||||
};
|
||||
allProperties.push(property2);
|
||||
}
|
||||
allProperties.sort(function(a, b) { return a.name.localeCompare(b.name); });
|
||||
|
||||
onDone(allProperties);
|
||||
}
|
||||
onDone(allProperties);
|
||||
}
|
||||
);
|
||||
|
||||
window.setTimeout(function() {
|
||||
if (done) return;
|
||||
if (done) return;
|
||||
|
||||
done = true;
|
||||
onDone([]);
|
||||
done = true;
|
||||
onDone([]);
|
||||
}, 7000); // time to give up?
|
||||
}
|
||||
};
|
||||
@ -172,7 +172,7 @@ ExtendReconciledDataPreviewDialog.prototype._show = function(properties) {
|
||||
|
||||
ExtendReconciledDataPreviewDialog.prototype._update = function() {
|
||||
this._elmts.previewContainer.empty().html(
|
||||
'<div bind="progressPanel" class="extend-data-preview-progress"><img src="images/large-spinner.gif" /></div>');
|
||||
'<div bind="progressPanel" class="extend-data-preview-progress"><img src="images/large-spinner.gif" /></div>');
|
||||
|
||||
var self = this;
|
||||
var params = {
|
||||
@ -180,23 +180,23 @@ ExtendReconciledDataPreviewDialog.prototype._update = function() {
|
||||
columnName: this._column.name
|
||||
};
|
||||
|
||||
if(this._extension.properties.length == 0) {
|
||||
if(this._extension.properties.length === 0) {
|
||||
// if the column selection is empty, reset the view
|
||||
this._elmts.previewContainer.empty();
|
||||
} else {
|
||||
// otherwise, refresh the preview
|
||||
$.post(
|
||||
"command/core/preview-extend-data?" + $.param(params),
|
||||
{
|
||||
rowIndices: JSON.stringify(this._rowIndices),
|
||||
extension: JSON.stringify(this._extension)
|
||||
},
|
||||
function(data) {
|
||||
self._renderPreview(data);
|
||||
},
|
||||
"json"
|
||||
"command/core/preview-extend-data?" + $.param(params),
|
||||
{
|
||||
rowIndices: JSON.stringify(this._rowIndices),
|
||||
extension: JSON.stringify(this._extension)
|
||||
},
|
||||
function(data) {
|
||||
self._renderPreview(data);
|
||||
},
|
||||
"json"
|
||||
).fail(function(data) {
|
||||
alert($.i18n._("core-views")["internal-err"]);
|
||||
alert($.i18n._("core-views")["internal-err"]);
|
||||
});
|
||||
}
|
||||
};
|
||||
@ -284,8 +284,8 @@ ExtendReconciledDataPreviewDialog.prototype._renderPreview = function(data) {
|
||||
if (cell !== null) {
|
||||
if ($.isPlainObject(cell)) {
|
||||
$('<a>').attr("href",
|
||||
this._serviceMetadata.identifierSpace + cell.id
|
||||
).attr("target", "_blank").text(cell.name).appendTo(td);
|
||||
this._serviceMetadata.identifierSpace + cell.id
|
||||
).attr("target", "_blank").text(cell.name).appendTo(td);
|
||||
} else {
|
||||
$('<span>').text(cell).appendTo(td);
|
||||
}
|
||||
@ -331,50 +331,50 @@ ExtendReconciledDataPreviewDialog.prototype._constrainProperty = function(id) {
|
||||
var table = $('<table></table>');
|
||||
if (fields != null) {
|
||||
for(var i = 0; i < fields.length; i++) {
|
||||
var field = fields[i];
|
||||
var field = fields[i];
|
||||
var fieldHTML = '';
|
||||
var currentValue = field.default;
|
||||
var currentValue = field.default;
|
||||
if (property.settings != null && property.settings[field.name] != null) {
|
||||
currentValue = property.settings[field.name];
|
||||
}
|
||||
var tr = $('<tr></tr>');
|
||||
var td = $('<td></td>').attr('title', field.help_text).appendTo(tr);
|
||||
if (field.type === 'select') {
|
||||
var fieldLabel = $('<span></span>').text(field.label+':').appendTo(td);
|
||||
td.append($('<br/>'));
|
||||
for(var j = 0; j < field.choices.length; j++) {
|
||||
var choice = field.choices[j];
|
||||
var labelElem = $('<label></label>').attr('for', field.name+'_'+choice.value).appendTo(td);
|
||||
var inputElem = $('<input type="radio" />').attr(
|
||||
'id', field.name+'_'+choice.value).attr(
|
||||
'value', choice.value).attr(
|
||||
'name', field.name).appendTo(labelElem);
|
||||
var tr = $('<tr></tr>');
|
||||
var td = $('<td></td>').attr('title', field.help_text).appendTo(tr);
|
||||
if (field.type === 'select') {
|
||||
var fieldLabel = $('<span></span>').text(field.label+':').appendTo(td);
|
||||
td.append($('<br/>'));
|
||||
for(var j = 0; j < field.choices.length; j++) {
|
||||
var choice = field.choices[j];
|
||||
var labelElem = $('<label></label>').attr('for', field.name+'_'+choice.value).appendTo(td);
|
||||
var inputElem = $('<input type="radio" />').attr(
|
||||
'id', field.name+'_'+choice.value).attr(
|
||||
'value', choice.value).attr(
|
||||
'name', field.name).appendTo(labelElem);
|
||||
|
||||
if (choice.value === currentValue) {
|
||||
inputElem.attr('checked', 'checked');
|
||||
}
|
||||
if (choice.value === currentValue) {
|
||||
inputElem.attr('checked', 'checked');
|
||||
}
|
||||
labelElem.append(' '+choice.name);
|
||||
td.append('<br/>');
|
||||
}
|
||||
td.append(fieldHTML);
|
||||
} else if (field.type === 'checkbox') {
|
||||
var label = $('<label></label>').attr('for', field.name).appendTo(td);
|
||||
var input = $('<input type="checkbox" />').attr('name', field.name).appendTo(label);
|
||||
if (currentValue === 'on') {
|
||||
input.attr('checked','checked');
|
||||
}
|
||||
label.append(' '+field.label);
|
||||
}
|
||||
td.append(fieldHTML);
|
||||
} else if (field.type === 'checkbox') {
|
||||
var label = $('<label></label>').attr('for', field.name).appendTo(td);
|
||||
var input = $('<input type="checkbox" />').attr('name', field.name).appendTo(label);
|
||||
if (currentValue === 'on') {
|
||||
input.attr('checked','checked');
|
||||
}
|
||||
label.append(' '+field.label);
|
||||
} else if (field.type === 'number' || field.type == 'text') {
|
||||
var label = $('<label></label>').attr('for', field.name).appendTo(td);
|
||||
label.append(field.label+': ');
|
||||
var input = $('<input />').attr(
|
||||
'name', field.name).attr(
|
||||
'type', field.type).attr(
|
||||
'value', currentValue).appendTo(label);
|
||||
}
|
||||
if (tr.children().length > 0) {
|
||||
table.append(tr);
|
||||
}
|
||||
var label = $('<label></label>').attr('for', field.name).appendTo(td);
|
||||
label.append(field.label+': ');
|
||||
var input = $('<input />').attr(
|
||||
'name', field.name).attr(
|
||||
'type', field.type).attr(
|
||||
'value', currentValue).appendTo(label);
|
||||
}
|
||||
if (tr.children().length > 0) {
|
||||
table.append(tr);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@ -404,19 +404,19 @@ ExtendReconciledDataPreviewDialog.prototype._constrainProperty = function(id) {
|
||||
try {
|
||||
if (fields != null) {
|
||||
var elem = $(bodyElmts.form[0]);
|
||||
var ar = elem.serializeArray();
|
||||
var settings = {};
|
||||
var ar = elem.serializeArray();
|
||||
var settings = {};
|
||||
for(var i = 0; i < ar.length; i++) {
|
||||
settings[ar[i].name] = ar[i].value;
|
||||
}
|
||||
property.settings = settings;
|
||||
}
|
||||
property.settings = settings;
|
||||
}
|
||||
|
||||
dismiss();
|
||||
|
||||
self._update();
|
||||
} catch (e) {
|
||||
alert($.i18n._("core-views")["internal-err"]);
|
||||
alert($.i18n._("core-views")["internal-err"]);
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user