From f9a1a5ba184d35d5ba8a38e810363f8be41d3062 Mon Sep 17 00:00:00 2001
From: Antonin Delpeuch <antonin@delpeuch.eu>
Date: Sat, 28 Apr 2018 10:56:51 +0200
Subject: [PATCH] Cleanup vocabulary for export (perform -> upload) in Wikidata
 extension

---
 extensions/wikidata/module/langs/translation-en.json        | 6 +++---
 .../wikidata/operations/SaveWikibaseSchemaOperation.java    | 5 +++--
 extensions/wikidata/tests/data/operations/save-schema.json  | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/extensions/wikidata/module/langs/translation-en.json b/extensions/wikidata/module/langs/translation-en.json
index 129d1ab2a..3fb67051a 100644
--- a/extensions/wikidata/module/langs/translation-en.json
+++ b/extensions/wikidata/module/langs/translation-en.json
@@ -3,14 +3,14 @@
                 "menu-label": "Wikidata",
                 "edit-wikidata-schema": "Edit Wikidata schema",
                 "manage-wikidata-account": "Manage Wikidata account",
-                "perform-edits-on-wikidata": "Perform edits on Wikidata",
+                "perform-edits-on-wikidata": "Upload edits to Wikidata",
                 "export-to-qs": "Export to QuickStatements",
                 "quickstatements-export-name": "QuickStatements"
         },
         "wikidata-schema": {
                 "dialog-header": "Align to Wikidata",
                 "dialog-explanation": "The Wikidata schema below specifies how your tabular data will be transformed into Wikidata edits. You can drag and drop the column names below in most input boxes: for each row, edits will be generated with the values in these columns.",
-                "preview-explanation": "This tab shows the first 10 edits that will be made once you upload the changes to Wikidata. You can use facets to inspect the edits on particular items.",
+                "preview-explanation": "This tab shows the first edits (out of {nb_edits}) that will be made once you upload the changes to Wikidata. You can use facets to inspect the edits on particular items.",
                 "schema-tab-header": "Schema",
                 "warnings-tab-header": "Issues",
                 "edits-preview-tab-header": "Preview",
@@ -57,7 +57,7 @@
         },
         "wikidata-account": {
                 "dialog-header": "Wikidata account",
-                "explain-log-in": "Logging in to <a href=\"https://www.wikidata.org/\" target=\"_blank\">Wikidata</a> lets you to perform edits directly from OpenRefine.",
+                "explain-log-in": "Logging in to <a href=\"https://www.wikidata.org/\" target=\"_blank\">Wikidata</a> lets you to upload edits directly from OpenRefine.",
                 "username-label": "Username:",
                 "username-placeholder": "Enter your username",
                 "password-label": "Password:",
diff --git a/extensions/wikidata/src/org/openrefine/wikidata/operations/SaveWikibaseSchemaOperation.java b/extensions/wikidata/src/org/openrefine/wikidata/operations/SaveWikibaseSchemaOperation.java
index 5d6572945..8303469c6 100644
--- a/extensions/wikidata/src/org/openrefine/wikidata/operations/SaveWikibaseSchemaOperation.java
+++ b/extensions/wikidata/src/org/openrefine/wikidata/operations/SaveWikibaseSchemaOperation.java
@@ -43,6 +43,7 @@ import com.google.refine.util.Pool;
 
 public class SaveWikibaseSchemaOperation extends AbstractOperation {
 
+    final public String operationDescription = "Save Wikibase schema";
     final protected WikibaseSchema _schema;
 
     public SaveWikibaseSchemaOperation(WikibaseSchema schema) {
@@ -61,7 +62,7 @@ public class SaveWikibaseSchemaOperation extends AbstractOperation {
         writer.key("op");
         writer.value(OperationRegistry.s_opClassToName.get(this.getClass()));
         writer.key("description");
-        writer.value("Save Wikibase schema skeleton");
+        writer.value(operationDescription);
         writer.key("schema");
         _schema.write(writer, options);
         writer.endObject();
@@ -76,7 +77,7 @@ public class SaveWikibaseSchemaOperation extends AbstractOperation {
     @Override
     protected HistoryEntry createHistoryEntry(Project project, long historyEntryID)
             throws Exception {
-        String description = "Save Wikibase schema skeleton";
+        String description = operationDescription;
 
         Change change = new WikibaseSchemaChange(_schema);
 
diff --git a/extensions/wikidata/tests/data/operations/save-schema.json b/extensions/wikidata/tests/data/operations/save-schema.json
index 2ca55e310..5514212ab 100644
--- a/extensions/wikidata/tests/data/operations/save-schema.json
+++ b/extensions/wikidata/tests/data/operations/save-schema.json
@@ -1,6 +1,6 @@
 {
     "op": "wikidata/save-wikibase-schema",
-    "description": "Save Wikibase schema skeleton",
+    "description": "Save Wikibase schema",
     "schema": {
       "itemDocuments": [
         {