s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Testing for QuickStatements exporter

Browse Source
This commit is contained in:
Antonin Delpeuch 2018-03-02 10:00:46 +00:00
parent bb044612e0
commit fd7462f749
7 changed files with 176 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/wikidata/src/org/openrefine/wikidata/exporters/QuickStatementsExporter.java
View File

@ -32,13 +32,15 @@ public class QuickStatementsExporter implements WriterExporter {
public static final String impossibleSchedulingErrorMessage =
"This edit batch cannot be performed with QuickStatements due to the structure of its new items.";
public static final String noSchemaErrorMessage =
"No schema was provided. You need to align your project with Wikidata first.";
public QuickStatementsExporter(){
}
@Override
public String getContentType() {
return "text";
return "text/plain";
}
@Override
@ -46,9 +48,10 @@ public class QuickStatementsExporter implements WriterExporter {
throws IOException {
WikibaseSchema schema = (WikibaseSchema) project.overlayModels.get("wikibaseSchema");
if (schema == null) {
return;
writer.write(noSchemaErrorMessage);
} else {
translateSchema(project, engine, schema, writer);
}
translateSchema(project, engine, schema, writer);
}
/**

2
extensions/wikidata/src/org/openrefine/wikidata/updates/scheduler/QuickStatementsUpdateScheduler.java
View File

@ -62,6 +62,8 @@ public class QuickStatementsUpdateScheduler implements UpdateScheduler {
}
referencingBuilder.addStatement(statement);
referencingUpdates.put(pointer, referencingBuilder);
} else if (pointers.size() == 1 && pointers.stream().findFirst().get().equals(update.getItemId())) {
remainingUpdateBuilder.addStatement(statement);
} else {
throw new ImpossibleSchedulingException();
}

139
extensions/wikidata/tests/src/org/openrefine/wikidata/exporters/QuickStatementsExporterTest.java Normal file
View File

@ -0,0 +1,139 @@
package org.openrefine.wikidata.exporters;
import static org.junit.Assert.assertEquals;
import java.io.IOException;
import java.io.StringWriter;
import java.util.Arrays;
import java.util.Collections;
import java.util.Properties;
import org.json.JSONException;
import org.json.JSONObject;
import org.openrefine.wikidata.schema.WikibaseSchema;
import org.openrefine.wikidata.schema.WikibaseSchemaTest;
import org.openrefine.wikidata.testing.TestingDataGenerator;
import org.openrefine.wikidata.updates.ItemUpdate;
import org.openrefine.wikidata.updates.ItemUpdateBuilder;
import org.openrefine.wikidata.updates.scheduler.UpdateSchedulerTest;
import org.testng.annotations.Test;
import org.wikidata.wdtk.datamodel.helpers.Datamodel;
import org.wikidata.wdtk.datamodel.interfaces.Claim;
import org.wikidata.wdtk.datamodel.interfaces.ItemIdValue;
import org.wikidata.wdtk.datamodel.interfaces.Snak;
import org.wikidata.wdtk.datamodel.interfaces.SnakGroup;
import org.wikidata.wdtk.datamodel.interfaces.Statement;
import org.wikidata.wdtk.datamodel.interfaces.StatementRank;
import com.google.refine.browsing.Engine;
import com.google.refine.model.Project;
import com.google.refine.tests.RefineTest;
public class QuickStatementsExporterTest extends RefineTest {
private QuickStatementsExporter exporter = new QuickStatementsExporter();
private ItemIdValue newIdA = TestingDataGenerator.makeNewItemIdValue(1234L, "new item A");
private ItemIdValue newIdB = TestingDataGenerator.makeNewItemIdValue(5678L, "new item B");
private ItemIdValue qid1 = Datamodel.makeWikidataItemIdValue("Q1377");
private ItemIdValue qid2 = Datamodel.makeWikidataItemIdValue("Q865528");
private String export(ItemUpdate... itemUpdates) throws IOException {
StringWriter writer = new StringWriter();
exporter.translateItemList(Arrays.asList(itemUpdates), writer);
return writer.toString();
}
@Test
public void testSimpleProject() throws JSONException, IOException {
Project project = this.createCSVProject(
"subject,inception,reference\n"+
"Q1377,1919,http://www.ljubljana-slovenia.com/university-ljubljana\n"+
"Q865528,1965,\n"+
"new uni,2016,http://new-uni.com/");
project.rows.get(0).cells.set(0, TestingDataGenerator.makeMatchedCell("Q1377", "University of Ljubljana"));
project.rows.get(1).cells.set(0, TestingDataGenerator.makeMatchedCell("Q865528", "University of Warwick"));
project.rows.get(2).cells.set(0, TestingDataGenerator.makeNewItemCell(1234L, "new uni"));
JSONObject serialized = WikibaseSchemaTest.jsonFromFile("data/schema/inception.json");
WikibaseSchema schema = WikibaseSchema.reconstruct(serialized);
project.overlayModels.put("wikibaseSchema", schema);
Engine engine = new Engine(project);
StringWriter writer = new StringWriter();
Properties properties = new Properties();
exporter.export(project, properties, engine, writer);
assertEquals(
"Q1377\tP571\t+1919-01-01T00:00:00Z/9"+
"\tS854\t\"http://www.ljubljana-slovenia.com/university-ljubljana\""+
"\tS813\t+2018-02-28T00:00:00Z/11\n" +
"Q865528\tP571\t+1965-01-01T00:00:00Z/9"+
"\tS813\t+2018-02-28T00:00:00Z/11\n"+
"CREATE\n"+
"LAST\tP571\t+2016-01-01T00:00:00Z/9"+
"\tS854\t\"http://new-uni.com/\""+
"\tS813\t+2018-02-28T00:00:00Z/11\n", writer.toString());
}
@Test
public void testImpossibleScheduling() throws IOException {
Statement sNewAtoNewB = TestingDataGenerator.generateStatement(newIdA, newIdB);
ItemUpdate update = new ItemUpdateBuilder(newIdA).addStatement(sNewAtoNewB).build();
assertEquals(QuickStatementsExporter.impossibleSchedulingErrorMessage,
export(update));
}
@Test
public void testNameDesc() throws IOException {
ItemUpdate update = new ItemUpdateBuilder(newIdA)
.addLabel(Datamodel.makeMonolingualTextValue("my new item", "en"))
.addDescription(Datamodel.makeMonolingualTextValue("isn't it awesome?", "en"))
.addAlias(Datamodel.makeMonolingualTextValue("fabitem", "en"))
.build();
assertEquals("CREATE\n"+
"LAST\tLen\t\"my new item\"\n"+
"LAST\tDen\t\"isn't it awesome?\"\n"+
"LAST\tAen\t\"fabitem\"\n",
export(update));
}
@Test
public void testDeleteStatement() throws IOException {
ItemUpdate update = new ItemUpdateBuilder(qid1)
.deleteStatement(TestingDataGenerator.generateStatement(qid1, qid2))
.build();
assertEquals("- Q1377\tP38\tQ865528\n", export(update));
}
@Test
public void testQualifier() throws IOException {
Statement baseStatement = TestingDataGenerator.generateStatement(qid1, qid2);
Statement otherStatement = TestingDataGenerator.generateStatement(qid2, qid1);
Snak qualifierSnak = otherStatement.getClaim().getMainSnak();
SnakGroup group = Datamodel.makeSnakGroup(Collections.singletonList(qualifierSnak));
Claim claim = Datamodel.makeClaim(qid1, baseStatement.getClaim().getMainSnak(),
Collections.singletonList(group));
Statement statement = Datamodel.makeStatement(claim, Collections.emptyList(), StatementRank.NORMAL, "");
ItemUpdate update = new ItemUpdateBuilder(qid1)
.addStatement(statement)
.build();
assertEquals("Q1377\tP38\tQ865528\tP38\tQ1377\n", export(update));
}
@Test
public void testNoSchema() throws IOException {
Project project = this.createCSVProject("a,b\nc,d");
Engine engine = new Engine(project);
StringWriter writer = new StringWriter();
Properties properties = new Properties();
exporter.export(project, properties, engine, writer);
assertEquals(QuickStatementsExporter.noSchemaErrorMessage, writer.toString());
}
@Test
public void testGetContentType() {
assertEquals("text/plain", exporter.getContentType());
}
}

2
extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WikibaseSchemaTest.java
View File

@ -66,7 +66,7 @@ public class WikibaseSchemaTest extends RefineTest {
private Project project;
static JSONObject jsonFromFile(String filename) throws IOException, JSONException {
public static JSONObject jsonFromFile(String filename) throws IOException, JSONException {
byte[] contents = Files.readAllBytes(Paths.get(filename));
String decoded = new String(contents, "utf-8");
return ParsingUtilities.evaluateJsonStringToObject(decoded);

15
extensions/wikidata/tests/src/org/openrefine/wikidata/testing/TestingDataGenerator.java
View File

@ -7,6 +7,12 @@ import org.openrefine.wikidata.schema.WbMonolingualExpr;
import org.openrefine.wikidata.schema.WbStringConstant;
import org.openrefine.wikidata.schema.entityvalues.ReconItemIdValue;
import org.openrefine.wikidata.schema.entityvalues.ReconPropertyIdValue;
import org.wikidata.wdtk.datamodel.helpers.Datamodel;
import org.wikidata.wdtk.datamodel.interfaces.Claim;
import org.wikidata.wdtk.datamodel.interfaces.ItemIdValue;
import org.wikidata.wdtk.datamodel.interfaces.PropertyIdValue;
import org.wikidata.wdtk.datamodel.interfaces.Statement;
import org.wikidata.wdtk.datamodel.interfaces.StatementRank;
import com.google.refine.model.Cell;
import com.google.refine.model.Recon;
@ -14,6 +20,8 @@ import com.google.refine.model.ReconCandidate;
public class TestingDataGenerator {
protected static PropertyIdValue pid = Datamodel.makeWikidataPropertyIdValue("P38");
public static Recon makeNewItemRecon(long judgementId) {
Recon recon = Recon.makeWikidataRecon(judgementId);
recon.judgment = Recon.Judgment.New;
@ -59,4 +67,11 @@ public class TestingDataGenerator {
public static WbMonolingualExpr getTestMonolingualExpr(String langCode, String langLabel, String text) {
return new WbMonolingualExpr(new WbLanguageConstant(langCode, langLabel), new WbStringConstant(text));
}
public static Statement generateStatement(ItemIdValue from, ItemIdValue to) {
Claim claim = Datamodel.makeClaim(from, Datamodel.makeValueSnak(pid, to), Collections.emptyList());
return Datamodel.makeStatement(claim, Collections.emptyList(), StatementRank.NORMAL, "");
}
}

6
extensions/wikidata/tests/src/org/openrefine/wikidata/updates/scheduler/QuickStatementsUpdateSchedulerTest.java
View File

@ -43,6 +43,12 @@ public class QuickStatementsUpdateSchedulerTest extends UpdateSchedulerTest {
ItemUpdate update = new ItemUpdateBuilder(newIdA).addStatement(sNewAtoNewB).build();
schedule(update);
}
@Test
public void testSelfEditOnNewITem() throws ImpossibleSchedulingException {
ItemUpdate update = new ItemUpdateBuilder(newIdA).addStatement(sNewAtoNewA).build();
assertEquals(Arrays.asList(update), schedule(update));
}
@Override
public UpdateScheduler getScheduler() {

20
extensions/wikidata/tests/src/org/openrefine/wikidata/updates/scheduler/UpdateSchedulerTest.java
View File

@ -25,19 +25,13 @@ public abstract class UpdateSchedulerTest {
protected ItemIdValue newIdA = TestingDataGenerator.makeNewItemIdValue(1234L, "new item A");
protected ItemIdValue newIdB = TestingDataGenerator.makeNewItemIdValue(5678L, "new item B");
protected static PropertyIdValue pid = Datamodel.makeWikidataPropertyIdValue("P38");
protected Statement sAtoB = generateStatement(existingIdA, existingIdB);
protected Statement sBtoA = generateStatement(existingIdB, existingIdA);
protected Statement sAtoNewA = generateStatement(existingIdA, newIdA);
protected Statement sAtoNewB = generateStatement(existingIdA, newIdB);
protected Statement sNewAtoB = generateStatement(newIdA, existingIdB);
protected Statement sNewAtoNewB = generateStatement(newIdA, newIdB);
public static Statement generateStatement(ItemIdValue from, ItemIdValue to) {
Claim claim = Datamodel.makeClaim(from, Datamodel.makeValueSnak(pid, to), Collections.emptyList());
return Datamodel.makeStatement(claim, Collections.emptyList(), StatementRank.NORMAL, "");
}
protected Statement sAtoB = TestingDataGenerator.generateStatement(existingIdA, existingIdB);
protected Statement sBtoA = TestingDataGenerator.generateStatement(existingIdB, existingIdA);
protected Statement sAtoNewA = TestingDataGenerator.generateStatement(existingIdA, newIdA);
protected Statement sAtoNewB = TestingDataGenerator.generateStatement(existingIdA, newIdB);
protected Statement sNewAtoB = TestingDataGenerator.generateStatement(newIdA, existingIdB);
protected Statement sNewAtoNewB = TestingDataGenerator.generateStatement(newIdA, newIdB);
protected Statement sNewAtoNewA = TestingDataGenerator.generateStatement(newIdA, newIdA);
public abstract UpdateScheduler getScheduler();