From fff6eb0aa282a1e0f0239e3d45eafe9bc936ab0b Mon Sep 17 00:00:00 2001 From: Will Moffat Date: Thu, 8 Apr 2010 20:18:38 +0000 Subject: [PATCH] JSLint: legimate comparisions to 0 and null should be made using === git-svn-id: http://google-refine.googlecode.com/svn/trunk@425 7d457c2a-affb-35e4-300a-418c747d4874 --- src/main/webapp/scripts/dialogs/recon-dialog.js | 4 ++-- src/main/webapp/scripts/project/history-widget.js | 2 +- .../webapp/scripts/protograph/schema-alignment-ui-link.js | 2 +- .../webapp/scripts/protograph/schema-alignment-ui-node.js | 2 +- src/main/webapp/scripts/views/data-table-cell-ui.js | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main/webapp/scripts/dialogs/recon-dialog.js b/src/main/webapp/scripts/dialogs/recon-dialog.js index 0632cb9d4..362c6c714 100644 --- a/src/main/webapp/scripts/dialogs/recon-dialog.js +++ b/src/main/webapp/scripts/dialogs/recon-dialog.js @@ -140,7 +140,7 @@ ReconDialog.prototype._populateDialog = function() { $(td1).html(type.name + '
' + type.id + ''); }; for (var i = 0; i < this._types.length; i++) { - createTypeChoice(this._types[i], i == 0); + createTypeChoice(this._types[i], i === 0); } /* @@ -209,7 +209,7 @@ ReconDialog.prototype._rewirePropertySuggests = function(schema) { ReconDialog.prototype._onOK = function() { var tab = $("#recon-dialog-tabs").tabs('option', 'selected'); - if (tab == 0) { + if (tab === 0) { this._onDoHeuristic(); } else { this._onDoStrict(); diff --git a/src/main/webapp/scripts/project/history-widget.js b/src/main/webapp/scripts/project/history-widget.js index 95016897b..668c53722 100644 --- a/src/main/webapp/scripts/project/history-widget.js +++ b/src/main/webapp/scripts/project/history-widget.js @@ -65,7 +65,7 @@ HistoryWidget.prototype._render = function() { } else { for (var i = 0; i < this._data.past.length; i++) { var entry = this._data.past[i]; - renderEntry(elmts.pastDiv, entry, i == 0 ? 0 : this._data.past[i - 1].id, "Undo to here"); + renderEntry(elmts.pastDiv, entry, i === 0 ? 0 : this._data.past[i - 1].id, "Undo to here"); } } diff --git a/src/main/webapp/scripts/protograph/schema-alignment-ui-link.js b/src/main/webapp/scripts/protograph/schema-alignment-ui-link.js index 57be3619d..947393dc5 100644 --- a/src/main/webapp/scripts/protograph/schema-alignment-ui-link.js +++ b/src/main/webapp/scripts/protograph/schema-alignment-ui-link.js @@ -359,7 +359,7 @@ SchemaAlignmentDialog.UILink.prototype._configureTarget = function() { id: expected_type.id, name: expected_type.name }; - if (expected_type["/freebase/type_hints/mediator"] == true) { + if (expected_type["/freebase/type_hints/mediator"] === true) { self._link.target.nodeType = "anonymous"; } else if (expected_type.id == "/type/key") { self._link.target.nodeType = "cell-as-key"; diff --git a/src/main/webapp/scripts/protograph/schema-alignment-ui-node.js b/src/main/webapp/scripts/protograph/schema-alignment-ui-node.js index eca47d1e2..e5c96d7d5 100644 --- a/src/main/webapp/scripts/protograph/schema-alignment-ui-node.js +++ b/src/main/webapp/scripts/protograph/schema-alignment-ui-node.js @@ -420,7 +420,7 @@ SchemaAlignmentDialog.UINode.prototype._showNodeConfigDialog = function() { } }); - if ((!("columnName" in self._node) || !self._node.columnName) && columnIndex == 0) { + if ((!("columnName" in self._node) || !self._node.columnName) && columnIndex === 0) { radio.attr("checked", "true"); } else if (column.name == self._node.columnName) { radio.attr("checked", "true"); diff --git a/src/main/webapp/scripts/views/data-table-cell-ui.js b/src/main/webapp/scripts/views/data-table-cell-ui.js index 34d342de5..08f5e4ec3 100644 --- a/src/main/webapp/scripts/views/data-table-cell-ui.js +++ b/src/main/webapp/scripts/views/data-table-cell-ui.js @@ -26,7 +26,7 @@ DataTableCellUI.prototype._render = function() { .mouseenter(function() { editLink.css("visibility", "visible"); }) .mouseleave(function() { editLink.css("visibility", "hidden"); }); - if (!cell || ("v" in cell && cell.v == null)) { + if (!cell || ("v" in cell && cell.v === null)) { $('').html(" ").appendTo(divContent); } else if ("e" in cell) { $('').addClass("data-table-error").text(cell.e).appendTo(divContent); @@ -315,7 +315,7 @@ DataTableCellUI.prototype._previewCandidateTopic = function(id, elmt) { DataTableCellUI.prototype._startEdit = function(elmt) { self = this; - var originalContent = !this._cell || ("v" in this._cell && this._cell.v == null) ? "" : this._cell.v; + var originalContent = !this._cell || ("v" in this._cell && this._cell.v === null) ? "" : this._cell.v; var menu = MenuSystem.createMenu().addClass("data-table-cell-editor").width("400px"); menu.html(