Commit Graph

18 Commits

Author SHA1 Message Date
Iain Sproat
075e985865 Rename CSVRowParserTests to TsvCsvRowParserTests.
TsvCsvImporterTests - identified 3 tests which now fail when using different parser.  Tests are enabled=false and in 'broken' testing group.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@793 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 06:50:30 +00:00
Iain Sproat
03b1ab01f4 RowParser is no longer a parameter of read method in TsvCsvImporter (now handled in the method itself)
CSVRowParserTests is now tidied - with expected and actual being input into the correct parameters of Assert.assertEquals.  One more test passes, but still 2 tests failing.


git-svn-id: http://google-refine.googlecode.com/svn/trunk@792 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 06:24:58 +00:00
David Huynh
bd8d214a49 Resolved issue 19 for TSV as well, not just for CSV.
Touched up TsvCsvImporterTests to leave the comma vs. tab guessing to the importer itself. All tests still pass.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@790 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:55:02 +00:00
Iain Sproat
6f74bcaa26 comments tidied in TsvCsvImporterTests and ImporterUtilities
git-svn-id: http://google-refine.googlecode.com/svn/trunk@789 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:40:46 +00:00
David Huynh
68fbd3320b Got disabled tests in Issue 41 to pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@788 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:26:29 +00:00
Iain Sproat
22fb3a1585 fixing issue introduced in r782. - importer now autodetects separator correctly.
Uses original CSV parser, but 4no tests do not pass (ignored with enabled=false flag).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@787 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 03:22:22 +00:00
David Huynh
590358ca63 More new commands.* packages for better organization of commands. More re-organization of commands.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@785 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 02:24:45 +00:00
Stefano Mazzocchi
f28e23e503 Committing patches by Iain:
- use OpenCSV parser instead of our own
 - use TestNG instead of JUnit which is a lot more configurable in test selection (and allows us to do a much better job a leaving the tree green even while developing tests that are known to fail)
 - integrated TestNG in './gridworks test'
 - added Iain to the list of contributors in README.txt
 - changed the Eclipse test launch file to use the TestNG launcher (unfortunately, this is not shipped by default in Eclipse, so you have to install it yourself from the http://beust.com/eclipse update file, I'll add this to the wiki shortly)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@782 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-16 18:42:52 +00:00
Stefano Mazzocchi
828acfc694 better way to ignore tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@780 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-15 03:12:23 +00:00
Stefano Mazzocchi
9f1358ea38 comment out tests that don't pass
(leaving the tree in a broken state is a nono)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@778 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-15 02:45:54 +00:00
Iain Sproat
9b2aa5290c split method of CSVRowParserTests is now unit tested. 3 tests fail (related to issue #19) - behaviour of CSV importer needs some further work.
logger now correct on GridworksServletTests


git-svn-id: http://google-refine.googlecode.com/svn/trunk@777 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 22:34:50 +00:00
Iain Sproat
624b421da9 doGet and doPost methods of GridworksServlet now unit tested. @Ignore attribute added to GridworksServletStub to prevent ./gridworks server_test failing.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@769 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 17:34:40 +00:00
Iain Sproat
0af4e294f8 GridworksServlet is now unit tested with a single regression test
git-svn-id: http://google-refine.googlecode.com/svn/trunk@765 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 14:57:04 +00:00
Iain Sproat
a096fae7a0 ParsingUtilities.evaluateJsonStringToObject is now unit tested
CommandTests and CancelProcessesCommandTests are slightly formatted to match code standards.
Command and CancelProcessesCommand are slightly tweaked to pass under all unit tests.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@753 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 09:23:37 +00:00
Stefano Mazzocchi
5070de6446 committing Iain's new tests and polished things a little
(also added a test-specific log4j conf so that we don't show all the warnings during the tests that were distracting)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@744 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 00:54:02 +00:00
Stefano Mazzocchi
11da70d223 Applying patch for Issue 21 from iainsproat
git-svn-id: http://google-refine.googlecode.com/svn/trunk@722 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 08:59:05 +00:00
Stefano Mazzocchi
f0ba42f355 make sure to check the tests as well
git-svn-id: http://google-refine.googlecode.com/svn/trunk@431 7d457c2a-affb-35e4-300a-418c747d4874
2010-04-09 00:23:14 +00:00
Stefano Mazzocchi
8f5c35799b making room for windmill tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@403 7d457c2a-affb-35e4-300a-418c747d4874
2010-04-07 00:35:59 +00:00