Commit Graph

77 Commits

Author SHA1 Message Date
Stefano Mazzocchi
856ef6a65a commented out unused variables
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2352 7d457c2a-affb-35e4-300a-418c747d4874
2011-11-01 21:47:24 +00:00
Tom Morris
fe7bf1d1f0 Refactor to conform to method naming conventions
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2344 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-21 16:57:52 +00:00
Tom Morris
ab950689dd Add debugging info - mostly toString() methods for types missing them
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2343 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-21 16:46:55 +00:00
Tom Morris
4966dcc61f Basic trivial test for Excel importer. Please add to this...
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2329 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-12 23:42:29 +00:00
Stefano Mazzocchi
1f67866258 fixing a bunch of inconsistencies and potential bugs as indicated by findbugs, pmd and eclipse
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2301 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 21:23:23 +00:00
Stefano Mazzocchi
af5b49eab9 whitespace (no functional changes)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2299 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:25:15 +00:00
Tom Morris
6b97f6602f Fix last(?) failing test
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2297 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:16:19 +00:00
Tom Morris
31073d7712 Refactor importer interfaces to narrow exceptions thrown and handled
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2296 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:06:53 +00:00
Tom Morris
e3f1fab4e8 Issue 453 - Add test for importing top level JSON array - from Thad
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2287 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:52:31 +00:00
Tom Morris
79c795138c Provide exception info for failures
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2286 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:51:06 +00:00
Tom Morris
4a4daf7112 Add some Javadoc. No functional changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2285 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:29:14 +00:00
Tom Morris
cf206c33bc Update test to accommodate new test for pending operations
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2282 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 21:09:31 +00:00
Tom Morris
97dda9f577 Refactor option mock setup and verification - all tests green (for this module)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2281 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:53:19 +00:00
Tom Morris
90c2715901 Back out workaround for cell numbering
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2280 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:29:53 +00:00
David Huynh
58414f72df Got more tests to pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2279 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:01:27 +00:00
David Huynh
a9279e2997 Got more tests to pass.
Note that the automatic column naming behavior did change from { "Column", "Column2", "Column3", ... } to { "Column 1", "Column 2", "Column 3", ... }.

Also note that the tsv/csv importer no longer supports the option not to split into columns. That's another importer (the line-based importer).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2277 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 07:09:05 +00:00
David Huynh
1c5dc32b88 Fixed tsv/csv tests.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2276 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 06:22:30 +00:00
David Huynh
3c6358d518 Fixed json tests.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2275 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 04:50:05 +00:00
Tom Morris
850e147779 Changes needed to get FixedWidthImporter test to pass
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2274 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-05 23:49:14 +00:00
Tom Morris
e064dcce3e Add support for getTempDir() as required by new importers
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2273 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-05 23:42:15 +00:00
Tom Morris
1b197d93d8 Issue 447 - allow users to specify delimiters for toTitlecase function
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2253 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-20 05:07:46 +00:00
Tom Morris
884d0ea8d4 Look up functions by name to make tests more directly analogous to user view
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2252 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-20 05:00:48 +00:00
Tom Morris
59d6020979 Add basic test coverage for ToTitleCase and (commented out) support for 2nd parameter
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2250 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-19 15:47:33 +00:00
Tom Morris
f309a26a95 Fix XML importer test to handle new exception being thrown
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2249 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-19 15:34:29 +00:00
David Huynh
90ad8247b7 Minor layout change in custom tabular exporter dialog from Thad's suggestion.
Fixed small compile error in main/tests/.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2226 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-30 21:21:46 +00:00
Tom Morris
da7347e7b1 Make sure all conditionals and loops are in blocks (too bug-prone otherwise)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2183 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 22:21:47 +00:00
Tom Morris
97a0f2a33e Organize imports. com.google.refine last in a section of its own. Everything alphabetical in its section.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2180 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 21:10:22 +00:00
Tom Morris
7fd6e22af4 Convert tabs to spaces. No functional changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2172 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 20:26:32 +00:00
Tom Morris
123614539d Add missing @Override annotations
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2171 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 19:30:23 +00:00
David Huynh
78edff6f7f Merged new importer UI work from branch over.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2170 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 03:34:47 +00:00
Tom Morris
d03c8a1f70 Issue 415: Add some tests for arithmetic expressions in GREL
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2122 7d457c2a-affb-35e4-300a-418c747d4874
2011-06-23 23:41:35 +00:00
Tom Morris
73acd497e9 Fix for issue 358 from Tomaz Solc. Don't return a NaN when comparing two 0-length word lists.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2088 7d457c2a-affb-35e4-300a-418c747d4874
2011-06-06 21:30:46 +00:00
Tom Morris
bbc2b3d363 Test provided by Gabriel Sjoberg. Thank you!
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2002 7d457c2a-affb-35e4-300a-418c747d4874
2011-02-04 20:09:01 +00:00
Tom Morris
3e08aca4ec Issue 304 - Apply patch to fix test. Thanks to GabrielS
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2001 7d457c2a-affb-35e4-300a-418c747d4874
2011-02-04 04:55:05 +00:00
David Huynh
6fb2b05739 Fixed issue 294: "Exporting date type column to TSV/CSV shows java debugging information instead of value" with help from Gabriel Sjoberg.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1967 7d457c2a-affb-35e4-300a-418c747d4874
2010-12-28 15:54:24 +00:00
Iain Sproat
2f564589f5 Adding a Fixed Width data importer (Issue 85) and associated tests.
Although this importer is 'wired up', it requires a property "fixed-column-widths" which is not (yet) implemented in the UI.  But the ImporterRegister.guessImporter method will probably select the CsvTsvImporter before the FixedWidthImporter anyway.  I suggest an improvement to the project creation UI and/or the guessImporter method will be required.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1857 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 13:15:41 +00:00
Iain Sproat
4f9dc38066 TsvCsvImporter now uses the CSV test methods to also test the TSV importer. Separate tests for the two importers are no longer required.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1856 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 13:06:39 +00:00
Iain Sproat
37a6f938c3 The TestNG DataProvider for the Tsv/Csv importer tests was previously providing just one test case with two parameters, rather than the two test cases of one parameter each which is required. This is now fixed, and the tests pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1855 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 10:52:18 +00:00
David Huynh
5a17acfd70 Prepended license text to java source
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1613 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-20 20:45:52 +00:00
Tom Morris
05d8180016 Disable failing test until it can be debugged
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1602 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-18 05:52:11 +00:00
Tom Morris
7dcd0c073d Revert bad commit r1600
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1601 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-18 05:19:05 +00:00
Tom Morris
79c00bab36 Incomplete - task 157: Integrate Google Spreadsheet import/export plugin
http://code.google.com/p/google-refine/issues/detail?id=157

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1600 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-18 04:59:39 +00:00
Tom Morris
c8bb6a3475 Fix failing template exporter test. Disable HTML exporter no column headers test (unimplemented)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1570 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 18:07:17 +00:00
Tom Morris
aba75a9b4a Add a couple more tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1568 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 17:10:07 +00:00
Tom Morris
87b6d940b7 Some very basic tests for exporters with no test coverage
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1567 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 15:50:25 +00:00
Tom Morris
0041863a13 Placeholder (failing) tests for exporters with no test coverage
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1566 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 13:27:44 +00:00
David Huynh
73042712ed Made csv/tsv importer not trim whitespace even if "guess cells' types" is checked (for cells that are strings).
Updated csv tests to expect un-trimmed cells.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1557 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 05:30:15 +00:00
Iain Sproat
d977f42f51 Changed behaviour of the XmlImporter to make it more permissive, and allow arrays within mixed elements to be used as candidates for importing to Refine.
This change has also allowed the JsonImporter to pass all its unit tests without any further modification.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1425 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 18:33:59 +00:00
Iain Sproat
ec0581e3a9 Added two additional unit tests for ensuring the XmlImporter is behaving correctly.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1424 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 17:32:27 +00:00
Iain Sproat
8d51223610 An additional unit test for the JsonImporter, which it unfortunately fails.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1423 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 15:19:29 +00:00