Commit Graph

277 Commits

Author SHA1 Message Date
Thad Guidry
c83dbe3b23
Merge branch 'master' into stundzig-develop/1086-quotecharacter 2018-02-03 07:20:45 -06:00
Antonin Delpeuch
c9395d564c Merge branch 'develop/1086-quotecharacter' of https://github.com/stundzig/OpenRefine into stundzig-develop/1086-quotecharacter 2018-02-03 07:56:30 +00:00
Jacky
c4b0ff6bea data package metadata (#1398)
* fix the appbundle issue #1209

* fix #1162

allow the JRE 9

* fix the package declarations

* remove the _ from the method name

* use the explicit scoping

* remote extra ;

* fix issued from codacy

* fix issued from codacy

* add preferences link to the index page

* handle the empty user metadata

* fix 'last modified' sorting issue #1307

* prevent overflow of the table. issue #1306

* add isoDateParser to sort the date

* prevent overflow of the project index

* remove sorter arrow for action columns

* disable editing the internal metadata

* adjust the width of the table

* change MetaData to Metadata

* change the filed name from rowNumber to rowCount

* put back the incidently deleted gitignore

* add double quote to prevent word splitting

* UI improvement on metadata view and project list view

* remove the date field in metadata

* message notification of the free RAM. Issue #1295

* UI tuning for metadata view

* shorten the ISO date to locale date format

* Added translation using Weblate (Portuguese (Brazil))

* remove the rename link

* Ignore empty language files introduced by Weblate

* Add UI for Invert text filter

* Backend support for Inverting Text search facets

* Fix reset on text search facet

* More succinct return statements

* add tests for SetProjectMetadataCommand

* Tidying up for Codacy

* Added Tests for TextSearchFilter

* Corrections for Codacy

* More code tidy up

* let the browser auto fit the table cell when resizing/zooming

* fix import multiple excel with mulitple sheets issue #1328

* check if the project has the userMetadata

* fix the unit test
support multi files with multi tables for open office

* prevent the same key for user metadata

* replace _ with variable for exception

* fix the no-undef issue

* to adjust the width of transform dialog. issue #1332

* fix the row count refresh issue

* extract method

* move the log message

* cosmatic changes for codacy

* fix typo

* bump to version 2.8

* .gitignore is now working

* preview stage won't have the metadata populated, so protect NPE

* Update README.md

No more direct link to the last version tag, which will avoid having to think of updating the readme

* refacotring the ProjectMetadata class

* introduce the IMetadata interface

* create submodule of dataschema

* add back

* setup lib for dataschema; upgrade the apache lang to lang3

* replace escape* functions from apache lang3

* replace the ProjectMetadata with IMetadata interface

* add missing jars

* set the IMetadata a field of Project

* remove PreferenceStore out of Project model

* fix test SetProjectMetadataCommandTests by casting

* introdcue the AbstractMetadata

* introdcue the AbstractMetadata

* reorganize the metadata package

* allow have mulitiple metadata for a project

* support for mulitple metadata format

* remove jdk7 since 'table schema' java implmentation only support jdk8+

* set execute permission for script

* fix the Unit Test after Metadata refactoring

* restore the apache lang2.5 since jetty 6.1.22 depend on it

* add commons lang 2.5 jar

* git submodule add  https://github.com/frictionlessdata/datapackage-java

* remove the metadata parameter from the ProjectManager.registerProject method

* remove hashmap _projectsMetadata field from the ProjectManager and FileProjectManager

* init the Project.metadataMap

* fix Unit Test

* restore the ProjectMetaData map to ProjectManager

* put the ProjectMetaDta in place for ProjectManager and Project object

* check null of singleton instead of create a constructor just for test

* load the data package metadata

* importing data package

* importing data package

* encapsulate the Package class into DataPackageMetadata

* user _ to indicate the class fields

* introduce base URL in order to download the data files

* import data package UI and draft backend

* import data package UI

* fix typo

* download the data set pointed from metadata resource

* save and load the data package metadata

* avoid magic string

* package cleanup

* set the java_version to 1.8

* set the min jdk to 1.8

* add the 3rd party src in the build.xml

* skip the file selection page if only 1 DATA file

* add files structure for json editor

* seperate out the metadata file from the retrival file list

* rename the OKF_METADATA to DATAPACKAGE_METADATA

* clean up

* implement GetMetadateCommand class

* display the metadata in json format

* git submodule update --remote --merge

* adjust the setting after pulling from datapackage origin

* fix the failed UT DateExtensionTests.testFetchCounts due to new json jar json-20160810.jar will complain: JSONObject["float"] not a string.

* clean up the weird loop array syntax get complained

* remove the unused constant

* export in data package format

* interface cleanup

* fix UT

* edit the metadata

* add UT for SetMetadataCommand

* fix UT for SetMetadataCommand

* display the data package metadata link on the project index page

* update submodule

* log the exceptions

* Ajv does not work properly, use the back end validation instead

* enable the validation for jsoneditor

* first draft of the data validation

* create a map to hold the constraint and its handler

* rename

* support for minLength and maxLength from spec

* add validate command

* test the opeation instead of validate command

* rename the UT

* format the error message and push to the report

* fix row number

* add resource bundle for validator

* inject the code of the constrains

* make the StrSubstitutor works

* extract the type and format information

* add the customizedFormat to interface to allow format properly

* get rid of magic string

* take care of missing parts of the data package

* implement RequiredConstraint

* patch for number type

* add max/min constraints

* get the constrains directly from field

* implement the PatternConstraint

* suppress warning

* fix the broken UT when expecting 2 digits fraction

* handle the cast and type properly

* fix the missing resource files for data package when run from command line

* use the copy instead of copydir

* add script for appveyor

* update script for appveyor

* do recursive clone

* correct the git url

* fix clone path

* clone folder option does not work

* will put another PR for this. delete for now

* revert the interface method name

* lazy loading the project data

* disable the validate menu for now

* add UT

* assert UTs

* add UT

* fix #1386

* remove import

* test the thread

* Revert "test the thread"

This reverts commit 779214160055afe3ccdcc18c57b0c7c72e87c824.

* fix the URLCachingTest UT

* define the template data package

* tidy up the metadata interface

* check the http response code

* fix the package

* display user friendly message when URL path is not reachable

* populate the data package schema

* Delete hs_err_pid15194.log

* populate data package info

* add username  preference and it will be pulled as the creator of the metadata

* undo the project.updateColumnChange() and start to introduce the fields into the existing core model

* tightly integrate the data package metadata

* tightly integrate the data package metadata for project level

* remove the submodule

* move the edit botton

* clean up build

* load the new property

* load the project metadata

* fix issues from codacy

* remove unused fields and annotation

* check the http response code firstly

* import zipped data package

* allow without keywords

* process the zip data package from url

* merge the tags

* check store firstly

* remove the table schema src

* move the json schema files to schema dir

* add comment

* add comment

* remove git moduels

* add incidently deleted file

* fix typo

* remove SetMetadataCommand

* revert change

* merge from master
2018-02-02 13:24:19 +00:00
Antonin Delpeuch
47f44b06c4 Make Codacy happy 2018-02-02 11:57:20 +00:00
Antonin Delpeuch
1f87a26f4c Include image file names like templates in Wikitable importer 2018-02-02 11:22:15 +00:00
Antonin Delpeuch
843641ca74 Parse headers just like other cells in Wikitable importer
This makes the column names a bit less meaningful,
but this is necessary to handle cases where headers
are inserted anywhere in the table.
2018-02-02 10:48:31 +00:00
Antonin Delpeuch
0426704938 Add helper createProjectWithColumns 2018-01-27 13:58:06 +00:00
Antonin Delpeuch
feae25a5ff Migrate more tests to the createCSVProject helper 2018-01-27 13:45:44 +00:00
Antonin Delpeuch
8f9fc61046 Migrate TextSearchFacetTests.java to use the helpers 2018-01-27 13:45:44 +00:00
Antonin Delpeuch
5278e929a2 Refactor CrossFunctionTests' project creating logic into RefineTest 2018-01-27 13:45:44 +00:00
Owen Stephens
4320ef8c10 Resolved merge conflict 2018-01-16 17:41:56 +00:00
Owen Stephens
5acdb1429c Fix tests - Include new httpHeaders JSON array when creating new ColumnAdditionByFetchingURLsOperation 2018-01-16 17:22:48 +00:00
Jacky
3c25647f05 add find function. issue 1296 2018-01-14 22:04:26 -05:00
Olle Jonsson
76fa942490 Nobel prize winners CSV data typos 2018-01-07 21:28:07 +01:00
Antonin Delpeuch
45ccd0e1c0 Change HTTP error detection in URL fetching test 2018-01-03 22:44:32 +01:00
Antonin Delpeuch
dae4ac1ce4 Simpler way to pass the test when there are 503 errors 2018-01-03 19:03:26 +01:00
Antonin Delpeuch
32b7d2fa74 Looser check for 403 and 503 errors in URL caching test 2018-01-03 18:57:34 +01:00
Antonin Delpeuch
f14543bfca Fix URL caching test on Appveyor 2018-01-03 18:52:12 +01:00
Antonin Delpeuch
94b9d57528
Merge pull request #1397 from tiagofernandez/save-import-options
Revert 278f24c1 and adapt 0001d9f7 (ref. PR #1387)
2017-12-27 09:44:19 +01:00
Tiago Fernandez
00faf2a179 Revert 278f24c1 and adapt 0001d9f7 (ref. PR #1387) 2017-12-24 12:48:23 +01:00
Jacky
e5709efd46 fix issue #1341 2017-12-24 00:04:16 -05:00
Jacky
fb3620b3d9
Merge pull request #1388 from jackyq2015/issue/1386
Fix Issue #1386
2017-12-21 08:26:29 -05:00
Jacky
6c06424183
Merge pull request #1390 from jackyq2015/issue/1389
fix Issue #1389
2017-12-21 08:26:09 -05:00
Jacky
9107a0eb91 remove commented code 2017-12-21 08:24:29 -05:00
Jacky
e1a494aabd remove the print 2017-12-21 08:22:44 -05:00
Jacky
cd770aed25 revert unecessary changes 2017-12-20 18:52:53 -05:00
Jacky
2f050322b5 use join not sleep 2017-12-20 08:35:31 -05:00
Tiago Fernandez
0001d9f7b2 Test ImportingUtilities.createProjectMetadata() 2017-12-20 11:07:36 +01:00
Jacky
834b6c493c check isDone 2017-12-19 22:20:11 -05:00
Jacky
3fa994739a check isDone 2017-12-19 22:09:52 -05:00
Jacky
cce3ab6240 fix issue #1389 2017-12-19 21:00:03 -05:00
jackyq2015
136eba52df add missing import 2017-12-19 15:28:34 -05:00
jackyq2015
cb55b68449 add missing import 2017-12-19 15:23:39 -05:00
jackyq2015
81043e58e2 fix #1386 2017-12-19 12:54:26 -05:00
Jacky
d207c74f62 merge from master 2017-12-15 22:06:30 -05:00
Antonin Delpeuch
3c5a9b0754
Merge pull request #1357 from xseris/master
Tag system
2017-12-16 01:55:46 +00:00
Jacky
2afdcbf546 fix issue https://github.com/jackyq2015/OpenRefine/issues/2 2017-12-15 16:37:38 -05:00
Jacky
0258dc1787 fix issue #1383. use the localDateTime for project info 2017-12-15 15:24:09 -05:00
xseris
ee8ed8f563 Refresh tag cell 2017-12-08 00:46:59 +01:00
xseris
b16941777e Modified tags in metadata dialog and moved column right to name 2017-12-07 23:45:36 +01:00
xseris
f21230804b Fixed Mockito tests 2017-12-01 17:00:45 +01:00
Owen Stephens
93431daecf Remove unused variable 2017-11-29 09:47:03 +00:00
Owen Stephens
0b433fc5ec Updated copyright statement 2017-11-29 00:59:49 +00:00
Owen Stephens
d64dee71dd Extended tests and code for user friendly regular expression syntax errors 2017-11-28 16:20:24 +00:00
Owen Stephens
441d9f7f10 Initial tests and code for user friendly regular expression syntax errors 2017-11-24 18:24:16 +00:00
Thad Guidry
34f38ccaf8
Merge pull request #1336 from ostephens/multi-cell-join-tests
Add tests for JoinMultiValuedCells
2017-11-16 22:49:03 -06:00
Jacky
8d2c8b521b
Merge pull request #1334 from jackyq2015/issue/1328
fix import multiple excel with mulitple sheets issue #1328
2017-11-16 21:30:24 -05:00
Jacky
1d2998f374 fix the unit test
support multi files with multi tables for open office
2017-11-16 10:29:16 -05:00
Owen Stephens
df920777ac Moved variable to local scope 2017-11-16 12:47:05 +00:00
Antonin Delpeuch
78b7f01be5
Merge pull request #1327 from ostephens/invert-filter
Invert text search facet/text filter
2017-11-16 08:05:31 +00:00
Owen Stephens
742b42ade1 More code tidy up 2017-11-15 19:01:52 +00:00
Owen Stephens
2d0f48e93f Corrections for Codacy 2017-11-15 18:51:58 +00:00
Owen Stephens
3a31e69c2b Added Tests for TextSearchFilter 2017-11-15 18:31:55 +00:00
Qi Cui
6bdba6948e add tests for SetProjectMetadataCommand 2017-11-14 15:54:22 -05:00
Jacky
75b82106b4 fix the package declarations 2017-11-03 17:11:31 -04:00
Thad Guidry
d72a2de348 Revert "Extend cross() function to support multiple-value-cell-input" 2017-10-26 17:37:10 -05:00
Thad Guidry
3d0e96a0ce Merge pull request #1290 from claussni/cross-func-split
Extend cross() function to support multiple-value-cell-input
2017-10-26 14:23:23 -05:00
Ralf Claussnitzer
0b107ec5e9 Add optional 4th parameter to cross() function
The cross function now accepts a 4th parameter defining a regular
expression separator for splitting multi-value field values when joining
projects.

See https://github.com/OpenRefine/OpenRefine/issues/1204#issuecomment-326320954
2017-10-26 19:50:02 +02:00
Owen Stephens
c10f72437f Add tests for JoinMultiValuedCells 2017-10-25 11:15:59 +01:00
Antonin Delpeuch
88b10a2917 Merge pull request #1278 from ostephens/cell-split-regex
Cell split regex
2017-10-25 11:04:33 +01:00
Owen Stephens
300edcca74 Minor fix to comment in code 2017-10-24 08:58:32 +01:00
Owen Stephens
219e747147 Removed unused dependency 2017-10-24 08:54:58 +01:00
Owen Stephens
209500bf3a Add tests for SplitMulitValuedCells 2017-10-24 08:29:00 +01:00
Owen Stephens
bb6b3d6c29 Re-locate operations tests in correct folder 2017-10-23 18:54:59 +01:00
Antonin Delpeuch
e2a22a6994 Forbid pipe characters in URL references to ease parsing.
This is a temporary fix before we do full Wikitext parsing inside references
(this needs a change upstream). See https://github.com/sweble/sweble-wikitext/issues/67 .
2017-10-20 15:32:58 +01:00
Antonin Delpeuch
1da3c00cb1 Perform ASCII normalization earlier in FingerprintKeyer.
This closes #1256.
2017-09-27 09:23:40 +01:00
Antonin Delpeuch
a1b2c9b683 Add support for references in Wikitable importer.
Closes #1243.
2017-09-23 22:54:43 +01:00
Antonin Delpeuch
00f8e4fc6b Merge pull request #1237.
Conflicts:
	.classpath
	main/webapp/modules/core/langs/translation-en.json
	main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js

Closes #363 and #56.
2017-08-28 16:25:50 +01:00
Antonin Delpeuch
554b75fa7b Fix parsing of newlines in cells 2017-08-17 19:18:50 +01:00
Antonin Delpeuch
7989aacc58 Cleanup for Codacy 2017-08-17 12:40:56 +01:00
Antonin Delpeuch
637e69db9d Better error reporting and testing for Wikitext import 2017-08-16 10:30:51 +01:00
Antonin Delpeuch
3dcda5a42c Add reconciliation config in wikitext import. 2017-08-16 00:05:40 +01:00
Antonin Delpeuch
5390aa248c Fix DataExtensionTests (Tajikistan has only one currency, not two) 2017-08-15 22:11:00 +01:00
Antonin Delpeuch
d01de6ea85 Update tests 2017-08-15 22:09:45 +01:00
Antonin Delpeuch
aa4517ba58 Add support for colspan and rowspan in Wikitext 2017-08-15 11:28:43 +01:00
Antonin Delpeuch
e168c900e8 Add support for table headers 2017-08-13 20:14:48 +01:00
jackyq2015
45e3ea5e86 fix testng data path issue 2017-08-13 13:03:19 -05:00
jackyq2015
f3463c332e Unit test for issue #137 2017-08-13 12:37:20 -05:00
Antonin Delpeuch
b8a781d366 Add support for links (unreconciled for now) 2017-08-13 12:57:46 +01:00
Antonin Delpeuch
e6406f56ef Initial version of the wikitext importer 2017-08-13 11:26:59 +01:00
jackyq2015
588024f60d Merge branch 'master' of https://github.com/OpenRefine/OpenRefine 2017-08-06 22:06:58 -05:00
jackyq2015
fd58ac1e99 fix some xml issues 2017-08-06 22:05:17 -05:00
Antonin Delpeuch
3b30018cad Merge pull request #1216 from OpenRefine/issue1214
Add test for KeyValueColumnize
2017-08-03 19:31:35 +01:00
Antonin Delpeuch
135dd50413 Fix Codacy issues 2017-08-03 12:47:09 +01:00
Antonin Delpeuch
afed8eb28a Generate code coverage reports with Jacoco 2017-08-03 11:07:14 +01:00
Antonin Delpeuch
66eac0fae9 Ensure null values are not cached in URL fetching operation. Closes #1219. 2017-08-01 13:05:29 +01:00
Antonin Delpeuch
7de2a57c3a Add RefineServletStub initialization in KeyValueColumnizeTests 2017-07-26 18:39:08 +01:00
Antonin Delpeuch
d941320f5e Adapt test about #1214 to show how the function currently works.
With this test, if someone tries to fix this "bug" in the future, they will realize this use case should be preserved.
2017-07-26 18:07:52 +01:00
Antonin Delpeuch
453d35032b Add test for issue #1214 2017-07-26 00:41:06 +01:00
jackyq2015
64ab5a4409 unit test for backward compatibility for cross function 2017-07-23 19:31:25 -04:00
Thad Guidry
7f92251ed1 Merge pull request #1210 from wetneb/extend
Add data extension capabilities to the reconciliation API
2017-07-17 18:01:37 -05:00
Antonin Delpeuch
c04d9f3c33 Switch to public WMF endpoint for tests 2017-07-16 11:54:12 +01:00
Antonin Delpeuch
84c06821ee Data extension tests 2017-07-16 11:47:12 +01:00
jackyq2015
1ee339cbbd cross function test suite. #1204 2017-06-28 08:12:36 -04:00
jackyq2015
af731a3c1f add test case for cross function 2017-06-25 23:27:48 -04:00
Bob Harper
909df1b6a7 xor can also accept 2+ params, rewrite tests to be consistent 2017-04-27 11:20:48 +01:00
Bob Harper
4ea0f440e9 remove 3 param error test for 'and' and 'or' 2017-04-27 11:07:04 +01:00
Antonin Delpeuch
22124ac57e Add checkbox to disable caching 2017-03-09 00:21:34 +00:00
Antonin Delpeuch
32c232c2d6 Move to Guava's cache for ColumnAdditionByFetchingURLsOperation 2017-03-08 09:32:34 +00:00
Antonin Delpeuch
3297e6e7ee Add tests for the URL caching feature 2017-03-08 00:50:09 +00:00