Commit Graph

669 Commits

Author SHA1 Message Date
Jathin Sreenivas
4d106b118f
Templating exporter should have clear error reporting (#3945)
* Templating exporter should have clear error reporting

* Using i18n for meesage and removed the unnecessary null check

* Removed usage of bindings

* Adding tests for grel, renamed ParsetTests to TemplatingParserTests

* Regex to test the keys of the template exporter

* Cancel changes to the templating parser

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-11-25 21:19:10 +01:00
nikhilp3
77d958c9d4
Move textSearchCounter to static variable (#4257)
* Move textSearchCounter to static variable

* Add test for checkbox bug

* Add test for checkbox bug
2021-11-24 13:44:53 +01:00
Nabeel Sait
282b5a7956
Warn on fill/blank down when a sorting criterion is applied (#4284)
* Fixes #3256, with Cypress tests

Co-authored-by: Nabeel Sait <>
2021-11-10 20:24:19 +01:00
Albin Larsson
919892b85f
Make it possible to view more than 50 rows (#3249)
Adding the options 100, 500, 1000

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-10-22 19:50:10 +02:00
Pablo Castellano
3bca46329c
Update wikidata reconciliation endpoint (#4206) 2021-10-20 14:45:57 +02:00
Matthieu Jonglez
aa1b61769c
Fixes #3730. IDs / URIs should be encoded with a method that encodes special characters like # (#3731) 2021-10-19 15:47:10 +02:00
Antonin Delpeuch
9919ee51bf
Respect spaces in clustering dialog. Closes #4004. (#4005) 2021-06-27 16:14:22 +02:00
Florian Giroud
91440b4cfb
Tests stability (#4014)
* Cypress 7.5 now redirects properly, removed doCreateProjectThroughUserInterface method

* temporarily changed CI

* temporarily changed CI

* Fixed an invalid call to a method that doesn't exist, fixed importing tutorial tests

* Fixed row_records test

* Attempt to fix flaky tests by improving the way we check for notifications

* disabledf scatterplot testing

* Attempt to fix flaky tests

* force CI

* force CI

* force CI

* force CI, edge

* attempt to fix flaky tests

* Attempt to fix flaky tests

* CI

* fastfix

* Code cleaning & linting

* Removed temporary edit of CI/CD

* revert debug edit of test files
2021-06-26 16:15:28 +05:30
Antonin Delpeuch
d647f93c7c
Remove lavalamp js dependency, non-free. Closes #3957. (#3974) 2021-06-11 19:18:55 +02:00
gitonthescene
dd49148f38
closes #3862 (#3865)
Co-authored-by: Douglas Mennella <douglas.mennella@gmail.com>
2021-05-08 09:06:42 +02:00
Akshita Singh
d269a5ea4d
Common transforms on multiple columns (#3789)
Closes #1843.
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-04-26 11:33:23 +02:00
Antoine Beaubien
fd3bfbea75
(I #2771) Control facet panel width thru a preference (#2772)
* First implementation, functional

First implementation, functional. Only 2 lines of code.

* Added min 200px, max 500px

Added validation to constrait the panel to have at least a minimum of 200px and a maximum of 500px.

* Update project.js

Change the pref key to facetsHistoryPanelWidth.

* Change to ui.browsing.facetsHistoryPanelWidth

Change ui.facetsHistoryPanelWidth to ui.browsing.facetsHistoryPanelWidth.

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-04-16 18:06:04 +02:00
Matthieu Jonglez
c19aa3546f
Fixes #3809. Enables cross-origin property type-ahead. (#3810) 2021-04-14 22:04:14 +02:00
Antoine Beaubien
1289f9d9de
Follow-up fix for facet panel resizing when using permalinks to restore facets (#3718)
Closes #2891.
2021-03-15 09:00:50 +01:00
Antoine Beaubien
00b108865f
Added Refine.showLeftPanel() (#3716)
Added the Refine.showLeftPanel() function.
2021-03-13 11:01:20 +01:00
gitonthescene
50a905e9da
Property suggestion for data extension should try CORS first. 'suggest' key is optional in service manifest (#3710)
Co-authored-by: Douglas Mennella <douglas.mennella@gmail.com>
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-03-12 11:47:22 +01:00
gitonthescene
efca0bee2c
Make sure size of reconciliation preview pop-up is set before positioning it. fixes #3028 (#3706)
Co-authored-by: Douglas Mennella <douglas.mennella@gmail.com>
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-03-10 16:14:12 +01:00
Kush Trivedi
a07ca9d72d
feat: add tests for edit_column (#3704) 2021-03-10 10:58:42 +01:00
Akshita Singh
ad22c7709a
Add link to GREL reference in Help tab of expression editor (#3647)
* grel reference added

* descriptive link added

* modified

* translation text added

* conflict issue resolved and link added

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-02-24 14:37:47 +01:00
sarahelshabrawy
cf58dc4cdc
Enable hyperlinks in in-tool Help field (#3648) 2021-02-20 12:56:39 +01:00
Mo-hamdy2000
6c47c81e59
fix: Expression window resize (#3587)
* fix: Expression window resize

* fix: Expression window resize

* fix: Expression window resize

hard-coded value removed

* fix: Expression window resize

- adding column dialog fixed
- default width is preserved

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-02-20 11:36:06 +01:00
Kush Trivedi
0c5742771c
feat: add tests for rows-records mode (#3606)
Added tests for the view as row / view as record modes in the grid header
2021-02-18 11:16:34 +01:00
Akshita Singh
7bccdd1bcf
UI support for multiple hyperlinks in the same cell (#3597)
* fix for style ,hyperlink,tests added

* fixes #2519 hyperlink issue and added tests

* fixes #2519 ,span test,typo indent fixed
2021-02-11 19:54:36 +01:00
Antonin Delpeuch
a0bea8f8c7 Revert "Merge pull request #3588 from singhakshita/hyperlink-issue-tests"
This reverts commit 79aa260442, reversing
changes made to d6edf5ddb0.

See discussion at:
https://github.com/OpenRefine/OpenRefine/pull/3588
2021-02-07 09:21:26 +01:00
akshitasingh
d0802fa0ce tests for hyperlink 2021-02-05 22:41:29 +05:30
Kush Trivedi
f661201e9a
fix: add additional version translation (#3485)
Signed-off-by: Kush Trivedi <kushthedude@gmail.com>
2021-01-27 09:57:42 +01:00
Antoine Beaubien
8b978d1336
Fix editing preference with old value (#2769)
Fix the editing of a pref that proposed the oldest value of a preference, instead of the current value
2021-01-27 09:07:03 +01:00
allanaaa
d7cd7834a4
Updating codebase links (#3508)
* Updating codebase links

Changing obsolete links to the github wiki to the new docs.

* Open Help in new window
2021-01-22 08:51:47 +01:00
S-Harshit
7f18c66189
Broken counts in file selection dialog (#3495)
* Broken counts in file selection dialog. Closes #3460

* Update file-selection-panel.js
2021-01-19 09:11:31 +01:00
rachittiwari8562
c9ceb9ef47
fixes-issue-#3362 (#3375) 2021-01-13 19:48:18 +01:00
Cameron Bedard
c6b6616f01
Added confirm dialog for starred expression remove links #501 (#3436)
* Updated 'remove' link for starred expressions to include a confirm dialog

* bring remove expression dialog dismissal inline with other dialog dismissal

* Changed 'unstar expression?' in translation-en.json to allow better translation.

* Update main/webapp/modules/core/langs/translation-en.json

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-01-02 09:46:24 +01:00
rachittiwari8562
8740d1bcba
Fix UI of scatterplot-facet and dialog - fixes #3228 (#3338) 2020-11-28 20:16:23 -05:00
rachittiwari8562
b07b734359
Add labels to link radio buttons in reconciliation dialog, fixes #3293 (#3327) 2020-11-11 12:04:41 +01:00
Tom Morris
4359f894b8
Check for errors on Guess Types query - fixes #3173 (#3318)
Don't assume that the query always succeeds.
Error reporting is rudimentary (alert), but better than nothing.
2020-11-05 18:24:15 +01:00
Tom Morris
af1cf375f5
Add Java runtime name & version to About page - fixes #3240 (#3244)
* Visually center links box

* Add the Java runtime info to the About page - fixes #3240

- Add the Java runtime name & version GetVersionCommand
- Add the returned information to the About page
2020-10-02 09:41:37 +02:00
Chetan Verma
047d7c2de4
internationalised the label using $.i18n (#3104)
* internationalised the label using $.i18n

* fix some problem

* make it more clear and understandable

* change prefix 'core-buttons/ to 'core-import-formats'

* formateNames to formateLabelKey

* fix spelling mistake

* add translation-en.json in pc-axis

* remove from previous file

* Add internationalized activation

* improvement in pc-axis langs

Co-authored-by: chetan <you@example.com>
2020-10-01 11:31:29 +02:00
Jathin Sreenivas
7c0607b890
Fix #3163, dialog to add recon service submits when pressing Enter (#3183)
* Fix for issue #3163, Calling the okbutton.click() on press of enter

* Fix for issue #3163, using form and bind on submit.

* Fix for issue #3163, submit using jQuery's submit method
2020-09-11 20:13:34 +02:00
Gomaa
90d5debb8c
fix #2910: Recon service remove button also selects the service (#3168)
* FIx for issue #2910 : Service remove button click event propagates to underlying element

* Use stopImmediatePropagation function to fix the issue
2020-09-10 13:00:49 +02:00
Lisa Chandra
5ca5f3cb7b
Restructured the Facets (#3097)
* added class to List Facet

* added class to Timerange Facet

* added class to Range Facet

* added class to Text Filter Facet

* added class to Scatterplot Facet

* added base class

* added end line in facet.js

* fixed indentations facet.js

* fixed indentation again

* removed fields

* added suggested changes
2020-08-25 12:29:27 -04:00
Tom Morris
5eff85b76c
Update jQuery UI to 1.12 - fixes #3001 (#3010)
* Update jQuery UI from 1.10.3 to 1.12.1 and associated theme CSS

* Fix sidebar tab layout issue with new jQuery UI

* Update initialization jQuery UI Tabs widgets

selected is now active, but the first tab is selected by default
so we don't need to do it manually.

* Patch GData initialization error

Don't attempt to initialize if we get no docs back (ie unauthorized)
2020-08-17 14:49:56 +02:00
Tom Morris
6095c44cb7
Update to jQuery 1.12.4 and jQuery Migrate 1.4.1 - fixes 2932 (#2933)
* Refactor module wiring to reduce redundancy

* Update to jQuery 1.12.4 & jQuery Migrate 1.4.1 - fixes #2932

This updates to the latest jQuery 1.x and jQuery Migrate 1.x,
the first step in upgrading to a modern jQuery.

* Add a couple of bug fixes from Google Code SVN

This is an unrelease version from the Google Code freebase-site
repo which only has a few changes from the v4.3 release, but
one of them is removing the `browser.msie` reference that
jQuery Migrate is complaining about.

* Use prop() for 'checked' and 'disabled'

* Update jQuery 'value' property setting code to use val()

* Use prop() instead of attr() to set 'selected'

* Patch for jQuery >1.9
2020-08-06 13:47:31 +02:00
Tom Morris
05fb4e355f
Replace Javascript string concatenation with i18n parameters - addresses #1858 (#3019)
* Replace js string concatenation with i18n parameters

refs #1858
Remove Javascript string concatentation and use jquery i18n()
instead so that translators have the needed context and
flexibility to be able to do a good job. Also remove code-based
plurals conditionalization and replace with i18n.

* Update French translation so I can test non-English support

* Add missing localization

* Clean up formatting of service API link
2020-08-04 10:10:38 +02:00
Chetan Verma
04309dcfb4
Add improvement-message for vantage. (#3011)
Fixed self mistakes

modified line forVantage

Revert "modified line forVantage"

This reverts commit f252bde77cedf2f85fbfaf2059e551078ad62c2c.

modification in one anathor line

Co-authored-by: chetan <you@example.com>
2020-08-03 14:15:39 +02:00
Tom Morris
0ebd89c952
Clustering dialog choices limit & performance improvements - fixes #695 (#2996)
* Clustering dialog choices limit & performance improvements - fixes #695

Fixes #695
- Caps the total number of choices displayed at 10,000 and warns when
  over the limit. Users can use facets to tune which clusters are displayed.
- Doubles the performance of the Javascript processing
- Only displays count of rows for a choice if it's > 1 to DOM elements
- Adds internationalization for row count

For 41K clusters containing 118K choices, processing dropped from
3m20s to 1m20s, but with the 10K choice cap total time is ~10sec.

* Restore even/odd row class

* Updates from review feedback
2020-08-01 10:59:41 +02:00
Tom Morris
5985f95ce1
Explicitly set SameSite=Lax on cookie - fixes #3007 (#3014) 2020-08-01 10:58:16 +02:00
Lisa Chandra
1dcc83209c
Faster rendering of rows and cells (#2973)
* changes to rendering of rows

* some cell rendering improvements

* more render row improvements

* fixed jQuery methods on js elements

* added comment for nbsp
2020-07-28 18:25:32 +02:00
Chetan Verma
86ec7e6b40
Give the name to button 'Back' (#2989)
* Give the name to button 'Back'

* Using DOM to add name of button
2020-07-26 09:08:50 +02:00
Chetan Verma
602149db6e
Fix Import Project form to check for the presence of a file (#2979) 2020-07-25 09:45:45 +02:00
Urvashi Gupta
f00129b852
fixes service panel toggling (#2915) 2020-07-14 16:46:10 +02:00
Tom Morris
233cb95289
Ignore events which don't change text input - fixes #1134 (#2846)
* Ignore events which don't change text input - fixes #1134

* Fix bind
2020-07-14 08:35:46 +02:00