Commit Graph

648 Commits

Author SHA1 Message Date
Thad Guidry
af74c724d9
Merge pull request #2558 from OpenRefine/issue-2553
Implementation of #2553: Implementation of minimize facets
2020-04-17 17:31:33 -05:00
Antoine2711
aeb0464f73 New style for Maximize icon
New picture for Maximize icon, that is not a big box, but a smaller box wih arrows in the corners.
2020-04-17 17:59:20 -04:00
Antoine2711
7730f7048e Move li.facet-state-minimize in CSS and spacing in ListFacet
Move li.facet-state-minimize in CSS closer to other minimize stuff and remove uneeded spacing in ListFacet
2020-04-17 17:14:04 -04:00
Antoine2711
f4e6ab92fc Carry the modifications from ListFacet to all other facets
• Carry the modifications from ListFacet to all RangeFacet, ScatterPlotFacet, TestSearchFacet, TimeRangeFacet.
• Also, add the maximize action to the ToolTip.
• CleanUp of hierarchie of HTML or Facets.
2020-04-17 16:17:20 -04:00
Antoine2711
d26b72bede Use this._minimizeState instead of this._config.minimize
Use this._minimizeState instead of this._config.minimize to keep track of the minimized state of the facet
2020-04-17 04:39:41 -04:00
Antoine2711
ef0d49e679 Spacing adjustment
Changed a [TAB] for 2 [SPACE].
2020-04-16 14:07:18 -04:00
kovacskarolina
e3be53146f
Fixed to focus on find-field (#2545)
* Adding function to autofocus text input when dialog opens

* Fixing code according to suggestion.

* Simplifying code,  removing function

Co-authored-by: Kovács Karolina <kovacskarolina0904@gmail.com>
2020-04-16 19:05:40 +02:00
Antoine2711
f9c69bf80e First implementation of minimize facets
v1 de minimize facets.
2020-04-16 03:26:47 -04:00
Lisa Chandra
349e76c195
Fix: the wrong label for regex checkbox in split multi cell dialog (#2530) 2020-04-14 10:03:25 +02:00
james-cui
5c6386f5cb
Fix that columns named « toString » are displayed as collapsed (#2531)
Closes #2451
2020-04-10 07:39:24 +02:00
Albin Larsson
aac8359238
Set client timeout limit in chainGetJSON() (#2482)
By setting a client side timeout one can avoid net::ERR_NETWORK_IO_SUSPENDED errors caused by the OS network layer being suspended [1]. This allows the client to handle higher level errors.

The jQuery.getJSON() function does not have a parameter for timeouts.

[1]: https://cs.chromium.org/chromium/src/net/http/http_network_layer.cc?q=ERR_NETWORK_IO_SUSPENDED&sq=package:chromium&dr=C&l=42
2020-04-06 10:42:38 +02:00
chuhao zeng
1f0111eaed
Fix silent error in JSON/XML importers (#2414)
* Add error handler for parse error

* Add test for parsing json with incorrect strecture

* Enable localization from front-end

* Add methods to get localized error messages

* Update returned exception message

* Remove unused log and fix file diff issue

* Test auto build

* Refactor getOptions in newly created test

* Use new exception to unwrap original message

* Undo unexpected fix

* Remove unused lines

* Fix exception logic

* Fix typo
2020-03-27 09:41:49 +01:00
Agha Saad Fraz
cff88e6267
Added google sheet feature and moved features to the export drop-down (#2458)
* fixed minor typos

* Added google sheet feature and moved features to the export drop-down menu

* minor change

* removed redundant text and moved code and translations into their respective extensions
2020-03-23 11:14:02 +01:00
Lisa Chandra
ef8ad85c3c
Adds trim whitespace option to separator based files (#2408)
* added trim ui to csv importer

* added trim functionality

* trimStrings handler only for strings

* added test for trimStrings option in csv/tsv files

* made trim option enabled by default
2020-03-21 10:38:43 +00:00
Ekta Mishra
bf8af23493
Creates project from URL when press ENTER (#2444)
* Creates project from URL when press ENTER

solves #2437

* Added submit action
2020-03-20 22:35:40 +01:00
Ekta Mishra
7c08d774e5
Removed freebase-query-panel.html (#2434)
Freebase conciliation webserice is no longer availabe and no call is made to this file.
Hence, should be removed.
2020-03-18 13:45:45 +00:00
Albin Larsson
1bbf3df0f3
CustomTabularExporterDialog: fix checkbox options being ignored (#2429)
Any value (even an empty string) of the checked attribute will be threated as checked. Fixed by passing null to jQuerys attr function which removes the attribute.
https://stackoverflow.com/questions/4228658/what-values-for-checked-and-selected-are-false
2020-03-18 04:54:04 +00:00
Albin Larsson
4ba75034cb
Custom Tabular Exporter: add option to quote all strings #1869 (#2427) 2020-03-17 18:01:37 +00:00
Ekta Mishra
afd5cf70f0
Reconciliation UI: property not included if checkbox unchecked (#2413)
solves #2230
2020-03-15 13:49:14 +00:00
Lisa Chandra
fd2460914c
Fixes no selected record element error (#2407)
* fixes no record element error

* made relevant changes

* alert message from i18n instead

* removed the boolean variable
2020-03-14 14:36:54 +00:00
Ekta Mishra
6ec40bc478
Removed exportTrippleloader functions #2345 (#2399)
closes #2345
2020-03-12 13:03:26 +00:00
Ekta Mishra
fd12ea8c5d
Removed freebaseapps.com from scripts (#2395)
closes #1973
2020-03-12 10:57:42 +00:00
Lisa
b5282fcce7
corrected label for trim in xml parser ui (#2394) 2020-03-12 10:54:53 +00:00
Kush Trivedi
3fd3faca11
enh: URL checking for import web addresses (#2377)
* enh: URL checking for import web addresses

* Add the source for Regex

* Removing the console.log for production
2020-03-11 22:22:49 +00:00
Lisa
649ce93b3a
corrects wrong trim label for json importer config (#2385) 2020-03-11 09:41:16 +00:00
Hammad Aamer
e8f2a98cf0
Added feature to create column containing Q values (#2378)
* Added feature to create column containing Q values

* Defined better language for adding IDs column

* Fixed notations

* Add id column final fix

* Add id column final fix

Co-authored-by: Hammad Aamer <hammad.aamer97@gmail.com>
2020-03-11 09:34:49 +00:00
Kush Trivedi
fec414cb14
fix: List facets dialogue should be non editable (#2375) 2020-03-10 10:17:23 +00:00
Antonin Delpeuch
3d5a93d506
Merge pull request #2324 from kushthedude/timeout
enh: Text Filter waits until user finishes updating
2020-03-07 21:10:21 +00:00
kushthedude
3b2aa2ccd0 applying timeout variance only for regex 2020-03-07 01:56:36 +05:30
kushthedude
620d7672c9 Addresing requested changes 2020-03-06 15:35:44 +05:30
Antonin Delpeuch
7a3b3a9a7a Enforce uniform column widths in key-value columnize dialog 2020-03-04 09:43:42 +00:00
Alex
8816cd511a changes for #898:
* made "Columnize by Key/Value columns" dialog resizable
* set overflow styling, which solves the issue in Chromium-based browsers (Chrome, Edge, Opera) but doesn't work in FireFox and WebKit-based browsers (like Epiphany @ Linux, not tested in Safari but most likely won't work either)
2020-03-02 14:57:02 +02:00
Antonin Delpeuch
9356b846b6
Merge pull request #2339 from lisa761/modal-dialogs
Closes dialogs when escape key is pressed
2020-03-01 11:33:43 +00:00
Lisa Chandra
e563885de1 moved escapeKey handler to global scope (to prevent only said handler from executing when a dialog is closed) 2020-02-29 22:16:29 +05:30
Lisa Chandra
07149d4083 removed closing of dialog box on an outside click and moved escape key logic to dialog.js 2020-02-28 18:40:15 +05:30
Lisa Chandra
ad017434dc closes reorder/remove dialog when a click is made outside or when escape key is presses 2020-02-28 01:54:16 +05:30
kushthedude
89b63bb8f8 resetting schedule update to 500 2020-02-28 00:40:11 +05:30
kushthedude
f96cb0e01f enh: Text Filter waits until user finishes updating
Signed-off-by: kushthedude <kushthedude@gmail.com>
2020-02-28 00:37:45 +05:30
Antonin Delpeuch
55e77f4066
Merge pull request #2325 from kushthedude/exp
fix: cannot export a file if blank tab opened is not closed
2020-02-27 10:27:07 -08:00
Lisa Chandra
e3f125dd9f closes reconcilation dialog when a click is made outsid the dialog box or when escape key is pressed 2020-02-27 22:35:20 +05:30
Lisa Chandra
512aac8143 closes sql exporter dialog box when a click is made outside the dialog box or when escape key is pressed 2020-02-27 22:18:38 +05:30
Lisa Chandra
2de7015645 closes templating export dialog when a click is made outside the dialog box or when escape key is pressed 2020-02-27 21:42:11 +05:30
Lisa Chandra
7e86197339 closes custom export tab when a click is made outside the tab or when escape key is pressed 2020-02-27 21:26:07 +05:30
Lisa Chandra
91058de64f closes cluster dialog when a click is made outside the dialog box and when escape key is pressed 2020-02-27 18:59:16 +05:30
Thad Guidry
9a1d6a341a fix typo 2020-02-26 07:55:35 -06:00
Thad Guidry
4baba6b125
fix typo 2020-02-26 07:44:44 -06:00
kushthedude
f56dc3e012 fix: cannot export a file if blank tab opened is not closed
Signed-off-by: kushthedude <kushthedude@gmail.com>
2020-02-23 21:55:37 +05:30
Antonin Delpeuch
5894041943
Merge pull request #2296 from jamessspanggg/add-filldown-blankdown-for-all
[#2280] Add fill down and blank down operations for all columns
2020-01-27 10:24:08 +01:00
jamessspanggg
a19f859d2e Reverse order of fill down operation 2020-01-27 17:14:57 +08:00
Antonin Delpeuch
fe147328f3
Merge pull request #2297 from jamessspanggg/2220-blank-per-column
[#2220] Add facet for blank values/records per column
2020-01-24 10:16:04 +01:00
jamessspanggg
d7d4731f80 Utilise callbacks to chain fill/blank down operations 2020-01-21 01:56:03 +08:00
jamessspanggg
df76cb93b7 Fix error in calculation of blank records per column 2020-01-21 01:28:19 +08:00
jamessspanggg
8d3911556a Add facet for blank values/records per column 2020-01-21 00:02:48 +08:00
jamessspanggg
73936183bb Refactor to individual functions 2020-01-20 23:20:14 +08:00
jamessspanggg
90628e6ab0 Add fill down and blank down operations for all columns 2020-01-20 22:21:37 +08:00
jamessspanggg
fc97b3f188 Fix mistake of translating wrong word 2020-01-08 08:31:51 +08:00
jamessspanggg
c2d72c6236 Translate sort link using i18n 2020-01-07 11:42:59 +08:00
Antonin Delpeuch
a4c4a20767 Fix Google Sheets and Google Drive export 2020-01-04 15:56:24 +01:00
Antonin Delpeuch
2e1d5402ea Add CORS support with JSONP fallback. Closes #2260 2019-12-24 10:38:12 +01:00
Antonin Delpeuch
ad261109be Fetch default recon service in background silently. Fixes #1665 2019-12-24 09:07:23 +01:00
Antonin Delpeuch
11c7788239 Fix CSRF token addition on import project form 2019-11-04 20:04:16 +00:00
Antonin Delpeuch
aa228c43b2 Fix frontend for extensions for CSRF protections 2019-10-17 11:44:57 +01:00
Antonin Delpeuch
1ee5068f0d CSRF protection for Wikidata extension 2019-10-17 10:42:05 +01:00
Antonin Delpeuch
9ae6a7a581 Tie up CSRF tokens in the frontend 2019-10-15 12:07:14 +01:00
Antonin Delpeuch
5dc005749a Add CSRF protection to remaining commands 2019-10-15 12:07:13 +01:00
Antonin Delpeuch
3559eeb11f CSRF protection for project and recon commands 2019-10-15 12:07:12 +01:00
Antonin Delpeuch
a340c137d0 CSRF protection for OpenWorkspaceDirCommand and language loading 2019-10-15 12:07:04 +01:00
Antonin Delpeuch
f7177e670d Adapt frontend for CSRF in import dialog 2019-10-15 12:04:17 +01:00
Antonin Delpeuch
91cead27f8 CSRF protection for ImportingController 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
70e37b9085 Add CSRF protection to cell, history, column and expr commands 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
51ddd27909 Require CSRF token in EditOneCellCommand 2019-10-14 16:24:26 +01:00
Michael
695ef94b50 #1970 Disable spell check for expressions. 2019-10-12 16:51:04 +02:00
Antonin Delpeuch
1c2ac45dee
Merge pull request #2169 from fsteeg/2168-suggest
Set suggestOptions.type to the selected reconciliation type
2019-10-10 17:10:43 +01:00
Fabian Steeg
84af07506d Prefer view.url pattern for data extension preview links
See https://github.com/OpenRefine/OpenRefine/issues/2177
2019-10-04 14:55:34 +02:00
Fabian Steeg
cf578cf641 Set suggestOptions.type to the selected reconciliation type
Remove Freebase-specific option and default value

See https://github.com/OpenRefine/OpenRefine/issues/2168
2019-09-23 12:22:13 +02:00
Antonin Delpeuch
c078c3a81d Fix change of language. Closes #2158. 2019-09-12 11:53:21 +01:00
Katrin Leinweber
8a3cc41acb Reset history-panel to 4a8d8afb
The changes in abe4137a do not translate here. Maybe because history-panel-filter is loaded in the background in the "Undo / Redo" tab?
2019-08-31 06:59:43 +02:00
Katrin Leinweber
abe4137ae5 Speed up input of separator characters (fix #2130) 2019-08-31 06:50:34 +02:00
Katrin Leinweber
200d11cbef Search autofocus element in DOM, instead of defining function 2019-08-28 19:59:59 +02:00
Katrin Leinweber
609a639129 Move focussing code to proper .js file 2019-08-28 19:35:33 +02:00
Katrin Leinweber
439f34171c Fix typo in input field id 2019-08-28 19:26:28 +02:00
Katrin Leinweber
90af379d5f Partially revert "Use JavaScript-based focussing, rathrer than"
This partially reverts commit 870a1b20a1.
2019-08-28 19:21:10 +02:00
Katrin Leinweber
870a1b20a1 Use JavaScript-based focussing, rathrer than
Reverts feb4ec3
2019-08-26 15:12:51 +02:00
Katrin Leinweber
feb4ec31a9 Auto-focus input fields into which users likely type immediately 2019-08-26 11:30:11 +02:00
Mathieu Saby
f0616eff79 Remove all columns at once and escape input 2019-08-09 02:03:58 +02:00
Mathieu Saby
7836e5b2db Fix grammar and use callbacks 2019-08-07 23:20:28 +02:00
Mathieu Saby
27d5fb88fa Init commit 2019-08-04 15:32:36 +02:00
Thad Guidry
94fa0c2189 remove mention of recon on help 2019-07-23 22:36:32 -05:00
Thad Guidry
afce62fcd3
[WIP] Add recon and record to Help tab 2019-07-20 14:52:21 -05:00
Michael
3cac19e089 Add a unique id to text filter facet checkboxes and labels. 2019-07-11 23:09:52 +02:00
Antonin Delpeuch
4f43515ec9 Fix project metadata UI 2019-06-06 17:15:25 +01:00
Daniel Sader
d21ca26b2f Added Select All/Select None buttons to Excel importer 2019-04-01 14:53:50 -03:00
Felix Lohmeier
2c266d3f20 renamed new facets in menu All 2019-03-11 20:33:51 +01:00
Felix Lohmeier
9c55c7e121 fix facet by blank (switched true/false) 2019-03-08 20:51:14 +01:00
Felix Lohmeier
2db567ab0f added facet "Count non-blank records/column" to menu All 2019-03-08 20:26:18 +01:00
Felix Lohmeier
229b049f23 added facet "Count non-blank values/column" to menu All 2019-03-08 20:25:38 +01:00
Felix Lohmeier
4bdc0b6fb3 added facet by blank to menu All 2019-03-08 20:22:36 +01:00
Antonin Delpeuch
79394b9c0e
Merge pull request #1959 from OpenRefine/issue1943
Show reconciliation previews on hover of reconciliation candidates
2019-02-27 10:57:18 +00:00
Antonin Delpeuch
7f6831523e
Merge pull request #1969 from OpenRefine/revert-1888-fix-reconcile-facets
Revert "Fix Reconcile facets affected by change to list facet boolean handling"
2019-02-27 10:33:21 +00:00
Antonin Delpeuch
5dcd4a2f38 Add cell-ui.previewMatchCells=false preference to disable hover 2019-02-27 10:32:57 +00:00