Commit Graph

395 Commits

Author SHA1 Message Date
Iain Sproat
6409f1531c Re-adding guessValueType feature which was mistakenly removed in r797.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@873 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-27 21:18:27 +00:00
David Huynh
f9a0c51285 Added stemmed=1 to relevance calls.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@870 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-27 18:40:18 +00:00
David Huynh
bf1fb5ebcd Schema skeleton dialog preview was broken by some previous checkin.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@866 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-27 05:06:47 +00:00
Iain Sproat
34cb1c4d07 XmlImporter is partially unit tested. One broken test for case where Record Elements contain varying numbers of nested elements. (This is for Issue 61 which is, at the time of this commit, an open issue)
XmlImportUtilities produces log for case when no RecordElementCandidate are found.  (too few similar Xml elements).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@862 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-26 19:22:38 +00:00
Iain Sproat
1c47ff476b Refactor of CreateProjectCommand.java and Importers
The code for determining if an importer is suitable to import a file is now in each respective importer rather than in CreateProjectCommand.  There is an additional method, canImportData, on the Importer interface to support this.

CreateProjectCommand registers Importers from a Hashtable (this is a copy of Tom's code for registering commands in Gridworks Servlet).  Plugging in new importers should be simpler.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@861 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-26 13:18:48 +00:00
David Huynh
017a825600 Initial implementation of a templating exporter.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@860 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-26 05:42:31 +00:00
Iain Sproat
76cb65bfb8 Removed unnecessary files following refactor of TsvExporter and TsvCsvImporter.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@859 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-25 16:50:44 +00:00
Iain Sproat
2f3980f969 CsvExporter allows the separator character in its output to be modified.
ExportRowsCommand has replaced TsvExporter with CsvExporter with a tab character as the separator.
TsvExporterTests now tests CsvExporter with a tab character as the separator parameter.  All unit tests now work.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@858 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-25 16:39:25 +00:00
Iain Sproat
6779707399 CsvExporter uses columnIndex when accessing cells. Feature added to omit column header from first line of exported CSV. CsvExporterTests tests for this new feature.
The same unit test is available in TsvExporterTests.  Test is broken, and marked as such.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@857 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-25 16:00:03 +00:00
David Huynh
ffd6e265a9 Fixed issue 49: Add Edit Cells / Set Null.
Added support for "null" literal.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@855 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 23:49:18 +00:00
David Huynh
638eb4ac24 Added mqlwrite exporter.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@854 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 23:36:42 +00:00
David Huynh
d7f7d50e16 Fixed Issue 14: Limiting Freebase load to starred records
git-svn-id: http://google-refine.googlecode.com/svn/trunk@853 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 23:01:34 +00:00
Iain Sproat
3ac3feb01f opencsv-2.2.jar patched so that CsvWriter only selectively applies quotation marks around values when escape, line break, nested quotation marks or separator characters are encountered. Patch submitted to opencsv project as https://sourceforge.net/tracker/?func=detail&aid=3006635&group_id=148905&atid=773543
CsvExporter makes use of patched opencsv-2.2.jar. Quotation marks are only applied selectively.

CsvExporterTests fixed to correctly assign cellIndex when creating columns.

TsvExporterTests fixed to correctly assign cellIndex when creating columns.  Two broken tests now work.  Three tests are still marked as broken.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@851 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 22:01:37 +00:00
David Huynh
c6827fe242 Fixed issue 58: Meta facet
git-svn-id: http://google-refine.googlecode.com/svn/trunk@848 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 19:04:55 +00:00
Iain Sproat
433a047fb6 Added tests for TsvExporter - all are broken (may be the tests themselves, as they are copied from CsvExporterTests).
CsvExporter now closes writer.  CsvExporterTests includes test for a string with a comma.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@847 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 18:37:52 +00:00
David Huynh
38d5b3dbde Small refactoring: introduced RowEvaluable interface to abstract out the evaluation of an expression on a row.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@846 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 17:14:54 +00:00
Iain Sproat
015b5a92ae CsvExporter is linked to the UI, and should fully work. Unit Tests now assert that null cells can be handled by CsvExporter. CHANGES.txt is now updated to reflect Issue 59.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@845 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 12:36:35 +00:00
Iain Sproat
53e20da8f4 Issue 59 (part) - added CsvExporter and unit test to server side code. Not linked to UI.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@844 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 12:15:45 +00:00
David Huynh
23c02b870a Implemented "reorder rows" feature.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@840 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-22 01:39:27 +00:00
David Huynh
bfc7ef7739 Re-organized operations.* classes into sub-packages.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@839 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 18:15:13 +00:00
David Huynh
4e6b915bc1 When sorting, it's now possible to specify where to put blanks and errors relative to the valid values.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@837 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 04:46:36 +00:00
David Huynh
80a199b4a9 Started to hook up sorting. You can sort on one column right now but there's no indicator after you've done sorting.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@835 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 00:48:36 +00:00
David Huynh
496823e564 Added start() and end() methods to RowVisitor and RecordVisitor so visitors can do things before and after all visitations.
Added sorting package. It's not hooked up, yet.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@834 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 22:10:34 +00:00
David Huynh
0709ec3f92 Fixed issue 46: Array literals in GEL
git-svn-id: http://google-refine.googlecode.com/svn/trunk@833 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 17:49:20 +00:00
David Huynh
e1feec436a Made data table view render "rows" or "records" depending on the mode.
Got rid of "show dependent rows" and replaced it with 2 radio buttons for the 2 modes: row-based vs. record-based.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@831 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 05:49:13 +00:00
David Huynh
ef2079d0d8 Re-organization of classes in the browsing.* packages.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@825 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 00:33:13 +00:00
David Huynh
28ca652dea More row/record model refactoring work. Everything should still be working almost as before, except contextual rows are not shown in row-based mode.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@823 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 00:13:19 +00:00
Iain Sproat
ec7ac81246 Applying Tom Morris's patch to GridworksServlet.(issue #48). GridworksServlet creates classes from a string, so is no longer dependent on (imports) any of the Command Classes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@821 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-19 07:09:40 +00:00
David Huynh
1e737e3238 Factored row dependency code from Row class and Project class out as Record and RecordModel classes.
Simplified RdfTripleImporter.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@820 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-19 04:22:45 +00:00
David Huynh
e1861eb1d9 Let the RdfTripleImporter handle .rdf and application/rdf+xml files.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@819 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 21:28:31 +00:00
Iain Sproat
0e4682f453 RdfTripleImporter handles row dependencies.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@818 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 21:08:37 +00:00
Iain Sproat
cfd0f2219e RdfTripleImporter does basic reconciliation on Rdf subject - data model is no longer sparse (now possible to have more than one data point per row)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@816 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 13:48:52 +00:00
Iain Sproat
043f46c562 RdfTripleImporter correctly adds empty cells to existing rows when a column is added.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@815 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 13:04:51 +00:00
Iain Sproat
25d3a9dfc1 Added a basic RDF triple importer plus unit tests. Some more work required - it's not plugged into the client and it creates a very sparse data structure (each triple is a new row). It uses JRDF library (Apache 1.1 license).
git-svn-id: http://google-refine.googlecode.com/svn/trunk@813 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 12:41:40 +00:00
David Huynh
ee82ec2642 Issue 45: "Renaming Cells with Ctrl-Enter produced ERROR"
Tentative fix by sprinkling in "synchronized".


git-svn-id: http://google-refine.googlecode.com/svn/trunk@809 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 00:02:58 +00:00
Stefano Mazzocchi
6c9ef24336 lower verbosity of scatterplot generation
git-svn-id: http://google-refine.googlecode.com/svn/trunk@808 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 23:59:56 +00:00
David Huynh
0c70d281c7 Issue 28: mql-like preview is not properly unquoting numbers.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@807 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 23:47:09 +00:00
David Huynh
fa2be33709 Fixed issue 16: Column name collision when adding data from Freebase.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@804 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 21:33:46 +00:00
David Huynh
4cf476630e Fixed issue 15: Ability to rename projects - added rename command in both index.html and project.html (main menu bar)
Updated CHANGES.txt with other fixes committed previously.
Made sure releases.js doesn't hold up the initialization code of project.html.
Some polishing on the rendering of projects' last modified dates in index.html.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@799 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 19:22:58 +00:00
Iain Sproat
092d4602b9 TsvCsvImporter passes all unit tests. TsvCsvImporter again uses opencsv library.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@797 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 11:57:26 +00:00
Iain Sproat
03b1ab01f4 RowParser is no longer a parameter of read method in TsvCsvImporter (now handled in the method itself)
CSVRowParserTests is now tidied - with expected and actual being input into the correct parameters of Assert.assertEquals.  One more test passes, but still 2 tests failing.


git-svn-id: http://google-refine.googlecode.com/svn/trunk@792 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 06:24:58 +00:00
David Huynh
bd8d214a49 Resolved issue 19 for TSV as well, not just for CSV.
Touched up TsvCsvImporterTests to leave the comma vs. tab guessing to the importer itself. All tests still pass.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@790 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:55:02 +00:00
Iain Sproat
6f74bcaa26 comments tidied in TsvCsvImporterTests and ImporterUtilities
git-svn-id: http://google-refine.googlecode.com/svn/trunk@789 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:40:46 +00:00
David Huynh
68fbd3320b Got disabled tests in Issue 41 to pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@788 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:26:29 +00:00
Iain Sproat
22fb3a1585 fixing issue introduced in r782. - importer now autodetects separator correctly.
Uses original CSV parser, but 4no tests do not pass (ignored with enabled=false flag).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@787 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 03:22:22 +00:00
David Huynh
4cbd5a3b49 More re-organization of commands.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@786 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 02:33:01 +00:00
David Huynh
590358ca63 More new commands.* packages for better organization of commands. More re-organization of commands.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@785 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 02:24:45 +00:00
David Huynh
7d6a3cbe87 More new commands.* packages for better organization of commands. Some re-organization of commands.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@784 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 02:01:08 +00:00
Stefano Mazzocchi
f28e23e503 Committing patches by Iain:
- use OpenCSV parser instead of our own
 - use TestNG instead of JUnit which is a lot more configurable in test selection (and allows us to do a much better job a leaving the tree green even while developing tests that are known to fail)
 - integrated TestNG in './gridworks test'
 - added Iain to the list of contributors in README.txt
 - changed the Eclipse test launch file to use the TestNG launcher (unfortunately, this is not shipped by default in Eclipse, so you have to install it yourself from the http://beust.com/eclipse update file, I'll add this to the wiki shortly)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@782 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-16 18:42:52 +00:00
David Huynh
6450921c02 Fixed issue 4: Match All bug with ZIP code.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@767 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 17:03:33 +00:00