Commit Graph

740 Commits

Author SHA1 Message Date
Tom Morris
2872ceeb7a
Merge pull request #3349 from thadguidry/fingerprint-wynn-thadguidry
Add Wynn to fingerprint to support Old English texts
2020-11-28 22:08:00 -05:00
Thad Guidry
3d30897b3b Add Wynn to fingerprint to support Old English texts 2020-11-28 21:40:49 -05:00
Florian Giroud
7950d764ff
Architecture for front end browser-based UI tests, issue #733 (#3340)
* Added Cypress tests to OpenRefine
* Installed Cypress
* Added a few tests to cover basic OR features
Y

* Enriched langage Tests

* Enriched project_create tests

* Refactored and enriched undo/redo tests, added extract & apply

* Upgraded Cypress to 5.6.0

* Removed the cypress-dot-env plugin, as Cypress now supports nice configuration capabilities

* Added UX tests documentation

* Improved functional tests documentation, added license and description to tests package.json
2020-11-23 18:18:12 +01:00
rachittiwari8562
990540ce10
Fix #3330: argument checking in phonetic GREL function (#3345)
* Fix for issue #3330 phonetic-function

* Update main/src/com/google/refine/expr/functions/strings/Phonetic.java

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>

* Corrected Intendation

Corrected intendation as suggested.

* Added tests to check invalid parameters

* Added tests to check invalid parameters

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2020-11-22 09:23:06 +01:00
Thad Guidry
6c9ad3f31d
Improve documentation of reinterpret GREL function (#3315)
* add clarity for reinterpret docs

Helps fix #3292

* update reinterpret docs phrasing

We agreed to use "encoding" to be friendly to user exposed messaging instead of "encoder" and "decoder" that is used internally.

* fix serializeReinterpret() test json
2020-11-05 07:57:12 +01:00
rubyAnne
352127558a
changed to reflect the function's acceptance of either simple string … (#3294)
* changed to reflect the function's acceptance of either simple string or regex

* cast p into a Pattern

* cast p into a Pattern

* Changed test to reflect the new output from function.
2020-11-01 08:52:36 +01:00
Tom Morris
c8220d687e
Improve fingerprint keyers - fixes #3282 (#3283)
* Add more keyer tests

- All forms of Unicode whitespace for both fingerprint & N-gram fingerprint
- additional N-gram fingerprint cases

* Improve fingerprint keyers

- Update N-gram fingerprint keyer to match (missed last time)
- refactor string normalization to reduce redundancy between two keyers
- add C1 controls to control characters that are stripped
- include all Unicode whitespace characters in splitting delimiter
  and don't strip controls which are whitespace (HT, LF, VT, FF, CR,
NEL)
- minor cleanups, simplifications, and performance optimizations
2020-10-25 20:32:30 +01:00
Tom Morris
30d16c2077 Add Thad/Owen's test 2020-09-30 20:57:57 -04:00
Tom Morris
dbb8e530c8 Add tests for array reverse & join 2020-09-30 20:24:05 -04:00
Tom Morris
d6e42bf5d9 Annotate another missed test 2020-09-30 20:00:08 -04:00
Tom Morris
959200d141 Maintain order for uniques() - fixes #3235
Also add tests
2020-09-30 17:45:24 -04:00
Tom Morris
bb4fc50f17 Enable missed test 2020-09-30 17:44:05 -04:00
Tom Morris
c76e2b9a46
disable flaky readTableWithLinks test - refs #3128 (#3207) 2020-09-23 07:41:22 +02:00
Thad Guidry
3f6d1eabba
Adds new Jsoup wholeText() function and tests (#3181)
* Adds new Jsoup wholeText() function and tests
- Ref: https://github.com/jhy/jsoup/blob/master/CHANGES#L275
- Ref: https://jsoup.org/apidocs/org/jsoup/nodes/Element.html#wholeText()

* update the description of function

* Update main/src/com/google/refine/expr/functions/xml/WholeText.java
2020-09-12 16:14:26 +02:00
Tom Morris
eaf881ced7
Importer refactoring cleanup (#2984)
* Clean up importer refactoring

Remove an extra copy of filename setting.
Revert some additional API changes (retaining both versions)

* Revert archive file name changes & mark as deprecated
2020-09-06 17:46:08 -04:00
Tom Morris
a86a6d4e3b
sort() handles nulls instead of throwing NPE - fixes #3152 (#3162)
* Add utility helpers to create array of comparable items

* Extend sort() to handle arrays with nulls

- Instead of NullPointerException on nulls, sort them last
- add JSON helpers to return Comparable[] in addition to Object[]
- Non-homogenous arrays or arrays with non-primitive
  objects (array or object) are not sortable
- Add tests for both new and old sort functionality
2020-09-05 23:01:47 +02:00
Tom Morris
aa43445c99
Extend forEach() to support JSON objects (#3150)
* Refactor GREL Get tests

- move helper up to RefineTest
- move tests to the correct module

* Extend forEach() to support JSON objects - fixes #3149

Also add tests for existing forEach forms in addition to the new one

* Add a couple more tests
2020-08-30 08:40:17 +02:00
Tom Morris
441c069bc5 Add some string function tests
Including a test for Apache TEXT-149 behavior change
https://github.com/apache/commons-text/pull/119

Add some more string function tests
2020-08-23 14:17:40 -04:00
Tom Morris
b5aea3b780 Remove unused imports 2020-08-23 14:17:40 -04:00
Tom Morris
a50669800f Split up multifunction test modules
Distributes the tests to individual modules per function and
deletes the former multifunction test modules.
2020-08-23 14:11:49 -04:00
Tom Morris
392a64b25e Refactor tests to hoist common methods into RefineTest
Moves the invoke() method and the associated fields into
the super class and deletes the redundant implementations.
2020-08-23 14:11:49 -04:00
Antonin Delpeuch
9ac54edbba
Migrate reconciliation calls to Apache HTTP client (#2906)
* Migrate reconciliation calls to OkHTTP, for #2903

* Migrate to Apache HTTP Commons

* Migrate data extension to Apache HTTP client

* Deprecate HttpURLConnection in RefineServlet

* Use LaxRedirectStrategy, clean up imports

* Remove read and pool timeouts, only keep the connection timeout

* Adapt mocking of HTTP calls after migration
2020-08-23 14:04:59 +02:00
Tom Morris
259705ad5f
assertEqualAsJson test helper refactor (#3113)
* Refactor test helper

Create a version of the assert that uses the standard parameter
order and deprecate the version that uses inverted order.

* Use consistent Assert class and parameter ordering
2020-08-23 11:04:44 +02:00
Tom Morris
fc21d58ed1
Don't count TABs as control characters - fixes #3061 (#3068)
* Don't count TABs as control characters - fixes #3061

* Add TSV test. Replace info logging w/assert message
2020-08-16 10:35:25 +02:00
Tom Morris
b73b480d7d
Remove tests of third party code (#3050)
Neither of these tests are testing OpenRefine code
(and a negative NotEquals test is useless anyway)
2020-08-10 12:39:30 +02:00
Tom Morris
55edae2b7b
Fix ToDate test failure & inefficiency - fixes #3026 (#3027)
* Fix ToDate test failure - fixes #3026

Instead of computing offset from UTC at current
point in time, use the offset from the parsed
date so that we're not affected by crossing
a daylight savings time boundary.

* Fix date parsing with locale as first format string

Also refactors for simpicity, restore some dropped tests,
and restores previous behavior of considering a bad
format string an error instead of silently ignoring it.

It does NOT address another issue which was introduced
in May 2018 of treating date/times without timzone
information as UTC instead of local.

* Restore error checking and messages

* Save & restore default timezone for tests

Also add some ToDos for places where LocalDate is being misused.
2020-08-09 13:53:43 +02:00
Tom Morris
a0819acbd6 Move ProjectManager initialization to beforeMethod 2020-08-03 20:42:31 -04:00
Tom Morris
52194e1685 Add https for all TestNG DTDs 2020-08-03 12:27:58 -04:00
Tom Morris
83ed9ffdaf
Refactor importer APIs - Fixes #2963 (#2978)
* Make sure data directory is directory, not a file

* Add a test for zip archive import

Also tests the saving of the archive file name and source filename

* Add TODOs - no functional changes

* Cosmetic cleanups

* Revert importer API changes for archive file name parameter

Fixes #2963
- restore binary compatibility to the API
- hoist the handling of both fileSource and archiveFileName from
TabularImportingParserBase and TreeImportingParserBase to
ImportingParserBase so that there's only one copy. These 3 classes are
all part of the internal implementation, so there should be no
compatibility issue.

* Revert weird flow of control for import options metadata

This reverts the very convoluted control flow that was introduced
when adding the input options to the project metadata. Instead
the metadata is all handled in the importer framework rather than
having to change APIs are have individual importers worry about
it.

The feature never had test coverage, so that is still to be added.

* Add test for import options in project metadata & fix bug

Fixes bug where same options object was being reused and overwritten,
so all copies in the list ended up the same.
2020-07-23 18:36:14 +02:00
Tom Morris
d5abaac6df
Update marc4j to 2.9.1 - Fixes #2962 (#2977)
* Add a MARC import test

* Make sure data directory is directory, not a file

* Update to marc4j 2.9.1 - fixes #2962
2020-07-22 22:12:30 +02:00
Tom Morris
f2e61b6628
Add tests for wide XLS/XLSX export (#2945)
Refs #2122. Also reenable a couple of disabled tests
2020-07-16 10:01:17 +02:00
Tom Morris
a3fab26cca
Fix the text format guesser so it doesn't inappropriately guess WikiText (#2924)
* Fix text guesser so it doesn't guess wikitext

Fixes #2850
- Add simple magic detector for zip & gzip files to keep
  it from attempting to guess binary files
- Add a counter for C0 controls for the same reason
- Tighten wikitable counters to require marker at
  beginning of the line, per the specification
- Refactor to use Apache Commons instead of private
  counting methods
- Add tests for most TextGuesser formats

* Remove misplaced duplicate test data file

* Fix LGTM warning + minor cleanups

* Use BoundedInputStream to prevent runaway lines
2020-07-15 08:56:00 +02:00
Tom Morris
561619399c
Fix order dependent NPE in LoadLanguage test (#2922)
* Ensure ProjectManager is initialized before test - fixes #2895

* Fix indentation (detabify)
2020-07-14 18:06:04 +02:00
Tom Morris
ed68541988
Remove informational logging from tests that are passing (#2923)
* Change logging from info to debug

* Make tests less chatty when they're passing
2020-07-14 17:47:36 +02:00
Tom Morris
306b541c69
Fix Excel date import - Fixes #1908 (#2909)
* Add utility functions to check/convert dates

* Add date tests and refactor to DRY up

* Fix date import - fixes #1908

Change from java.util.Date to OpenRefine 3.0+'s OffsetDateTime
Fixes #1908

* Centralize date conversion

* Moving utility methods to ParsingUtilities

* Fix tests
2020-07-09 23:13:44 +02:00
Tom Morris
0562638ffa
Use standard text normalization - fixes #2898 (#2900)
* Use standard text normalization - fixes #2898

Fixes #2898. Fixes #409. Refs #650

Replaces homegrown ISO Latin-1 only character subsitition
with standard Java Normalize to NFD, followed by diacritic
removal and a few custom character expansions/replacements.

* Fix Mac build

* Improve compatibility with previous code

One intentional change is folding O with stroke to
oe instead of o.

- Use more powerful NFKD instead of NFD
- strip punctuation after decomposition since it can generate
  new punctuation
- Add compatibility test for old asciify() method
- Add some graphically similar characters to substitution table

* Add oe character/ligature & more long S forms

* More tests for ligatures and Latin Extended

* Add Latin-1 Supplement tests
2020-07-07 21:35:41 +02:00
Urvashi Gupta
f62f63706c
Report HTTP error codes to the user when creating a project from a URL (#2870)
* HTTP Error

* urlImportingTestCompleted
2020-07-07 11:58:47 +02:00
Tom Morris
e61d50a1aa
Fix NGramFingerprintKeyer to ignore accents - fixes #1161 (#2899)
Fixes #1161
This change parallels what was done in #1257 1da3c00 to fix
the FingerprintKeyer and moves the diacritic removal before
the deduping. Includes a test.
2020-07-07 09:02:49 +02:00
Tom Morris
3717111db8
Fix Open Office Spreadsheet (ODS) dates (#2843)
* Truncate any completely empty columns on the right

Fixes #565
The current versions of Open Office create default spreadsheets
with over 1000 empty columns. Keep track of the rightmost
non-empty column when importing and truncate everything else.

Also adds a basic ODS import test.

* Fix dates in ODS spreadsheets

Fixes #2224
2020-07-04 08:42:33 +02:00
Antonin Delpeuch
f4692de9e1 Increase maximum wait for testInvalidUrl, follow-up for #2876 #2875 2020-07-03 21:48:43 +02:00
Tom Morris
5d6af9cb6c
Merge pull request #2865 from tfmorris/2863-tree-column-ordering
Remove shortest-column-name ordering - fixes #2863
2020-07-03 15:23:36 -04:00
Tom Morris
f5786afa35
Increase test timeout - fixes #2875 (#2876) 2020-07-03 21:20:01 +02:00
Tom Morris
d3db73aa67 Remove shortest-column-name ordering
Refs #2863
The tree importer sorts columns/column groups by how populated
they are, which is of arguable utility, but the tie-breaker
of ordering by shortest column name is completely silly.

This change removes that and, in conjunction with a stable sort
algorithm, will preserve the original order of the columns.
2020-07-02 16:12:55 -04:00
Tom Morris
28a9f68236
Unit test improvements (#2856)
* Fix two deprecated methods usages

* Test ToNumber conversions

* Test behavior of all functions when passed 0 or 8 arguments

There are 16 which fail currently on 0 args (return null or
False instead of EvalError), but have been whitelisted until
we can verify whether it's safe to change them without introducing
compatibility issues.

There are 19 which fail to return an error on too many (ie 8) args.
2020-07-02 20:29:21 +02:00
Tom Morris
0f3a6006f3
Add Excel95 import test and improve other importer tests (#2844)
No issue.
- we don't support Excel95, but make sure that it generates an exception
- move the test data file into the appropriate directory
- for any normal test, consider exceptions a failure
2020-06-30 08:20:56 +02:00
Tom Morris
421974cc3d
Truncate any completely empty columns on the right (#2842)
Fixes #565
The current versions of Open Office create default spreadsheets
with over 1000 empty columns. Keep track of the rightmost
non-empty column when importing and truncate everything else.

Also adds a basic ODS import test.
2020-06-30 08:19:00 +02:00
Tom Morris
83f52d4ba5
Fall back to Apache Jena 3.9.0 (from 3.15.0) (#2826)
Fixes #2824
Versions up through 3.14.0 appear to work, but since odfdom bundles
Jena 3.9.0, we're going to be conservative and match that.

As an added bonus, includes a blank node test which will trigger
the failure.
2020-06-27 23:40:21 +02:00
Tom Morris
4b146acc6e
Create Project import improvements (#2806)
* Fix charset encoding & MIME type handling

Character set (ie what we call "encoding") is part of the Content-Type,
*not* the Content-Encoding, which specifies compression (e.g. gzip).

This correctly sets the character set encoding as well as cleaning
the MIME type so that additional parsing doesn't need to be done
downstream (and removes that code).

* Use "text" instead of "text/line-based" as default fallback format

The TextLineBasedGuesser only tries a limited number of
formats (CSV, TSV, fixed), so we can't get out of that hole to
find JSON, XML, etc.

Start with a more general format instead to improve our
guessing odds.

* Support content type Structured Name Syntax Suffixes (+json +xml)

If we can't find a fully specified content type in our lookup,
fall back to just the suffix (which is registered with a leading +)
Fixes #2800 Fixes #2805
2020-06-25 08:36:57 +02:00
Tom Morris
1849e62234
Better error handling for reconciliation process - fixes #2590 (#2671)
* Harden reconciliation - Fixes #2590

- check for non-JSON / unparseable JSON returns
- handle malformed results response with no name for candidates
- catch any Exception, not just IOExceptions
- call processManager.onFailedProcess() for cleanup on error

* Add default constructor for Jackson

Jackson complains about needing a default constructor for the
NON_DEFAULT annotation, but I'm not sure why this worked before.

* Clean up indentation and unused variable - no functional changes

Make indentation consistent throughout the module, changing recently
added lines to use the standard all spaces convention.

Remove unused count variable

* Simplify control flow

* Update limit parameter comment. No functional change.

* Replace ternary expression which is causing NPE

* Add reconciliation tests using mock HTTP server
2020-06-23 21:54:54 +02:00
Tom Morris
e293602897
Restore character encoding guesser (#2755)
* Fixes #486. Builds on code from Steffen Stundzig

- Switch from ICU4J to juniversalchardet
  (Java port of Mozilla charset detector)
- Replace org.json code with Jackson
- Add tests
- Add TODO for multi-file character encoding mismatches

* Restore dependency lost in rebase

Co-authored-by: Steffen Stundzig <git@stundzig.de>
2020-06-22 06:04:51 +02:00
Tom Morris
77b858db18
Fix race in Process Manager (#2748)
* Remove redundant JSON diff logging

* Fix race in process manager test causing intermittent failure
2020-06-17 21:24:25 +02:00
Tom Morris
749704518c
Use Apache HTTP Commons for Fetch URL (#2692)
* Use mockwebserver instead of live network for tests

Fixes #2680. Fixes #1904.

* Remove use of deprecated methods

* Convert to use Apache HTTP Components client library

Fixes #1410 by virtue of redirect following being a built-in
capability of the library, along with retries with binary backoff,
built-in decompression, etc.

* Address review comments
2020-06-16 09:38:06 +02:00
james-cui
04055153a1
add archive column (#2573)
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2020-06-15 19:56:00 +02:00
Joanne Ong
d57d76f7df
Fix imprecise facet statistics in records mode (#2607)
* Fix bug in choice counts for records mode

* Add test for value grouper on records

* Refactor and comment code

* Count distinct instances of null/blank data

* Update test to check for blank data count in records

* Remove unnecessary import statement
2020-06-15 19:38:50 +02:00
Lisa Chandra
947356ddad
[FEAT]Adds new options for split (#2471)
* added options ui

* added definition for both separators

* added tests

* removed definitions from backend and added them to frontend

* added reverse order and handling for accented characters

* added tests for accented characters and reverse split

* fixed build errors

* unicode character ranges instead

* added examples
2020-06-15 19:30:18 +02:00
chuhao zeng
9b03ecae41
Convert illegal characters into legal ones. (#2431)
* Convert illegal characters into leagal ones.

* Test tab in key & value string

Also fix up test that depended on previous TAB
related error message and clean up logging

Co-authored-by: Tom Morris <tfmorris@gmail.com>
2020-06-14 09:47:58 +02:00
Tom Morris
18c18e587e
Replace Apache Ant with Commons Compress (#2691)
NOTE: Changes the public API where some of the old types were
embedded which means that any extensions that extend these
interfaces will have to be updated.

Fixes #2690.
2020-06-11 16:39:51 +02:00
Tom Morris
e6ed8e5d62
Save preferences JSON using UTF-8 encoding. Bulletproof prefs load. (#2657)
* Save preferences JSON using UTF-8 encoding. Bulletproof prefs load.

Fixes #2543. Fixes #2627.

Always use UTF-8 to write JSON because platform default encoding
might not be legal JSON (e.g. ISO 8859-1).

Also be more conservative about keeping backups if we fail to write.

* Handle case where backup prefs is better than more recent

* Recover from corrupted prefs with null starred list.

Fixes #2544. Replaces null with an empty list.

* Run tests with non-UTF-8 encoding

Make sure that we don't depend on UTF-8 being the default encoding
because it isn't true everywhere (e.g. Windows)

* Add test for non-ASCII chars in workspace.json

This depends on the default Java encoding being something
other than UTF-8 to test properly.
2020-06-06 10:00:01 +01:00
Antoine Beaubien
3ca08f6ff1
Changed cell.error to cell.errorMessage & added help data. (#2628)
* Changed cell.error to cell.errorMessage & added help data.

Changed cell.error to cell.errorMessage and added the informations into the internal help system.

* FR Text correction

* HU Fix text

3 instead of 2.
2020-05-23 14:05:25 +02:00
Lu Liu
e89eaf0ee2
support default project name and column name for cross() (#2518) 2020-05-22 09:39:57 +02:00
Tom Morris
557ffad920
Merge pull request #2586 from OpenRefine/issue-2510-type-boolean
Support "boolean" return for type() function.  Closes #2510
2020-05-18 17:24:47 -04:00
Antoine2711
0e86619d86 Fix the true.type() == "boolean"
Fix the true.type() == "boolean" instead of java.lang.Boolean.

Remove all the references to "error" result  in Type(). This will be addressed in:
@ToDo fix this with issue #2562
2020-05-18 17:23:43 -04:00
Antonin Delpeuch
825e687b0b
Fix bug when both trim and autodetect are enabled in tabular parser. Closes #2584 (#2610) 2020-05-05 14:00:17 +02:00
PJ Fanning
ab64303cbb
allow xlsx files to have more columns (#2602) 2020-04-26 17:07:26 +02:00
PJ Fanning
fe7fcce94b
small improvement to xls tests (#2599) 2020-04-26 16:02:20 +02:00
PJ Fanning
1a0e187561
correct excel mime types (#2596)
* correct excel mime types

* address PR issue

* remove use of wildcard
2020-04-26 14:36:37 +02:00
Thad Guidry
009c587437
remove unused imports (#2574) 2020-04-21 15:51:01 +02:00
Lu Liu
bf84fc9cf1
use string representation for matching (#2571) 2020-04-20 09:07:09 +02:00
Ekta Mishra
05b6a7b2ae
Provides more intuitive representation for arrays in GREL (#2488)
Added test for same
closes #2040
2020-04-01 10:59:25 +02:00
chuhao zeng
1f0111eaed
Fix silent error in JSON/XML importers (#2414)
* Add error handler for parse error

* Add test for parsing json with incorrect strecture

* Enable localization from front-end

* Add methods to get localized error messages

* Update returned exception message

* Remove unused log and fix file diff issue

* Test auto build

* Refactor getOptions in newly created test

* Use new exception to unwrap original message

* Undo unexpected fix

* Remove unused lines

* Fix exception logic

* Fix typo
2020-03-27 09:41:49 +01:00
Lu Liu
f2b06418da
Support lookup by numbers for GREL cross function (#2468)
* support int & long argument for cross function

* support any types of a cell value
2020-03-26 08:57:10 +01:00
chuhao zeng
70b4c6a6d0
Enable gzip compression (#2475)
* Enable gzip compression

* Add test for gzip parser
2020-03-26 08:42:55 +01:00
chuhao zeng
e484625adf
Fix: Data losses when importing multiple sheets from same Excell file (#2404)
* Fix loosing data when importing multiple sheets from same source Excell file

* Add test for importing multi sheets with different column size

* Fix space issues

* Restore old tests and implement new test cases for the new feature

* Restore unexpected delete

* Refactor fix

* Restore unexpected line delete

* Add new unit test for new feature
2020-03-23 22:41:23 +01:00
Lu Liu
9ad3b1080f
Make cross() function work for all columns (#2456)
* fix #1950

* migrate from join to lookup

* reformat
2020-03-23 14:48:32 +01:00
Lisa Chandra
ef8ad85c3c
Adds trim whitespace option to separator based files (#2408)
* added trim ui to csv importer

* added trim functionality

* trimStrings handler only for strings

* added test for trimStrings option in csv/tsv files

* made trim option enabled by default
2020-03-21 10:38:43 +00:00
Albin Larsson
9745bfe374
consistent usage of Apache http status constants (#2432) 2020-03-18 06:40:52 +00:00
Albin Larsson
0233e7186b
CSVExporter: add test case for quoteAll option (#2430) 2020-03-18 04:39:32 +00:00
Lisa Chandra
a91691cb6b
[FIX] json/xml trim whitespace configuration option (#2415)
* trimStrings condition

* added test for trimString xml

* added trimStrings check for json
2020-03-15 16:04:01 +00:00
Lu Liu
14ef45efb2
mock reconciliation service (#2410) 2020-03-14 09:40:15 +00:00
zengchu2
c90fd31daf
Add cell.error field for error messages (#2363)
* Add case for querying cell.error for error messages

* Add testing file

* Refactor test case for cell with error

* Reformat spaces
2020-03-10 10:14:15 +00:00
jamessspanggg
67b62c5c16 EditOneCellCommandTests: Add number parsing tests 2020-01-08 09:55:51 +08:00
Antonin Delpeuch
904129d0f7 Fix other NPE in expression logging, for #2264 2020-01-06 06:30:56 +01:00
Antonin Delpeuch
14dd4c0112
Merge pull request #2264 from OpenRefine/issue-2086-expression-logging-npe
Fix NPE in expression logging.
2019-12-30 21:52:58 +01:00
Antonin Delpeuch
08e175dc66 Fix NPE in expresion logging. Closes #2086. 2019-12-25 12:33:42 +01:00
Antonin Delpeuch
78853f8fb2 More robust URI detection in tabular exporter. Closes #2213. 2019-12-25 11:33:03 +01:00
Antonin Delpeuch
cc5498a42a
Return best loaded language code in LoadLanguageCommand. (#2232)
Closes #2227.
2019-11-27 15:35:18 +00:00
Antonin Delpeuch
85e40b8c45 Fix typo 2019-11-07 17:52:38 +01:00
Antonin Delpeuch
efbfce29bb Add server-side language fallback.
This allows to keep the same Javascript calls to load languages, so it
does not require any change for extensions to benefit from this.

Closes #1350. Fixes #2209.
2019-11-07 17:23:02 +01:00
Antonin Delpeuch
5dc005749a Add CSRF protection to remaining commands 2019-10-15 12:07:13 +01:00
Antonin Delpeuch
3559eeb11f CSRF protection for project and recon commands 2019-10-15 12:07:12 +01:00
Antonin Delpeuch
a340c137d0 CSRF protection for OpenWorkspaceDirCommand and language loading 2019-10-15 12:07:04 +01:00
Antonin Delpeuch
91cead27f8 CSRF protection for ImportingController 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
70e37b9085 Add CSRF protection to cell, history, column and expr commands 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
51ddd27909 Require CSRF token in EditOneCellCommand 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
21b841a089 Add CSRF token generation capabilities, for #2164 2019-10-14 16:24:26 +01:00
viniciusbds
6743d5c878 Change strings comparison to use equals comparator 2019-10-01 23:05:24 -03:00
Antonin Delpeuch
bbb5766a33
Merge pull request #2155 from OpenRefine/issue-2152-lonely-clusters
Fix clusters with single candidates.
2019-09-18 19:08:18 +01:00
Antonin Delpeuch
36150a874d Fix scatterplot facet filtering 2019-09-12 11:52:28 +01:00
Antonin Delpeuch
573ba18e6d Fix scatterplot drawing command, closes #2117 2019-09-12 10:43:12 +01:00
Antonin Delpeuch
fdf742b052 Unlink wikidata extension from RefineTest 2019-09-12 10:24:25 +01:00
Antonin Delpeuch
95b063162d Fix clusters with single candidates. Closes #2152. 2019-09-11 12:12:32 +01:00
Antonin Delpeuch
3e241871cc Mock HTTP calls in data extension tests. Closes #1904. 2019-08-27 19:52:21 +01:00
Antonin Delpeuch
a8b6f63c90 Update testng configuration after package change 2019-08-23 15:19:30 +01:00
Antonin Delpeuch
29f3cef3ec Remove uses of junit, closes #2133 2019-08-23 14:09:27 +01:00
Antonin Delpeuch
46acc21a43 Move tests to their appropriate packages and deduplicate them, for #2133 2019-08-23 13:27:20 +01:00
Antonin Delpeuch
2b03efd84f Rename test packages to match tested ones, for #2133 2019-08-23 11:55:31 +01:00
Antonin Delpeuch
6e96441684 Merge test files for Find function 2019-07-21 16:18:19 +01:00
Owen Stephens
ac7b5a0a19 Update Find and Tests 2019-07-21 13:34:18 +01:00
Owen Stephens
d6999de0da Match only accepts regular expressions 2019-07-21 13:19:34 +01:00
Owen Stephens
0560b772f1 Add test for finding literals 2019-07-21 12:46:12 +01:00
Antonin Delpeuch
33ff7be18a Fix NPE in StandardReconConfig. Closes #2076. 2019-07-03 10:21:45 +02:00
Antonin Delpeuch
cde59a0dca
Merge pull request #2070 from OpenRefine/issue-2068-duplicate-json-key
Remove duplicate JSON keys.
2019-07-02 10:19:16 +02:00
Antonin Delpeuch
8390d234b1
Merge pull request #2058 from OpenRefine/issue-1994-customMetadata
Fix parsing and display of custom metadata
2019-06-14 14:53:19 +01:00
Antonin Delpeuch
9d76b04a1c Remove duplicate JSON keys. Closes #2068. 2019-06-14 11:38:24 +01:00
Krzysztof 'impune-pl' Prorok
ceb367b906 Updated tests for issue 1998 2019-06-04 17:05:44 +02:00
Antonin Delpeuch
b9573d83e0 Add customMetadata to project metadata parsing test 2019-06-04 12:02:49 +01:00
Antonin Delpeuch
51a8cbf946
Merge pull request #2042 from stanakaj/issue-2041
Fix column removal in reorder leaves undeleted hidden cells.
2019-05-31 08:41:13 +01:00
Antonin Delpeuch
b366b29da1 Fix #2025: XLSX tests locale dependency 2019-05-15 11:49:53 +01:00
s_tanaka
b8b9feac0c Fix column removal in reorder leaves undeleted hidden cells. 2019-05-15 19:37:40 +09:00
Antonin Delpeuch
0332be312f Fix JSON history corruption.
Also adds new logic to preserve the JSON representation of unknown operations,
to protect from version downgrading or removal of extensions.

Closes #1990.
2019-04-18 20:31:41 +01:00
Owen Stephens
794a17c98e Added XLSX exporter tests 2019-04-09 16:58:58 +01:00
Owen Stephens
e2aa929908 Ensure workbooks are closed after reading/writing 2019-04-09 15:02:10 +01:00
Owen Stephens
461b352035 Add test for reading XLSX 2019-04-09 13:50:42 +01:00
Owen Stephens
81a82499b5 Added tests for serializing cells containing dates and numbers 2019-04-04 23:00:56 +01:00
Owen Stephens
62bcc80dcc Add tests for serialisation of Booleans and Numbers in cells 2019-04-04 11:41:35 +01:00
Owen Stephens
7425418011 Add RandomNumber GREL function 2019-03-24 20:16:43 +00:00
Owen Stephens
fe6abedc52 Add inArray function to GREL 2019-03-24 19:50:25 +00:00
Antonin Delpeuch
5c44acc0b3
Merge pull request #1985 from ostephens/cross-error-reporting
Cross error reporting
2019-03-24 08:16:58 +00:00
Owen Stephens
722db56071 Add tests for new Cross errors 2019-03-23 14:15:23 +00:00
Antonin Delpeuch
7f6831523e
Merge pull request #1969 from OpenRefine/revert-1888-fix-reconcile-facets
Revert "Fix Reconcile facets affected by change to list facet boolean handling"
2019-02-27 10:33:21 +00:00
Antonin Delpeuch
7144798aac
Merge pull request #1967 from OpenRefine/compute_recon_features_bug
Fix Recon features computation for empty recons
2019-02-23 19:08:11 +00:00
Antonin Delpeuch
2bfc268e69 Revert "Merge pull request #1666 from ostephens/list-facet-changes"
This reverts commit 29a818f7b4, reversing
changes made to 1189cdb4f9.
2019-02-22 18:38:45 +00:00
Antonin Delpeuch
deb7335848 Fix Recon features computation for empty recons 2019-02-22 09:15:42 +00:00
Antonin Delpeuch
a072328637 Accept URIs in 'Use values as ids' operation.
Closes #1953.
2019-02-19 22:06:35 +00:00
Antonin Delpeuch
3a213b482c Fix failing test 2019-02-19 12:39:50 +00:00
Antonin Delpeuch
fcc6aa05d7 Provide default identifierSpace and schemaSpace for reconciliation services. Closes #1936. 2019-01-22 19:04:25 +01:00
Antonin Delpeuch
eb16784f01
Merge pull request #1924 from OpenRefine/issue1907
Disable DTDs in XML importer.
2019-01-07 14:07:30 +01:00
Antonin Delpeuch
e5da39fa4a
Merge pull request #1920 from OpenRefine/issue1913
Reorder reconciliation results by decreasing score
2019-01-06 15:55:51 +01:00
Antonin Delpeuch
6a0d7d56e4 Disable DTDs in XML importer. Closes #1907. 2018-12-31 16:02:34 +01:00
Antonin Delpeuch
ddd9bf9aa8
Merge pull request #1906 from OpenRefine/issue1893
Make clustering extensible
2018-12-31 14:13:46 +01:00
Antonin Delpeuch
79ec6988d6 Fix GetCLusteringFunctionANdDistancesCommandTest 2018-12-30 22:22:50 +01:00
Antonin Delpeuch
074765f816 Add test to ensure sort is stable. 2018-12-30 20:49:18 +01:00
Antonin Delpeuch
b03dbf2446 Reorder reconciliation results by decreasing score. Fixes #1913. 2018-12-30 20:47:12 +01:00
Jacky
150ee12058
Merge pull request #1902 from OpenRefine/cleanup
Tidy up various things
2018-12-11 20:59:50 -05:00
Antonin Delpeuch
8063ca63d9 Add license headers 2018-12-11 12:10:11 +00:00
Antonin Delpeuch
7ae71470ef Add new command to expose known clustering functions and distances 2018-12-11 10:51:29 +00:00
Jacky
7f7b71459c
Merge pull request #1901 from OpenRefine/issue1840
Fix zip slip vulnerability
2018-12-09 12:05:16 -05:00
Antonin Delpeuch
d4222c05ef
Merge pull request #1877 from OpenRefine/issue1876
Fix reconciliation result deserialization
2018-12-09 22:47:40 +09:00
Antonin Delpeuch
caf2b4d915 Add missing license headers 2018-12-09 12:22:40 +09:00
Antonin Delpeuch
79994e86da Create dedicated temporary dir for zip slip test 2018-12-09 11:01:58 +09:00
Antonin Delpeuch
e243e73e40 Fix zip slip vulnerability. Closes #1840. 2018-12-09 10:41:33 +09:00
jackyq2015
d1ed842f02 support both jdk 8 and 9 2018-12-08 15:31:01 -05:00
Antonin Delpeuch
be137fc53c Add serialization tests in different timezone 2018-12-06 15:46:20 +09:00
Antonin Delpeuch
44c43253a1 Avoid localizing time for dates with unspecified time. Closes #1874. 2018-12-02 12:58:05 +09:00
Antonin Delpeuch
82598ae1d5 Fix reconciliation result deserialization. Closes #1876. 2018-12-02 11:59:47 +09:00
Antonin Delpeuch
2e81c9ff2e Remove uses of org.json after merge 2018-12-01 05:11:21 +09:00
Antonin Delpeuch
70d0e9b283 Support UI json format for ColumnDetail 2018-11-30 19:39:42 +09:00
Antonin Delpeuch
1e578384e2 Avoid double serialization of json mode in recon config 2018-11-30 19:39:42 +09:00
Antonin Delpeuch
a4117b470c Remove leftover merge conflicts 2018-11-30 19:39:42 +09:00
Antonin Delpeuch
f667a78657 Migrate recent PRs to Jackson 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
99e98a2e78 Remove all references to org.json in core 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
d6ca879558 Migrate ColumnRenameOperation to Jackson 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
b0e9e21a6b Remove spurious references to org.json 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
59175daf38 Migrate GuessTypesOfColumnCommand to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
ba8e406a97 Clustering config Jackson deserialization 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
d311810c2c Migrate SortingConfig to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
86d1159926 Migrate Engine to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
c9786d0f9a Fix bug in join() GREL function 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
b569490eef Migrate ProjectMetadata to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
6d05631a07 Migrate GREL functions and controls to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
5a4a79028f Revert "data package metadata (#1398)"
This reverts commit c4b0ff6bea.
2018-11-30 19:35:31 +09:00
Antonin Delpeuch
ac444b8b50 Add project metadata serialization test 2018-11-30 19:23:08 +09:00
Antonin Delpeuch
ccb1ac84c1 Migrate GREL AST to Jackson 2018-11-30 19:23:08 +09:00
Antonin Delpeuch
e4e73d0b92 Migrate importers to use Jackson classes 2018-11-30 19:23:08 +09:00
Antonin Delpeuch
fc7da40055 Jackson deserialization for PreferenceStore 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
5cf58d874b Fix deserialization of MassEditOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
2873035ee2 Migrate TabularExporter to use JsonNode 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
52426b98a3 Jackson deserialization for CsvExporter 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
d012ea7f8d Remove reconstruct method on operations 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
6358a4aeb5 Jackson deserialization for TransposeColumnsIntoRowsOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
d493bf0720 Jackson deserialization for MassEditOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
5f671e5e81 Jackson deserialization for sorting Criterion and subclasses 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
242a3abb7d Jackson deserialization for RowRemovalOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
c58854d947 Jackson deserialization for ReconUseValuesAsIdsOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
3271e53ecf Jackson deserialization for ReconJudgeSimilarCellsOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
eb66619840 Jackson deserialization for ExtendDataOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
393eec1586 Jackson deserialization for EngineConfig 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
ae61368796 Jackson deserialization for TextSearchFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
c4caf1eba7 Jackson deserialization for TimeRangeFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
d8bc841dae Jackson deserialization for RangeFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
39498233fb Jackson deserialization for ListFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
d4bdd37bda Jackson deserialization for Recon 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
487f6bc131 Jackson deserialization for Row 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
0dae0811b0 Jackson deserialization for ReconConfig 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
bc6f1b0146 Fix failing tests after JSONWriter replacement 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
c9620a5d9a Add missing .flush(); .close() on JsonGenerator 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
fec28b99bc Various serialization fixes 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
1790799bfe Remove Jsonizable interface and write methods 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
fd69e4b980 Serialization tests for expression commands 2018-11-30 19:20:34 +09:00
Antonin Delpeuch
65231e2140 Refactor GetRowsCommand for Jackson migration 2018-11-30 19:20:34 +09:00