Commit Graph

720 Commits

Author SHA1 Message Date
Tom Morris
6a91b5d75b Use InputStream instead of Reader for JSON import - fixes #698 2013-03-23 18:36:05 -04:00
Tom Morris
6b3592982e Remove O(n^2) issue in tree importers - fixes #699
- Add sparse/based list implementation for ImportRecord
2013-03-23 12:02:51 -04:00
Tom Morris
f78dfadcf3 Clean up tree import utilities for #699
- lazy allocate objects
- conditionalize logging to prevent calls to StringBuilder & toString()

These are secondary issues, but still worth cleaning up.
2013-03-23 11:56:58 -04:00
Tom Morris
0a2ba1b1ae Switch from LinkedList to ArrayList
Just a simple list.  No need for extra overhead..
2013-03-23 08:16:23 -04:00
Tom Morris
56389588e3 Update to Jackson 1.9.12 2013-03-23 08:15:08 -04:00
Tom Morris
bfa7c34d17 Merge pull request #659 - closes #659 2013-03-18 21:24:01 -04:00
Tom Morris
31cffa1181 Merge remote-tracking branch 'upstream/master' 2013-03-18 21:16:55 -04:00
Tom Morris
8a61cf731b Merge pull request #664 from Arcadelia/Preserve_Quotes
Quotes should not be removed from values
2013-03-18 18:12:51 -07:00
Tom Morris
fe943fe3ea Flag English specific stopwords for cleanupp 2013-03-18 20:20:46 -04:00
Tom Morris
a06e16a9e5 Update some Javascript uses to new Freebase API - part of #696 2013-03-12 17:46:18 -04:00
Tom Morris
054ea643c3 Replace Google API key for Suggest - fixes #679 2013-03-12 17:27:58 -04:00
Tom Morris
7b9f6836e1 Update key & id recon to new Freebase APIs - part of #696 2013-03-12 16:50:23 -04:00
Tom Morris
7578d3375f Add logger and logging
- fix exception printing that goes nowhere
- make logger available for subclasses to use
2013-03-11 13:14:20 -04:00
Tom Morris
a2a8f4af2e Patch applied - closed #315 2013-03-06 21:45:54 -05:00
Tom Morris
d8d82bf8b7 Clean up a couple more format guessing issues left over from #685 2013-03-06 20:39:39 -05:00
Tom Morris
369bfffb2f Don't guess field widths unless we have at least 3 lines
- Investigation of #685 showed that single line files were being guessed
as fixed field width
2013-03-04 17:47:06 -05:00
Tom Morris
6b676f7513 Handle MIME media types which have charset param - fixes #685 2013-03-04 17:45:34 -05:00
Tom Morris
10bd7e3b75 Make upper bound of time facet inclusive - fixes issue #648 2013-03-03 16:06:20 -05:00
Tom Morris
5778a18b05 Switch to new reconcile service for namespaced lookups 2013-03-03 15:42:48 -05:00
Tom Morris
c2f2db52ab Fix issue #691 - include /common/topic properties
- Switch to new openrefine-helper app which includes /common/topic
properties in list
- Fix Suggest setup to allow /common/topic properties
2013-03-03 15:42:06 -05:00
Tom Morris
eba03fc69e Protect joins map with mutex - fixes issue #652 2013-03-03 09:36:43 -05:00
Tom Morris
0dfd7d7112 Blacklist /common/resource in Suggest - extends fix for issue #632 2013-03-03 09:17:48 -05:00
Tom Morris
23cc319fd7 Switch to released version of reconciliation service - fixes issue #629 2013-03-02 16:00:56 -05:00
Tom Morris
a2711e4f59 Correct Suggest property filter - fixes issue 689 2013-03-01 22:26:05 -05:00
Tom Morris
38a88db58d Patch Suggest to accept type param for Search 2013-03-01 18:57:11 -05:00
Tom Morris
7b3379afc7 fix range check in getFields - fixes issue 687 2013-02-26 16:35:21 -05:00
Tom Morris
389e762251 Merge remote-tracking branch 'upstream/master' 2013-02-26 00:01:06 -05:00
Tom Morris
95e13eac50 Improve recon error handling 2013-02-26 00:00:03 -05:00
Tom Morris
a2b60d3d4b Fix filter to blacklist documents correctly 2013-02-25 19:45:25 -05:00
Tom Morris
ed07a4d489 Revert "Black list /type/content in Suggest. Closes issue #632"
This reverts commit 98c64201ef.
2013-02-21 12:45:49 -05:00
Tom Morris
975d18942f Update to Clojure 1.4. Closes issue #634 2013-02-12 00:15:35 -05:00
Tom Morris
50888c6f2e Merge pull request #666 from Arcadelia/Temp-file_removal
Fixed removal of upload temp files
2013-02-11 15:11:24 -08:00
Tom Morris
98c64201ef Black list /type/content in Suggest. Closes issue #632 2013-02-11 17:43:58 -05:00
Tom Morris
ab14198899 Fix last page calculation. Closes #660. 2013-02-11 16:51:34 -05:00
Tom Morris
1033ce973e TODO about memory usage 2013-02-03 15:56:54 -05:00
Jesus Castagnetto
fec35a8bc6 Update main/src/com/google/refine/expr/functions/booleans/Xor.java 2013-02-01 21:07:42 -05:00
Jesus Castagnetto
ebec459cfd indentation change 2013-02-01 21:00:36 -05:00
Jesus Castagnetto
473e2f367f Implementing Xor operation 2013-02-01 17:59:16 -08:00
Tom Morris
0da4214f88 Add some tests before working on #640 and #409 2013-02-01 17:14:46 -05:00
Tom Morris
c0347225b8 Switch escape character from NUL to DEL in hopes that it's rarer. 2013-02-01 17:12:07 -05:00
Tom Morris
008df21b33 Update OpenCSV to our fork with multi-character separator support
Built from the openrefine-2.6 branch in the OpenRefine/opencsv repo
2013-01-27 15:21:53 -05:00
Tom Morris
b24b291251 Merge pull request #665 from Arcadelia/IE_Cache-fixes
Fixed history and header update in IE by setting "Cache-Control", "no-cache" in HTTP headers
2013-01-25 16:17:54 -08:00
Mateja Verlic
3b06060597 Tooltip is updated after changing facet expression - fixed #649 2013-01-25 21:56:24 +01:00
Mateja Verlic
7dc7bc0ad1 Updated logos with new ones - part of #630 rebranding 2013-01-25 19:57:10 +01:00
Frank Wennerdahl
2c59a0059f Fixed removal of upload temp files
Fixed an issue with an unclosed stream preventing upload temp files from
being removed after use. Also removed the use of FileCleaningTracker and
instead added manual removal of all tempfiles. By doing this the reaper
threads in FileCleaningTracker are avoided and files are removed
directly after use.
2013-01-24 09:59:09 +01:00
Frank Wennerdahl
64cf62e081 Fixed history and header update in IE
Due to Internet Explorer caching GET requests the Undo/Redo list and
column headers were not updated, leaving essential parts of the user
interface crippled even if Google Frame is installed. Adding
Cache-Control headers to the responses fixes this.
2013-01-24 09:39:12 +01:00
Frank Wennerdahl
1f7ab046c7 Quotes should not be removed from values
Leading quotation marks should not be removed from values. If they have
been left by the importing parser they should be considered part of the
value.
2013-01-24 09:04:17 +01:00
Frank Wennerdahl
ebdc40ad71 Added CSV quote options
Added two additional CSV options, one for parsing and one for export.

Specifying strict quotes when parsing will ignore all data not quoted.
Specifying quote all when exporting will enclose all values in quotes.

No front-end changes made, just added the support for the options in the
requests.
2013-01-21 08:21:16 +01:00
Tom Morris
33aa1132d7 Clarify wording/naming of blank rows export option - fixes issue #651
- clarify that it refers to all non-null cells
- rename variables without compatibility constraints to match actual
function
2013-01-14 16:36:09 -05:00
Tom Morris
d4cef3e2c5 Update to Freebase Suggest 4.1 - Closes #645
- change log for Suggest http://markmail.org/message/ycggcybvtyxep6ne
- most visible fix for Refine is display of /common/topic/article when
/common/topic/description is missing
2013-01-05 15:24:52 -05:00
Tom Morris
3b85ad7a7f Fix up a couple more absolute (or wrong) paths 2012-11-20 16:02:20 -05:00
Tom Morris
04668eb720 Blacklist /common/document in Suggest - fixes #632 2012-11-20 15:15:52 -05:00
Tom Morris
6315036c82 Don't assume notable types are returned by Suggest
Freebase Suggest doesn't always return a notable key in its dictionary,
so we need to check whether it exits.  Fixes issue #636
2012-11-20 14:03:35 -05:00
Tom Morris
2279fe86d7 Merge remote-tracking branch 'upstream/master' 2012-11-20 12:32:02 -05:00
Tom Morris
6e50347c77 Delete unused bad JSON jar 2012-11-18 11:06:35 -05:00
Tom Morris
390ac944aa Revert debug alert accidently committed 2012-11-06 19:15:28 -05:00
Tom Morris
91d67e2ddc Rename Eclipse project to OpenRefine
- change top level Eclipse project from grefine-all to OpenRefine as
part of #630 rebranding
2012-10-19 10:47:10 -04:00
Tom Morris
0bd2104a16 Issue 630: Change branding from Google Refine to OpenRefine
** The first native Github commit (ie not one converted from SVN **
Change Google Refine to OpenRefine or just Refine.  
Change icon filenames and add some placeholder icons
2012-10-18 19:40:31 -04:00
Tom Morris
03d997be8e FIXED - task 576: Use relative paths so works under a Java server named context - patch supplied by sergio@wikier.org
http://code.google.com/p/google-refine/issues/detail?id=576

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2584 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-13 17:47:08 +00:00
Tom Morris
068e0916a2 FIXED - task 587: Correct initialization of the temporary directory - patch from the Wikier project
http://code.google.com/p/google-refine/issues/detail?id=587
https://bitbucket.org/wikier/google-refine/changeset/f3dbdb16a320#chg-main/src/com/google/refine/RefineServlet.java

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2583 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-13 15:58:44 +00:00
Tom Morris
4d48741ce0 FIXED - task 574: create safe sheet names for Excel export - patch from jd@tekii.com.ar
http://code.google.com/p/google-refine/issues/detail?id=574

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2582 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-12 23:05:17 +00:00
Tom Morris
c003ef42a2 Missed a Freebase Suggest version change.
http://code.google.com/p/google-refine/issues/detail?id=630

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2581 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-12 22:41:04 +00:00
Tom Morris
12308c2840 task 584: Add a timeout of 10 seconds for reconciliation service to respond
http://code.google.com/p/google-refine/issues/detail?id=584

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2580 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-12 22:29:53 +00:00
Tom Morris
3ff52ba494 FIXED - task 584: remove busy spinner & show error if failed to query new recon service
http://code.google.com/p/google-refine/issues/detail?id=584

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2579 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-12 20:33:33 +00:00
Tom Morris
f135b1b8d9 FIXED - task 579: Rebuild services map when deleting recon service - patch from sergio@wikier.org
http://code.google.com/p/google-refine/issues/detail?id=579

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2578 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-12 19:49:33 +00:00
Tom Morris
bfb76d5907 FIXED - task 628: update to Freebase Suggest 4.0 - patch supplied by sdeo@google.com
http://code.google.com/p/google-refine/issues/detail?id=628

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2576 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-12 18:52:06 +00:00
Tom Morris
8defe9ee32 FIXED - task 628: update to Freebase Suggest 4.0 - patch supplied by sdeo@google.com
http://code.google.com/p/google-refine/issues/detail?id=628

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2575 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-12 18:39:05 +00:00
Tom Morris
ca2e959957 FIXED - task 529: Add support for key/value transpose with only two columns as well as repeating key fields in a single record.
http://code.google.com/p/google-refine/issues/detail?id=529

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2574 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-05 23:31:25 +00:00
Tom Morris
ffe674729c Just a little Javadoc. No functional changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2573 7d457c2a-affb-35e4-300a-418c747d4874
2012-10-05 21:10:32 +00:00
Tom Morris
2c52a00f55 Fixed - issue 544,600,618: Clean up handling of compressed files & archives with multi-segment paths
http://code.google.com/p/google-refine/issues/detail?id=600


git-svn-id: http://google-refine.googlecode.com/svn/trunk@2569 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-22 18:08:56 +00:00
Tom Morris
748e205ae8 FIXED - task 616: Support bzip2 decompression on import
http://code.google.com/p/google-refine/issues/detail?id=616

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2568 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-22 16:00:42 +00:00
Tom Morris
27e3c0c8dc FIXED - task 614: Use same instance of OAuthProvider in OAuth dance. Patch supplied by sdeo@google.com
http://code.google.com/p/google-refine/issues/detail?id=614

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2566 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-19 23:16:29 +00:00
Tom Morris
b3f5fada95 FIXED - task 578 & 596: Clean up JSON importer
http://code.google.com/p/google-refine/issues/detail?id=578
http://code.google.com/p/google-refine/issues/detail?id=596

Extend tree parser framework to allow any Serializable instead of just Strings. Use this in JSON importer to: Import keywords null, true, false; Import empty strings and don't trim whitespace from strings on import;  Import numbers directly instead of importing them as text and then parsing them ourselves. Add tests to verify all this stuff

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2543 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-08 01:20:25 +00:00
Tom Morris
9f7d0bc057 FIXED - task 607: Make memory/heap reporting more user-friendly
http://code.google.com/p/google-refine/issues/detail?id=607

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2542 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-07 21:49:00 +00:00
Tom Morris
93d6e176d6 Task 478: Default "guess datatypes" to False so importers which don't specify it (e.g. gData & Excel) aren't effected
http://code.google.com/p/google-refine/issues/detail?id=478

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2541 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-07 21:17:34 +00:00
Tom Morris
83dce305cb FIXED - task 432: cross() failing - flush join cache table when column changes
http://code.google.com/p/google-refine/issues/detail?id=432

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2539 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-30 16:31:22 +00:00
Tom Morris
9b54a8f29e FIXED - task 559: Deadlock between autosave thread and history code
http://code.google.com/p/google-refine/issues/detail?id=559

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2538 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-30 16:22:28 +00:00
Stefano Mazzocchi
ba89daec1c make oauth against freebase work again in chrome
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2537 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-23 20:58:08 +00:00
Tom Morris
be6bdfe50a Restore old JSON library jar
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2535 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-21 17:29:47 +00:00
Tom Morris
12a61b6ec6 task 603: range check column move commands
http://code.google.com/p/google-refine/issues/detail?id=603

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2534 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-18 22:01:23 +00:00
Tom Morris
202018fac4 Add Javadoc. No code changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2533 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-18 22:00:41 +00:00
Tom Morris
60c3a31242 Update Jackson and JSON libs
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2532 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-18 21:46:49 +00:00
Tom Morris
4bb6c43982 task 604: add Guava to main project so that we're not dependent on an extension
http://code.google.com/p/google-refine/issues/detail?id=604

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2531 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-15 13:33:17 +00:00
Tom Morris
7c7e10d9f5 Fix silly cut & paste test name.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2530 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-14 23:11:42 +00:00
Tom Morris
1e043dcc94 FIXED - task 604: The common transform “Trim leading and trailing whitespace” doesn’t trim non-breaking spaces
http://code.google.com/p/google-refine/issues/detail?id=604

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2529 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-14 23:00:13 +00:00
Tom Morris
f29f77e8f8 STARTED - task 604: The common transform “Trim leading and trailing whitespace” doesn’t trim non-breaking spaces
http://code.google.com/p/google-refine/issues/detail?id=604

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2528 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-14 20:09:49 +00:00
Tom Morris
40dbe79a03 FIXED - task 601: Allow selection of root element on JSON import
http://code.google.com/p/google-refine/issues/detail?id=601

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2527 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-09 14:17:35 +00:00
Tom Morris
4bf212c03d FIXED - task 154: Can't import RDF/XML Data
http://code.google.com/p/google-refine/issues/detail?id=154

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2526 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-05 16:31:41 +00:00
Tom Morris
5881addac8 Throw an exception if unsupported verb is used
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2525 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-05 15:36:23 +00:00
Tom Morris
264a7dfc77 NEW - task 599: RDF/XML parser preview not wired up
http://code.google.com/p/google-refine/issues/detail?id=599

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2523 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-04 18:02:45 +00:00
Tom Morris
cdaf60c20b FIXED - task 597: Deselect all button on Custom Tabular Exporter dialog doesn't work
http://code.google.com/p/google-refine/issues/detail?id=597

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2521 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-03 22:11:51 +00:00
Tom Morris
b2ae74d23f FIXED - task 586: Only one parse date format is attempted from list in toDate(format1,format2)
http://code.google.com/p/google-refine/issues/detail?id=586

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2520 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-03 18:01:01 +00:00
Tom Morris
4319314675 FIXED - task 594: Date diff function doesn't work for two Calendar objects
http://code.google.com/p/google-refine/issues/detail?id=594

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2519 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-02 21:41:19 +00:00
Tom Morris
efa58630cf Add constructor that takes a Throwable to eliminate redundant code from callers.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2518 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-02 21:38:00 +00:00
Stefano Mazzocchi
2947ebba0e updating the signpost library and attaching sources for easier inspection
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2517 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-01 21:47:21 +00:00
Stefano Mazzocchi
2cb31b8b29 fixing oauth problems with redirection for the Freebase API
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2516 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-01 21:46:53 +00:00
David Huynh
4cfb921082 Added getStringKey() method for when it is difficult to generate integer keys that don't collide
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2515 7d457c2a-affb-35e4-300a-418c747d4874
2012-07-19 00:25:41 +00:00
Stefano Mazzocchi
5dffd249de updating signpost to the latest release
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2514 7d457c2a-affb-35e4-300a-418c747d4874
2012-07-13 06:50:53 +00:00
Stefano Mazzocchi
6e41f4ad91 make the latest eclipse happy (it triggers a warning)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2513 7d457c2a-affb-35e4-300a-418c747d4874
2012-07-12 01:55:11 +00:00
Stefano Mazzocchi
3b8701aeee further cleanup, sign.js should not contain presentation-related code
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2512 7d457c2a-affb-35e4-300a-418c747d4874
2012-07-12 01:54:24 +00:00