Commit Graph

637 Commits

Author SHA1 Message Date
xseris
f21230804b Fixed Mockito tests 2017-12-01 17:00:45 +01:00
Owen Stephens
93431daecf Remove unused variable 2017-11-29 09:47:03 +00:00
Owen Stephens
0b433fc5ec Updated copyright statement 2017-11-29 00:59:49 +00:00
Owen Stephens
d64dee71dd Extended tests and code for user friendly regular expression syntax errors 2017-11-28 16:20:24 +00:00
Owen Stephens
441d9f7f10 Initial tests and code for user friendly regular expression syntax errors 2017-11-24 18:24:16 +00:00
Thad Guidry
34f38ccaf8
Merge pull request #1336 from ostephens/multi-cell-join-tests
Add tests for JoinMultiValuedCells
2017-11-16 22:49:03 -06:00
Jacky
8d2c8b521b
Merge pull request #1334 from jackyq2015/issue/1328
fix import multiple excel with mulitple sheets issue #1328
2017-11-16 21:30:24 -05:00
Jacky
1d2998f374 fix the unit test
support multi files with multi tables for open office
2017-11-16 10:29:16 -05:00
Owen Stephens
df920777ac Moved variable to local scope 2017-11-16 12:47:05 +00:00
Antonin Delpeuch
78b7f01be5
Merge pull request #1327 from ostephens/invert-filter
Invert text search facet/text filter
2017-11-16 08:05:31 +00:00
Owen Stephens
742b42ade1 More code tidy up 2017-11-15 19:01:52 +00:00
Owen Stephens
2d0f48e93f Corrections for Codacy 2017-11-15 18:51:58 +00:00
Owen Stephens
3a31e69c2b Added Tests for TextSearchFilter 2017-11-15 18:31:55 +00:00
Qi Cui
6bdba6948e add tests for SetProjectMetadataCommand 2017-11-14 15:54:22 -05:00
Jacky
75b82106b4 fix the package declarations 2017-11-03 17:11:31 -04:00
Thad Guidry
d72a2de348 Revert "Extend cross() function to support multiple-value-cell-input" 2017-10-26 17:37:10 -05:00
Thad Guidry
3d0e96a0ce Merge pull request #1290 from claussni/cross-func-split
Extend cross() function to support multiple-value-cell-input
2017-10-26 14:23:23 -05:00
Ralf Claussnitzer
0b107ec5e9 Add optional 4th parameter to cross() function
The cross function now accepts a 4th parameter defining a regular
expression separator for splitting multi-value field values when joining
projects.

See https://github.com/OpenRefine/OpenRefine/issues/1204#issuecomment-326320954
2017-10-26 19:50:02 +02:00
Owen Stephens
c10f72437f Add tests for JoinMultiValuedCells 2017-10-25 11:15:59 +01:00
Antonin Delpeuch
88b10a2917 Merge pull request #1278 from ostephens/cell-split-regex
Cell split regex
2017-10-25 11:04:33 +01:00
Owen Stephens
300edcca74 Minor fix to comment in code 2017-10-24 08:58:32 +01:00
Owen Stephens
219e747147 Removed unused dependency 2017-10-24 08:54:58 +01:00
Owen Stephens
209500bf3a Add tests for SplitMulitValuedCells 2017-10-24 08:29:00 +01:00
Owen Stephens
bb6b3d6c29 Re-locate operations tests in correct folder 2017-10-23 18:54:59 +01:00
Antonin Delpeuch
e2a22a6994 Forbid pipe characters in URL references to ease parsing.
This is a temporary fix before we do full Wikitext parsing inside references
(this needs a change upstream). See https://github.com/sweble/sweble-wikitext/issues/67 .
2017-10-20 15:32:58 +01:00
Antonin Delpeuch
1da3c00cb1 Perform ASCII normalization earlier in FingerprintKeyer.
This closes #1256.
2017-09-27 09:23:40 +01:00
Antonin Delpeuch
a1b2c9b683 Add support for references in Wikitable importer.
Closes #1243.
2017-09-23 22:54:43 +01:00
Antonin Delpeuch
00f8e4fc6b Merge pull request #1237.
Conflicts:
	.classpath
	main/webapp/modules/core/langs/translation-en.json
	main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js

Closes #363 and #56.
2017-08-28 16:25:50 +01:00
Antonin Delpeuch
554b75fa7b Fix parsing of newlines in cells 2017-08-17 19:18:50 +01:00
Antonin Delpeuch
7989aacc58 Cleanup for Codacy 2017-08-17 12:40:56 +01:00
Antonin Delpeuch
637e69db9d Better error reporting and testing for Wikitext import 2017-08-16 10:30:51 +01:00
Antonin Delpeuch
3dcda5a42c Add reconciliation config in wikitext import. 2017-08-16 00:05:40 +01:00
Antonin Delpeuch
5390aa248c Fix DataExtensionTests (Tajikistan has only one currency, not two) 2017-08-15 22:11:00 +01:00
Antonin Delpeuch
d01de6ea85 Update tests 2017-08-15 22:09:45 +01:00
Antonin Delpeuch
aa4517ba58 Add support for colspan and rowspan in Wikitext 2017-08-15 11:28:43 +01:00
Antonin Delpeuch
e168c900e8 Add support for table headers 2017-08-13 20:14:48 +01:00
jackyq2015
45e3ea5e86 fix testng data path issue 2017-08-13 13:03:19 -05:00
jackyq2015
f3463c332e Unit test for issue #137 2017-08-13 12:37:20 -05:00
Antonin Delpeuch
b8a781d366 Add support for links (unreconciled for now) 2017-08-13 12:57:46 +01:00
Antonin Delpeuch
e6406f56ef Initial version of the wikitext importer 2017-08-13 11:26:59 +01:00
jackyq2015
588024f60d Merge branch 'master' of https://github.com/OpenRefine/OpenRefine 2017-08-06 22:06:58 -05:00
jackyq2015
fd58ac1e99 fix some xml issues 2017-08-06 22:05:17 -05:00
Antonin Delpeuch
3b30018cad Merge pull request #1216 from OpenRefine/issue1214
Add test for KeyValueColumnize
2017-08-03 19:31:35 +01:00
Antonin Delpeuch
135dd50413 Fix Codacy issues 2017-08-03 12:47:09 +01:00
Antonin Delpeuch
afed8eb28a Generate code coverage reports with Jacoco 2017-08-03 11:07:14 +01:00
Antonin Delpeuch
66eac0fae9 Ensure null values are not cached in URL fetching operation. Closes #1219. 2017-08-01 13:05:29 +01:00
Antonin Delpeuch
7de2a57c3a Add RefineServletStub initialization in KeyValueColumnizeTests 2017-07-26 18:39:08 +01:00
Antonin Delpeuch
d941320f5e Adapt test about #1214 to show how the function currently works.
With this test, if someone tries to fix this "bug" in the future, they will realize this use case should be preserved.
2017-07-26 18:07:52 +01:00
Antonin Delpeuch
453d35032b Add test for issue #1214 2017-07-26 00:41:06 +01:00
jackyq2015
64ab5a4409 unit test for backward compatibility for cross function 2017-07-23 19:31:25 -04:00
Thad Guidry
7f92251ed1 Merge pull request #1210 from wetneb/extend
Add data extension capabilities to the reconciliation API
2017-07-17 18:01:37 -05:00
Antonin Delpeuch
c04d9f3c33 Switch to public WMF endpoint for tests 2017-07-16 11:54:12 +01:00
Antonin Delpeuch
84c06821ee Data extension tests 2017-07-16 11:47:12 +01:00
jackyq2015
1ee339cbbd cross function test suite. #1204 2017-06-28 08:12:36 -04:00
jackyq2015
af731a3c1f add test case for cross function 2017-06-25 23:27:48 -04:00
Bob Harper
909df1b6a7 xor can also accept 2+ params, rewrite tests to be consistent 2017-04-27 11:20:48 +01:00
Bob Harper
4ea0f440e9 remove 3 param error test for 'and' and 'or' 2017-04-27 11:07:04 +01:00
Antonin Delpeuch
22124ac57e Add checkbox to disable caching 2017-03-09 00:21:34 +00:00
Antonin Delpeuch
32c232c2d6 Move to Guava's cache for ColumnAdditionByFetchingURLsOperation 2017-03-08 09:32:34 +00:00
Antonin Delpeuch
3297e6e7ee Add tests for the URL caching feature 2017-03-08 00:50:09 +00:00
Qi Cui
773151380e fix #1138. column transpose 2016-08-24 13:56:35 -04:00
Steffen Stundzig
7f5e58ef51 #1086 add support for quote character 2015-10-30 14:32:46 +01:00
jackyq2015
7a2a0eb52f fixed issue #796 Columnize by key/value columns creates empty lines 2015-09-29 20:12:05 -04:00
magdmartin
b635f4e067 Merge pull request #1055 from RefinePro/issue-512
fix issue #512 to save the file location as a table column
2015-09-20 09:31:16 -04:00
jackyq2015
4e6f584cde fix issue #512 to save the file location as a table column 2015-08-27 15:13:20 -04:00
jackyq2015
a89dc7c25a fix the junit issue 2015-08-06 22:27:20 -04:00
jackyq2015
dc7535c63e 1. take out of issue #1021 fix which was mistakenly put in
2. fix the expected value for JUNIT
2015-08-06 21:31:37 -04:00
QI CUI
495dcd7bd5 use the LinkedHashMap instead of HashMap to make sure the retrive order 2015-01-30 15:03:20 -05:00
Tom Morris
ddfaecb3e6 Merge pull request #914 from opendatatrentino/rev-masschange
Fix wrong revert order in MassChange
2014-12-22 23:50:31 -05:00
David Leoni
4d2b90ad60 added MassChangeTests 2014-12-22 12:23:49 +01:00
Tom Morris
09f55fb436 Merge pull request #920 from opendatatrentino/fixEclipseDeps
Update deps in Eclipse projects and some jar sources
2014-12-21 12:39:43 -05:00
David Leoni
d1d436c184 Fixes locale dependent calendar to string test 2014-12-01 18:48:15 +01:00
David Leoni
ffad78c542 updated deps in Eclipse project and some jar sources 2014-12-01 16:17:25 +01:00
Tom Morris
e3cdd160d0 Test for issue #796 (failing until fixed) 2014-05-30 01:47:20 -04:00
Pablo Moyano
f45ea488cd Correcting typo that was breaking one UI test 2013-12-17 01:40:45 -03:00
Tom Morris
84c20af185 Switching more big Ys to little ys for java 6 2013-09-19 01:38:09 -04:00
Tom Morris
891f7125d3 One more try at a passing Java 6 test 2013-09-19 01:29:17 -04:00
Tom Morris
a95a3a78d7 Make test Java 6 compatible for TravisCI (hopefully) 2013-09-19 01:16:26 -04:00
Tom Morris
952443c38c Create a HistoryManagerStub to go with ProjectManagerStub for testing 2013-09-18 18:45:45 -04:00
Tom Morris
bc801546cc Remove references to obsolete splitIntoColumns option 2013-09-18 18:44:58 -04:00
Tom Morris
1261734f15 Partial solution for #816 plus improved conversion test coverage 2013-09-18 11:14:48 -04:00
Tom Morris
fa072df85c Add locale support to toDate() - fixes #729 2013-08-15 15:19:01 -04:00
Tom Morris
7edc550618 Give a reasonable error message on Excel 95 import failure - fixes #564 2013-07-26 16:24:56 -04:00
Tom Morris
ff4eeb549a Fix typo 2013-07-26 15:35:18 -04:00
Tom Morris
6dd4b8ea23 Add tests for boolean functions and tighten up error handling 2013-07-25 13:45:04 -04:00
Tom Morris
8cb1dc05f8 Really restore Java 6 compatibilty 2013-06-23 14:42:05 -04:00
Tom Morris
3b835fabad Restore Java 6 compatibility 2013-06-23 14:11:30 -04:00
Tom Morris
a3b4b45e4e Support non-string types in facetCount() - fixes #591 2013-06-23 12:04:48 -04:00
Tom Morris
51c1bc4a2f Refactor default toString with date support into separate utility 2013-06-23 12:02:13 -04:00
Tom Morris
a42925f3c8 Remove unused code 2013-06-23 11:21:48 -04:00
Tom Morris
c961bb64de Flush all column caches on row removals/changes. Fixes issue 567. 2013-06-22 18:44:26 -04:00
Tom Morris
43b2d89703 Remove dead code 2013-06-22 16:23:14 -04:00
Tom Morris
e1bea25c72 Clean up server tests
- move from shell script to Ant
- update TestNG and Mockito to latest versions
2013-06-11 19:44:58 -04:00
Tom Morris
1907bcd8dc Disable tests for character decomposition 2013-05-31 17:04:09 -04:00
Tom Morris
567da6aa9f Normalize line endings
Add .gitattributes & do one-time normalization of line endings
2013-03-23 18:46:20 -04:00
Tom Morris
6a91b5d75b Use InputStream instead of Reader for JSON import - fixes #698 2013-03-23 18:36:05 -04:00
Tom Morris
0da4214f88 Add some tests before working on #640 and #409 2013-02-01 17:14:46 -05:00
Tom Morris
0bd2104a16 Issue 630: Change branding from Google Refine to OpenRefine
** The first native Github commit (ie not one converted from SVN **
Change Google Refine to OpenRefine or just Refine.  
Change icon filenames and add some placeholder icons
2012-10-18 19:40:31 -04:00
Tom Morris
b3f5fada95 FIXED - task 578 & 596: Clean up JSON importer
http://code.google.com/p/google-refine/issues/detail?id=578
http://code.google.com/p/google-refine/issues/detail?id=596

Extend tree parser framework to allow any Serializable instead of just Strings. Use this in JSON importer to: Import keywords null, true, false; Import empty strings and don't trim whitespace from strings on import;  Import numbers directly instead of importing them as text and then parsing them ourselves. Add tests to verify all this stuff

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2543 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-08 01:20:25 +00:00
Tom Morris
7c7e10d9f5 Fix silly cut & paste test name.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2530 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-14 23:11:42 +00:00
Tom Morris
1e043dcc94 FIXED - task 604: The common transform “Trim leading and trailing whitespace” doesn’t trim non-breaking spaces
http://code.google.com/p/google-refine/issues/detail?id=604

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2529 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-14 23:00:13 +00:00
Tom Morris
4bf212c03d FIXED - task 154: Can't import RDF/XML Data
http://code.google.com/p/google-refine/issues/detail?id=154

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2526 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-05 16:31:41 +00:00
Tom Morris
b2ae74d23f FIXED - task 586: Only one parse date format is attempted from list in toDate(format1,format2)
http://code.google.com/p/google-refine/issues/detail?id=586

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2520 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-03 18:01:01 +00:00
Tom Morris
4319314675 FIXED - task 594: Date diff function doesn't work for two Calendar objects
http://code.google.com/p/google-refine/issues/detail?id=594

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2519 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-02 21:41:19 +00:00
Tom Morris
e97e7523b2 Issue 548 - Convert non-strings to strings before escaping
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2463 7d457c2a-affb-35e4-300a-418c747d4874
2012-03-14 03:06:11 +00:00
Tom Morris
ab4c0cb21c Some basic type conversion tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2456 7d457c2a-affb-35e4-300a-418c747d4874
2012-03-08 14:49:03 +00:00
Tom Morris
593c4123a9 Update one Windmill UI test for Refine 2.5. Another 6 still need to be done.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2433 7d457c2a-affb-35e4-300a-418c747d4874
2012-01-27 16:26:42 +00:00
Tom Morris
fdac0c30cf Issue 524 - shorten __anonymous__ names for JSON importer
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2432 7d457c2a-affb-35e4-300a-418c747d4874
2012-01-26 22:38:25 +00:00
Tom Morris
254d4468cc Fix failing test
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2431 7d457c2a-affb-35e4-300a-418c747d4874
2012-01-26 22:34:39 +00:00
David Huynh
cdca6fff8f Checked in Shardul Deo's patch from
http://groups.google.com/group/google-refine-dev/browse_thread/thread/5222a68396c56405
to support HTTP PUT and DELETE.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2387 7d457c2a-affb-35e4-300a-418c747d4874
2011-11-25 03:48:03 +00:00
Stefano Mazzocchi
856ef6a65a commented out unused variables
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2352 7d457c2a-affb-35e4-300a-418c747d4874
2011-11-01 21:47:24 +00:00
Tom Morris
fe7bf1d1f0 Refactor to conform to method naming conventions
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2344 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-21 16:57:52 +00:00
Tom Morris
ab950689dd Add debugging info - mostly toString() methods for types missing them
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2343 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-21 16:46:55 +00:00
Tom Morris
4966dcc61f Basic trivial test for Excel importer. Please add to this...
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2329 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-12 23:42:29 +00:00
Stefano Mazzocchi
1f67866258 fixing a bunch of inconsistencies and potential bugs as indicated by findbugs, pmd and eclipse
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2301 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 21:23:23 +00:00
Stefano Mazzocchi
af5b49eab9 whitespace (no functional changes)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2299 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:25:15 +00:00
Tom Morris
6b97f6602f Fix last(?) failing test
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2297 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:16:19 +00:00
Tom Morris
31073d7712 Refactor importer interfaces to narrow exceptions thrown and handled
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2296 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:06:53 +00:00
Tom Morris
e3f1fab4e8 Issue 453 - Add test for importing top level JSON array - from Thad
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2287 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:52:31 +00:00
Tom Morris
79c795138c Provide exception info for failures
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2286 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:51:06 +00:00
Tom Morris
4a4daf7112 Add some Javadoc. No functional changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2285 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:29:14 +00:00
Tom Morris
cf206c33bc Update test to accommodate new test for pending operations
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2282 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 21:09:31 +00:00
Tom Morris
97dda9f577 Refactor option mock setup and verification - all tests green (for this module)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2281 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:53:19 +00:00
Tom Morris
90c2715901 Back out workaround for cell numbering
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2280 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:29:53 +00:00
David Huynh
58414f72df Got more tests to pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2279 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:01:27 +00:00
David Huynh
a9279e2997 Got more tests to pass.
Note that the automatic column naming behavior did change from { "Column", "Column2", "Column3", ... } to { "Column 1", "Column 2", "Column 3", ... }.

Also note that the tsv/csv importer no longer supports the option not to split into columns. That's another importer (the line-based importer).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2277 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 07:09:05 +00:00
David Huynh
1c5dc32b88 Fixed tsv/csv tests.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2276 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 06:22:30 +00:00
David Huynh
3c6358d518 Fixed json tests.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2275 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 04:50:05 +00:00
Tom Morris
850e147779 Changes needed to get FixedWidthImporter test to pass
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2274 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-05 23:49:14 +00:00
Tom Morris
e064dcce3e Add support for getTempDir() as required by new importers
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2273 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-05 23:42:15 +00:00
Tom Morris
1b197d93d8 Issue 447 - allow users to specify delimiters for toTitlecase function
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2253 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-20 05:07:46 +00:00
Tom Morris
884d0ea8d4 Look up functions by name to make tests more directly analogous to user view
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2252 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-20 05:00:48 +00:00
Tom Morris
59d6020979 Add basic test coverage for ToTitleCase and (commented out) support for 2nd parameter
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2250 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-19 15:47:33 +00:00
Tom Morris
f309a26a95 Fix XML importer test to handle new exception being thrown
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2249 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-19 15:34:29 +00:00
David Huynh
90ad8247b7 Minor layout change in custom tabular exporter dialog from Thad's suggestion.
Fixed small compile error in main/tests/.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2226 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-30 21:21:46 +00:00
Tom Morris
da7347e7b1 Make sure all conditionals and loops are in blocks (too bug-prone otherwise)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2183 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 22:21:47 +00:00
Tom Morris
97a0f2a33e Organize imports. com.google.refine last in a section of its own. Everything alphabetical in its section.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2180 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 21:10:22 +00:00
Tom Morris
7fd6e22af4 Convert tabs to spaces. No functional changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2172 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 20:26:32 +00:00
Tom Morris
123614539d Add missing @Override annotations
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2171 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 19:30:23 +00:00
David Huynh
78edff6f7f Merged new importer UI work from branch over.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2170 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 03:34:47 +00:00
Tom Morris
d03c8a1f70 Issue 415: Add some tests for arithmetic expressions in GREL
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2122 7d457c2a-affb-35e4-300a-418c747d4874
2011-06-23 23:41:35 +00:00
Tom Morris
73acd497e9 Fix for issue 358 from Tomaz Solc. Don't return a NaN when comparing two 0-length word lists.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2088 7d457c2a-affb-35e4-300a-418c747d4874
2011-06-06 21:30:46 +00:00
Tom Morris
bbc2b3d363 Test provided by Gabriel Sjoberg. Thank you!
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2002 7d457c2a-affb-35e4-300a-418c747d4874
2011-02-04 20:09:01 +00:00
Tom Morris
3e08aca4ec Issue 304 - Apply patch to fix test. Thanks to GabrielS
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2001 7d457c2a-affb-35e4-300a-418c747d4874
2011-02-04 04:55:05 +00:00
David Huynh
6fb2b05739 Fixed issue 294: "Exporting date type column to TSV/CSV shows java debugging information instead of value" with help from Gabriel Sjoberg.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1967 7d457c2a-affb-35e4-300a-418c747d4874
2010-12-28 15:54:24 +00:00
Iain Sproat
2f564589f5 Adding a Fixed Width data importer (Issue 85) and associated tests.
Although this importer is 'wired up', it requires a property "fixed-column-widths" which is not (yet) implemented in the UI.  But the ImporterRegister.guessImporter method will probably select the CsvTsvImporter before the FixedWidthImporter anyway.  I suggest an improvement to the project creation UI and/or the guessImporter method will be required.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1857 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 13:15:41 +00:00
Iain Sproat
4f9dc38066 TsvCsvImporter now uses the CSV test methods to also test the TSV importer. Separate tests for the two importers are no longer required.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1856 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 13:06:39 +00:00
Iain Sproat
37a6f938c3 The TestNG DataProvider for the Tsv/Csv importer tests was previously providing just one test case with two parameters, rather than the two test cases of one parameter each which is required. This is now fixed, and the tests pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1855 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 10:52:18 +00:00
David Huynh
5a17acfd70 Prepended license text to java source
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1613 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-20 20:45:52 +00:00
Tom Morris
05d8180016 Disable failing test until it can be debugged
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1602 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-18 05:52:11 +00:00
Tom Morris
7dcd0c073d Revert bad commit r1600
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1601 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-18 05:19:05 +00:00
Tom Morris
79c00bab36 Incomplete - task 157: Integrate Google Spreadsheet import/export plugin
http://code.google.com/p/google-refine/issues/detail?id=157

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1600 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-18 04:59:39 +00:00
Tom Morris
c8bb6a3475 Fix failing template exporter test. Disable HTML exporter no column headers test (unimplemented)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1570 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 18:07:17 +00:00
Tom Morris
aba75a9b4a Add a couple more tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1568 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 17:10:07 +00:00
Tom Morris
87b6d940b7 Some very basic tests for exporters with no test coverage
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1567 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 15:50:25 +00:00
Tom Morris
0041863a13 Placeholder (failing) tests for exporters with no test coverage
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1566 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 13:27:44 +00:00
David Huynh
73042712ed Made csv/tsv importer not trim whitespace even if "guess cells' types" is checked (for cells that are strings).
Updated csv tests to expect un-trimmed cells.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1557 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-15 05:30:15 +00:00
Iain Sproat
d977f42f51 Changed behaviour of the XmlImporter to make it more permissive, and allow arrays within mixed elements to be used as candidates for importing to Refine.
This change has also allowed the JsonImporter to pass all its unit tests without any further modification.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1425 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 18:33:59 +00:00
Iain Sproat
ec0581e3a9 Added two additional unit tests for ensuring the XmlImporter is behaving correctly.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1424 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 17:32:27 +00:00
Iain Sproat
8d51223610 An additional unit test for the JsonImporter, which it unfortunately fails.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1423 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 15:19:29 +00:00
Iain Sproat
ec9898ba92 Some tidying up of the XmlImporter which reduces the number of generic TreeParser tokens to a minimum - and should allow elements such as comments and CDATA to be ignored/skipped.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1422 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 15:02:09 +00:00
Iain Sproat
d3f223c196 The JsonImporter now passes all current unit tests.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1421 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-04 10:02:50 +00:00
Iain Sproat
2d47885182 Tests in ProjectManagerTests.java and RefineServletTests.java have had minor fixes to update them to the current code.
doPostRegressionTest() still fails when run in the suite, but passes when run as an isolated test - there appears to be some cross-contamination from tests that I can't figure out atm.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1418 7d457c2a-affb-35e4-300a-418c747d4874
2010-10-01 11:53:27 +00:00
Iain Sproat
d285999da8 New JsonImporter, JsonParser and JsonImporterTests (copy of XmlImporterTests with syntax of the example data altered for Json).
Renaming of TreeImporter to TreeImportUtilities (as per the current convention with the XmlImporter and XmlImportUtilities).

NB the new JsonParser class does not work, and 5 of the new unit tests for JsonImporter currently fail.  To be fixed in due course.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1361 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-27 22:53:17 +00:00
Iain Sproat
e5ddfa6fdc All methods in XmlImportUtilities now use the TreeParser interface.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1323 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-27 17:59:53 +00:00
Iain Sproat
d71c563831 XmlImportUtilities.detectPathFromTag and XmlImportUtilities.detectRecordElement methods now use a generic TreeParser interface. A lightweight wrapper XmlParser wraps XMLStreamReader to provide parsing for xml data.
This is another small step towards a generic importer for tree structured data.  My plan is to refactor more of XmlImportUtilities' methods to use the TreeParser interface so that XmlStreamReader is no longer called directly from XmlImportUtilities.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1322 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-27 17:40:51 +00:00
Iain Sproat
1bda46d40f Methods which are generic to any tree structured data and don't rely on an XmlParser have been moved to a new TreeImporter class. This is a small step towards supporting importers for other tree structured data.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1321 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-27 16:09:44 +00:00
Iain Sproat
2df0d1ac3a Eclipse .launch file for tests now correctly points to project 'grefine' rather than incorrect 'refine'.
XmlImport tests now pass - the tests themselves were not testing the current xml being input to them.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1320 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-27 14:47:06 +00:00
David Huynh
d15fe661fa Renamed in client-side code. Refine should start and existing projects should still work.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1293 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-22 22:55:28 +00:00
David Huynh
1367ce301e More renaming, except for: client-side code, build scripts, anything to do with data loading and QA, workspace path. Refine can still run, and undo/redo on existing projects is working.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1290 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-22 18:36:33 +00:00
David Huynh
e6bc603a11 Renamed Java classes whose names contain 'Gridworks'. Refine is still able to start. But don't check out the code just yet.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1289 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-22 17:46:39 +00:00
David Huynh
edb23eb263 Changed Java packages com.google.gridworks.* to com.google.refine.* and modified other code just enough to start grefine up without error. Much remains to be done. Do not check out the code just yet.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1288 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-22 17:04:10 +00:00
David Huynh
2609c4049d Fixed issue 114: "Refactor project manager api to allow importers to create project metadata" by incorporating tfmorris' patch.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1271 7d457c2a-affb-35e4-300a-418c747d4874
2010-09-17 01:00:23 +00:00
David Huynh
367796488e Fixed xml importer: subgroups should now line up properly by rows.
Added command to reorder columns using drag and drop.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1227 7d457c2a-affb-35e4-300a-418c747d4874
2010-08-25 06:17:08 +00:00
David Huynh
c94abd0427 Commands are now registered in association with their modules, so to avoid name collision.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1193 7d457c2a-affb-35e4-300a-418c747d4874
2010-08-22 06:16:13 +00:00
David Huynh
dcc3ac8534 Renamed packages com.metaweb.* to com.google.*.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1130 7d457c2a-affb-35e4-300a-418c747d4874
2010-08-03 23:01:18 +00:00
Iain Sproat
0d7b3b0e9c ProjectManager is now partially unit tested.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1015 7d457c2a-affb-35e4-300a-418c747d4874
2010-06-21 19:57:31 +00:00
Iain Sproat
7ced0cb31e New feature for importing text files (CSV and TSV). By selecting the checkbox in index.html it allows the effects of quotation marks around data values to be ignored.
Unit test added for this.

This has required a further branch to opencsv - patch sent to opencsv project and can be tracked at  https://sourceforge.net/tracker/?func=detail&aid=3018599&group_id=148905&atid=773543

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1010 7d457c2a-affb-35e4-300a-418c747d4874
2010-06-20 14:47:45 +00:00
Iain Sproat
846cf1d57e Fixed bug in CsvExporter, all unit tests for CsvExporter and TsvExporter now working.
History now has the beginnings of a unit test.

Additional source documentation on public methods in ProjectManager and History.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@989 7d457c2a-affb-35e4-300a-418c747d4874
2010-06-17 15:37:28 +00:00
Iain Sproat
a671551289 Two more XmlImport tests now work. Some documentation stubs were added to XmlImporterUtilities.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@967 7d457c2a-affb-35e4-300a-418c747d4874
2010-06-15 16:22:53 +00:00
Stefano Mazzocchi
ef6f03694d make all tests pass
git-svn-id: http://google-refine.googlecode.com/svn/trunk@945 7d457c2a-affb-35e4-300a-418c747d4874
2010-06-05 01:30:12 +00:00
Stefano Mazzocchi
82d3730568 no need for this anymore
git-svn-id: http://google-refine.googlecode.com/svn/trunk@927 7d457c2a-affb-35e4-300a-418c747d4874
2010-06-01 06:56:54 +00:00
Stefano Mazzocchi
fe004d5fa6 fixed client tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@926 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-31 17:56:07 +00:00
Stefano Mazzocchi
7ce78776c6 refactored tests to avoid using static initialization which conflicts with our ability to have special log4j configurati
ons for testings. Also tagged all broken tests as broken so that the tree is now green. Also used the test class as the
logger name so that it's easier to groupt the logger verbosity based on java packages.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@922 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-31 08:51:51 +00:00
Stefano Mazzocchi
e3fc7ab603 bringing the refactor branch up to speed with trunk
(everything works like in trunk for now, although some tests still fail)


git-svn-id: http://google-refine.googlecode.com/svn/branches/split-refactor@915 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-30 18:18:59 +00:00
Stefano Mazzocchi
8369961b9e renaming tests
git-svn-id: http://google-refine.googlecode.com/svn/branches/split-refactor@907 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-30 16:56:53 +00:00
Stefano Mazzocchi
aa4de48f95 some renaming, moving tests into main
git-svn-id: http://google-refine.googlecode.com/svn/branches/split-refactor@906 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-30 16:55:53 +00:00