s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
732 Commits 6 Branches 0 Tags 1.3 GiB
76cb65bfb8
Commit Graph

63 Commits

Author SHA1 Message Date
Iain Sproat
76cb65bfb8 Removed unnecessary files following refactor of TsvExporter and TsvCsvImporter. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@859 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-25 16:50:44 +00:00
Iain Sproat
2f3980f969 CsvExporter allows the separator character in its output to be modified. 
ExportRowsCommand has replaced TsvExporter with CsvExporter with a tab character as the separator.
TsvExporterTests now tests CsvExporter with a tab character as the separator parameter.  All unit tests now work.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@858 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-25 16:39:25 +00:00
Iain Sproat
6779707399 CsvExporter uses columnIndex when accessing cells. Feature added to omit column header from first line of exported CSV. CsvExporterTests tests for this new feature. 
The same unit test is available in TsvExporterTests.  Test is broken, and marked as such.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@857 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-25 16:00:03 +00:00
Iain Sproat
3ac3feb01f opencsv-2.2.jar patched so that CsvWriter only selectively applies quotation marks around values when escape, line break, nested quotation marks or separator characters are encountered. Patch submitted to opencsv project as https://sourceforge.net/tracker/?func=detail&aid=3006635&group_id=148905&atid=773543 
CsvExporter makes use of patched opencsv-2.2.jar. Quotation marks are only applied selectively.

CsvExporterTests fixed to correctly assign cellIndex when creating columns.

TsvExporterTests fixed to correctly assign cellIndex when creating columns.  Two broken tests now work.  Three tests are still marked as broken.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@851 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-24 22:01:37 +00:00
Iain Sproat
433a047fb6 Added tests for TsvExporter - all are broken (may be the tests themselves, as they are copied from CsvExporterTests). 
CsvExporter now closes writer.  CsvExporterTests includes test for a string with a comma.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@847 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-24 18:37:52 +00:00
Iain Sproat
015b5a92ae CsvExporter is linked to the UI, and should fully work. Unit Tests now assert that null cells can be handled by CsvExporter. CHANGES.txt is now updated to reflect Issue 59. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@845 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-24 12:36:35 +00:00
Iain Sproat
53e20da8f4 Issue 59 (part) - added CsvExporter and unit test to server side code. Not linked to UI. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@844 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-24 12:15:45 +00:00
Iain Sproat
ec7ac81246 Applying Tom Morris's patch to GridworksServlet.(issue #48). GridworksServlet creates classes from a string, so is no longer dependent on (imports) any of the Command Classes. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@821 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-19 07:09:40 +00:00
David Huynh
1e737e3238 Factored row dependency code from Row class and Project class out as Record and RecordModel classes. 
Simplified RdfTripleImporter.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@820 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-19 04:22:45 +00:00
Iain Sproat
0e4682f453 RdfTripleImporter handles row dependencies. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@818 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-18 21:08:37 +00:00
Iain Sproat
cfd0f2219e RdfTripleImporter does basic reconciliation on Rdf subject - data model is no longer sparse (now possible to have more than one data point per row) 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@816 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-18 13:48:52 +00:00
Iain Sproat
043f46c562 RdfTripleImporter correctly adds empty cells to existing rows when a column is added. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@815 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-18 13:04:51 +00:00
Iain Sproat
25d3a9dfc1 Added a basic RDF triple importer plus unit tests. Some more work required - it's not plugged into the client and it creates a very sparse data structure (each triple is a new row). It uses JRDF library (Apache 1.1 license). 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@813 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-18 12:41:40 +00:00
Iain Sproat
092d4602b9 TsvCsvImporter passes all unit tests. TsvCsvImporter again uses opencsv library. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@797 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 11:57:26 +00:00
Iain Sproat
648e7ee5fa 'broken' exclusion test group added to tests.xml configuration file. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@796 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 10:19:19 +00:00
Iain Sproat
fcdb926e94 TsvCsvImporterTests tests are parameterized, so that both TsvCsvRowParser and SeparatorRowParser are both tested without writing additional tests. 
Removed enabled=false as the ./gridworks file should exclude group 'broken', the indicator for failing tests.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@795 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 10:12:21 +00:00
Iain Sproat
7886016dd1 Test added to TsvCsvImporterTests for multiple blank lines in quoted CSV value, see issue #19. Test does not pass, so is enabled=false and grouped as 'broken'. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@794 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 07:03:19 +00:00
Iain Sproat
075e985865 Rename CSVRowParserTests to TsvCsvRowParserTests. 
TsvCsvImporterTests - identified 3 tests which now fail when using different parser.  Tests are enabled=false and in 'broken' testing group.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@793 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 06:50:30 +00:00
Iain Sproat
03b1ab01f4 RowParser is no longer a parameter of read method in TsvCsvImporter (now handled in the method itself) 
CSVRowParserTests is now tidied - with expected and actual being input into the correct parameters of Assert.assertEquals.  One more test passes, but still 2 tests failing.


git-svn-id: http://google-refine.googlecode.com/svn/trunk@792 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 06:24:58 +00:00
David Huynh
71b08ebdd9 Added TSV test file for issue 19. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@791 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 05:55:43 +00:00
David Huynh
bd8d214a49 Resolved issue 19 for TSV as well, not just for CSV. 
Touched up TsvCsvImporterTests to leave the comma vs. tab guessing to the importer itself. All tests still pass.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@790 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 05:55:02 +00:00
Iain Sproat
6f74bcaa26 comments tidied in TsvCsvImporterTests and ImporterUtilities 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@789 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 05:40:46 +00:00
David Huynh
68fbd3320b Got disabled tests in Issue 41 to pass. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@788 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 05:26:29 +00:00
Iain Sproat
22fb3a1585 fixing issue introduced in r782. - importer now autodetects separator correctly. 
Uses original CSV parser, but 4no tests do not pass (ignored with enabled=false flag).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@787 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 03:22:22 +00:00
David Huynh
590358ca63 More new commands.* packages for better organization of commands. More re-organization of commands. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@785 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-17 02:24:45 +00:00
Stefano Mazzocchi
f28e23e503 Committing patches by Iain: 
- use OpenCSV parser instead of our own
 - use TestNG instead of JUnit which is a lot more configurable in test selection (and allows us to do a much better job a leaving the tree green even while developing tests that are known to fail)
 - integrated TestNG in './gridworks test'
 - added Iain to the list of contributors in README.txt
 - changed the Eclipse test launch file to use the TestNG launcher (unfortunately, this is not shipped by default in Eclipse, so you have to install it yourself from the http://beust.com/eclipse update file, I'll add this to the wiki shortly)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@782 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-16 18:42:52 +00:00
Stefano Mazzocchi
828acfc694 better way to ignore tests 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@780 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-15 03:12:23 +00:00
Stefano Mazzocchi
9f1358ea38 comment out tests that don't pass 
(leaving the tree in a broken state is a nono)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@778 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-15 02:45:54 +00:00
Iain Sproat
9b2aa5290c split method of CSVRowParserTests is now unit tested. 3 tests fail (related to issue #19) - behaviour of CSV importer needs some further work. 
logger now correct on GridworksServletTests


git-svn-id: http://google-refine.googlecode.com/svn/trunk@777 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-14 22:34:50 +00:00
Iain Sproat
624b421da9 doGet and doPost methods of GridworksServlet now unit tested. @Ignore attribute added to GridworksServletStub to prevent ./gridworks server_test failing. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@769 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-14 17:34:40 +00:00
Iain Sproat
0af4e294f8 GridworksServlet is now unit tested with a single regression test 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@765 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-14 14:57:04 +00:00
Iain Sproat
a096fae7a0 ParsingUtilities.evaluateJsonStringToObject is now unit tested 
CommandTests and CancelProcessesCommandTests are slightly formatted to match code standards.
Command and CancelProcessesCommand are slightly tweaked to pass under all unit tests.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@753 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-13 09:23:37 +00:00
Stefano Mazzocchi
5070de6446 committing Iain's new tests and polished things a little 
(also added a test-specific log4j conf so that we don't show all the warnings during the tests that were distracting)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@744 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-13 00:54:02 +00:00
Stefano Mazzocchi
11da70d223 Applying patch for Issue 21 from iainsproat 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@722 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-12 08:59:05 +00:00
David Huynh
59ab6c0a78 Added a CSV file to test fix to issue 19. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@718 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-12 06:09:34 +00:00
Stefano Mazzocchi
668b763f6b introducing a wrapper around windmill-js that adds support for macros in order to make it easier to make gridworks-specific UI testing a lot more compact (this is a tiny bit more verbose than the previuos method, but it allows us to group waits with actions and assertions which wasn't possible before, so it's a good price to pay). 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@709 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-11 17:17:34 +00:00
Jeff Fry
3d59ba713e minor edits. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@706 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-11 00:46:44 +00:00
Jeff Fry
938bcfe7b0 added waits to get additional asserts to succeed. working on numeric filter 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@705 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-11 00:45:05 +00:00
Jeff Fry
f7151cdbaa Added additional facet tests. Work in progress commented out as TODO 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@621 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-08 01:06:36 +00:00
Stefano Mazzocchi
5d6fa58258 setting the right EOL subversion settings 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@607 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-06 01:05:48 +00:00
Stefano Mazzocchi
cc1b0a8974 much less verbose js testing 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@606 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-06 00:06:39 +00:00
Stefano Mazzocchi
7d63fc2f6f fixing tests 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@605 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-05 02:23:23 +00:00
Jeff Fry
1582836dca Reworked in as functions instead of an array of commands 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@598 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-05 00:43:20 +00:00
Stefano Mazzocchi
18075eb3ee detab + dedos for js files (no functional changes) 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@592 7d457c2a-affb-35e4-300a-418c747d4874
 2010-05-04 23:17:09 +00:00
Stefano Mazzocchi
7f6398c254 switched to javascript tests 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@574 7d457c2a-affb-35e4-300a-418c747d4874
 2010-04-30 17:20:01 +00:00
Jeff Fry
0ad08d49cc Remove basic.js , add initial JS test. Currently does little, but it works. More to come, now that I'm more up to speed at Windmill's JS library, and JS in general... 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@505 7d457c2a-affb-35e4-300a-418c747d4874
 2010-04-20 00:48:03 +00:00
Stefano Mazzocchi
f0ba42f355 make sure to check the tests as well 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@431 7d457c2a-affb-35e4-300a-418c747d4874
 2010-04-09 00:23:14 +00:00
Stefano Mazzocchi
135f870061 - adding interactive test mode so one can use the Windmill IDE to make tests 
(use ./gridworks test interactive)
- split the windmill tests between python and js
(the js one is just a silly test, waiting for Jeff to fill it up with more meaty stuff)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@418 7d457c2a-affb-35e4-300a-418c747d4874
 2010-04-07 22:56:46 +00:00
Stefano Mazzocchi
6dbe794658 enabled windmill-based UI testing (type ./gridworks test to try) 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@406 7d457c2a-affb-35e4-300a-418c747d4874
 2010-04-07 08:28:53 +00:00
Jeff Fry
341a8d3f8f Initial Windmill tests for Gridworks: text facet, split values, numeric facet. Some asserts but likely want more. 
git-svn-id: http://google-refine.googlecode.com/svn/trunk@404 7d457c2a-affb-35e4-300a-418c747d4874
 2010-04-07 00:48:00 +00:00