Commit Graph

139 Commits

Author SHA1 Message Date
Antonin Delpeuch
9919ee51bf
Respect spaces in clustering dialog. Closes #4004. (#4005) 2021-06-27 16:14:22 +02:00
Akshita Singh
d269a5ea4d
Common transforms on multiple columns (#3789)
Closes #1843.
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-04-26 11:33:23 +02:00
Matthieu Jonglez
c19aa3546f
Fixes #3809. Enables cross-origin property type-ahead. (#3810) 2021-04-14 22:04:14 +02:00
gitonthescene
50a905e9da
Property suggestion for data extension should try CORS first. 'suggest' key is optional in service manifest (#3710)
Co-authored-by: Douglas Mennella <douglas.mennella@gmail.com>
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-03-12 11:47:22 +01:00
Akshita Singh
ad22c7709a
Add link to GREL reference in Help tab of expression editor (#3647)
* grel reference added

* descriptive link added

* modified

* translation text added

* conflict issue resolved and link added

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-02-24 14:37:47 +01:00
sarahelshabrawy
cf58dc4cdc
Enable hyperlinks in in-tool Help field (#3648) 2021-02-20 12:56:39 +01:00
Mo-hamdy2000
6c47c81e59
fix: Expression window resize (#3587)
* fix: Expression window resize

* fix: Expression window resize

* fix: Expression window resize

hard-coded value removed

* fix: Expression window resize

- adding column dialog fixed
- default width is preserved

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-02-20 11:36:06 +01:00
rachittiwari8562
c9ceb9ef47
fixes-issue-#3362 (#3375) 2021-01-13 19:48:18 +01:00
Cameron Bedard
c6b6616f01
Added confirm dialog for starred expression remove links #501 (#3436)
* Updated 'remove' link for starred expressions to include a confirm dialog

* bring remove expression dialog dismissal inline with other dialog dismissal

* Changed 'unstar expression?' in translation-en.json to allow better translation.

* Update main/webapp/modules/core/langs/translation-en.json

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-01-02 09:46:24 +01:00
rachittiwari8562
8740d1bcba
Fix UI of scatterplot-facet and dialog - fixes #3228 (#3338) 2020-11-28 20:16:23 -05:00
Tom Morris
5eff85b76c
Update jQuery UI to 1.12 - fixes #3001 (#3010)
* Update jQuery UI from 1.10.3 to 1.12.1 and associated theme CSS

* Fix sidebar tab layout issue with new jQuery UI

* Update initialization jQuery UI Tabs widgets

selected is now active, but the first tab is selected by default
so we don't need to do it manually.

* Patch GData initialization error

Don't attempt to initialize if we get no docs back (ie unauthorized)
2020-08-17 14:49:56 +02:00
Tom Morris
6095c44cb7
Update to jQuery 1.12.4 and jQuery Migrate 1.4.1 - fixes 2932 (#2933)
* Refactor module wiring to reduce redundancy

* Update to jQuery 1.12.4 & jQuery Migrate 1.4.1 - fixes #2932

This updates to the latest jQuery 1.x and jQuery Migrate 1.x,
the first step in upgrading to a modern jQuery.

* Add a couple of bug fixes from Google Code SVN

This is an unrelease version from the Google Code freebase-site
repo which only has a few changes from the v4.3 release, but
one of them is removing the `browser.msie` reference that
jQuery Migrate is complaining about.

* Use prop() for 'checked' and 'disabled'

* Update jQuery 'value' property setting code to use val()

* Use prop() instead of attr() to set 'selected'

* Patch for jQuery >1.9
2020-08-06 13:47:31 +02:00
Tom Morris
05fb4e355f
Replace Javascript string concatenation with i18n parameters - addresses #1858 (#3019)
* Replace js string concatenation with i18n parameters

refs #1858
Remove Javascript string concatentation and use jquery i18n()
instead so that translators have the needed context and
flexibility to be able to do a good job. Also remove code-based
plurals conditionalization and replace with i18n.

* Update French translation so I can test non-English support

* Add missing localization

* Clean up formatting of service API link
2020-08-04 10:10:38 +02:00
Tom Morris
0ebd89c952
Clustering dialog choices limit & performance improvements - fixes #695 (#2996)
* Clustering dialog choices limit & performance improvements - fixes #695

Fixes #695
- Caps the total number of choices displayed at 10,000 and warns when
  over the limit. Users can use facets to tune which clusters are displayed.
- Doubles the performance of the Javascript processing
- Only displays count of rows for a choice if it's > 1 to DOM elements
- Adds internationalization for row count

For 41K clusters containing 118K choices, processing dropped from
3m20s to 1m20s, but with the 10K choice cap total time is ~10sec.

* Restore even/odd row class

* Updates from review feedback
2020-08-01 10:59:41 +02:00
Tom Morris
5985f95ce1
Explicitly set SameSite=Lax on cookie - fixes #3007 (#3014) 2020-08-01 10:58:16 +02:00
Tom Morris
f88c0e3657
Preserve international characters in project/file names on import/export (#2720)
* Preserve international characters on import/export

Fixes #1352. Preserve non-ASCII characters in project names on
project creation and filenames on export.

Uses existing filename cleaner with the addition of a few
more characters from StackOverflow, plus "#" which messes
up the download URL. Also URIencode download URL.

Removes unused I18N-incompatible cleaning function from
Wikidata extension rather than fixing it.

* Use common name cleaner function

Also preview cleaned table name instead of raw name, so user can see it.
Also add a TODO for better preview of column names
2020-06-18 22:06:46 +02:00
Tom Morris
5f368bc56d
Use ContentDisposition instead of ContentType to control download (#2722)
* Use ContentDisposition instead of ContentType to control download

Fixes #1197. Previously we were using a funky ContentType to attempt
to force a file download rather than display in browser, but this
conflicted with attempts to save UTF-8 which was outside the Basic
Multilingual Plane (BMP).

By switching to ContentDisposition: attachment, which has been
the preferred method for a number of years, we can avoid this conflict.

As part of this, switch to using the "preview" param consistently
to control preview vs download rather than the content type.

* Switch content type to text/plain

Now that we don't need to use ContentType to control download
behavior, we can use something more reasonable.
2020-06-16 15:46:07 +02:00
Tom Morris
03c860d961
Update jquery.i18n to 1.07 and fix non-English plural support (#2717)
* Update jquery.i18n to 1.07 and add missing rule parser

Fixes #2700
Adds missing CLDRPluralRuleParser.js so that plurals are supported.
Updates all files to jquery.i18n 1.07
Includes a bunch of specialty language support,
but only Finnish and Russian are loaded as examples.

* Add some missing translations, including plurals

Fix some cases of Javascript string concatenation and
plural conditionalization to demonstrate that plurals work
in both English and French now.

NOTE: Corresponding updates need to be made to all the other
language files since some keys were renamed or eliminated.
2020-06-14 10:23:23 +02:00
darecoder1999
d91503f7c7 Disables FacetContainer while computing clusters
fixes #2675
2020-06-13 00:19:26 +05:30
Albin Larsson
1bbf3df0f3
CustomTabularExporterDialog: fix checkbox options being ignored (#2429)
Any value (even an empty string) of the checked attribute will be threated as checked. Fixed by passing null to jQuerys attr function which removes the attribute.
https://stackoverflow.com/questions/4228658/what-values-for-checked-and-selected-are-false
2020-03-18 04:54:04 +00:00
Albin Larsson
4ba75034cb
Custom Tabular Exporter: add option to quote all strings #1869 (#2427) 2020-03-17 18:01:37 +00:00
Antonin Delpeuch
9356b846b6
Merge pull request #2339 from lisa761/modal-dialogs
Closes dialogs when escape key is pressed
2020-03-01 11:33:43 +00:00
Lisa Chandra
e563885de1 moved escapeKey handler to global scope (to prevent only said handler from executing when a dialog is closed) 2020-02-29 22:16:29 +05:30
Lisa Chandra
07149d4083 removed closing of dialog box on an outside click and moved escape key logic to dialog.js 2020-02-28 18:40:15 +05:30
Lisa Chandra
ad017434dc closes reorder/remove dialog when a click is made outside or when escape key is presses 2020-02-28 01:54:16 +05:30
Lisa Chandra
512aac8143 closes sql exporter dialog box when a click is made outside the dialog box or when escape key is pressed 2020-02-27 22:18:38 +05:30
Lisa Chandra
2de7015645 closes templating export dialog when a click is made outside the dialog box or when escape key is pressed 2020-02-27 21:42:11 +05:30
Lisa Chandra
7e86197339 closes custom export tab when a click is made outside the tab or when escape key is pressed 2020-02-27 21:26:07 +05:30
Lisa Chandra
91058de64f closes cluster dialog when a click is made outside the dialog box and when escape key is pressed 2020-02-27 18:59:16 +05:30
kushthedude
f56dc3e012 fix: cannot export a file if blank tab opened is not closed
Signed-off-by: kushthedude <kushthedude@gmail.com>
2020-02-23 21:55:37 +05:30
Antonin Delpeuch
3559eeb11f CSRF protection for project and recon commands 2019-10-15 12:07:12 +01:00
Antonin Delpeuch
91cead27f8 CSRF protection for ImportingController 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
70e37b9085 Add CSRF protection to cell, history, column and expr commands 2019-10-14 16:24:26 +01:00
Michael
695ef94b50 #1970 Disable spell check for expressions. 2019-10-12 16:51:04 +02:00
Fabian Steeg
84af07506d Prefer view.url pattern for data extension preview links
See https://github.com/OpenRefine/OpenRefine/issues/2177
2019-10-04 14:55:34 +02:00
Thad Guidry
94fa0c2189 remove mention of recon on help 2019-07-23 22:36:32 -05:00
Thad Guidry
afce62fcd3
[WIP] Add recon and record to Help tab 2019-07-20 14:52:21 -05:00
Antonin Delpeuch
22cf0517b9 Better fallback for non-localized keyers and distances 2018-12-11 12:16:58 +00:00
Antonin Delpeuch
a57082ef3e Hook the new command to the UI to expose all clusterers 2018-12-11 11:59:37 +00:00
Antonin Delpeuch
7dd4db1ca1 Fix i18n calls after migration 2018-11-28 23:22:38 +09:00
Owen Stephens
3052155c0a Fix on screen text in Transform All columns dialog 2018-11-22 11:39:29 +00:00
Antonin Delpeuch
10931e1e4d Migrate js to new localization syntax 2018-11-21 17:30:00 +00:00
Antonin Delpeuch
b46c5a7b4e Flatten remaining messages 2018-11-21 17:26:53 +00:00
Antonin Delpeuch
9bf0bb2154 Merge JS i18n strings with slash 2018-11-21 15:24:57 +00:00
Antonin Delpeuch
4298e13f02 Change title of column selection dialog for transform all operation 2018-09-13 11:29:21 +01:00
Antonin Delpeuch
8ea6f6e251 Fix mixup of dialog titles, closes #1657. 2018-09-13 11:01:27 +01:00
Jacky
a103e1fb90 merge the translation 2018-05-16 15:40:05 -04:00
TonyO
0eb7b4082f added null and default value options 2018-04-26 20:50:46 -05:00
TonyO
c7c0d8884a check empty cells 2018-04-22 00:39:11 -05:00
TonyO
223d16db39 added ignore facet and trim column name options 2018-03-25 21:01:53 -05:00