Commit Graph

96 Commits

Author SHA1 Message Date
Jathin Sreenivas
f5b35a99b3
#3186 : Wikibase login form shows Wikibase instance logo (#3702)
* #3186 : Wikibase login form shows Wikibase instance logo

* Logos shown in the UI during selection of instance to work against

* CSS for list of instances, error handling

* Cache wikibase logo urls.

* Replacing logo alt text as translation string and removing the duplicate property

* Replacing logo alt text as translation string and removing the duplicate property

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-04-20 21:05:50 +02:00
Antonin Delpeuch
fa9d670d30
Remove EditGroups URL template from Wikibase schema (#3779)
* Remove EditGroups URL template from Wikibase schema

Instead it is fetched from the manifest and stored in operation metadata.

Closes #3656.

* Fix compatibility with older JDKs

* Remove unnecessary fallback in ManifestV1 constructor
2021-04-01 13:58:28 +02:00
Lu Liu
79eac0b811
Wikidata extension - discourage use of main password (#3190)
* encourage using bot passwords

* update wiki link

* update translation

* Update extensions/wikidata/module/langs/translation-en.json

Co-authored-by: Tom Morris <tfmorris@gmail.com>

Co-authored-by: Tom Morris <tfmorris@gmail.com>
2020-09-30 10:31:36 -04:00
Lu Liu
7d4e182c75
Extend Wikidata extension to support arbitrary Wikibase instances (#2810)
Closes #1640. All Wikibase-dependent parameters, which were previously hard-coded for Wikidata, are now described in a JSON manifest. The manifest is currently constructed by hand, but, in the future, will hopefully be published by each Wikibase instance at a standard location.

* setup the manifest framework

* add dependency mechanism to scrutinizers & update tests

* add json creators to constraint entities

* adapt the backend (units tests are to be updated)

* remove the call to prepareDependencies() in the constructor

* update code according to review feedback

* update scrutinizers tests

* fix typo & update ConstraintsV1

* log if a scrutinizer is skipped

* update versioning handling in the backend

* correct the order of "actual" and "expected" for assertEquals method

* use regex to check manifest versions

* 1. add wikibase-manager.js, wikibase-dialog.js, etc.
2. move dialog/schema-alignment-dialog.js -> schema-alignment.js
3. remove unused schema-alignment-dialog.html
4. change most mentions of "Wikidata" to "Wikibase"

* support saving cookies for different Wikibases & fix LoginCommandTest

* fix schema related tests

* removed unused WikibaseCredentials

* include MediaWiki API endpoint in the schema

* fetch language codes for different Wikibases

* fix lgtm-bot alerts

* keep a connection map (MediaWiki API endpoint => Connection) in ConnectionManager

* simplify the constraint configurations of the manifest and remove lots of unnecessary code.

* add slash to the end of mediawiki.root

* add manifest schema and use ajv to validate the manifest

* remove JSONP support (Wikibase manifest host should support CORS)

* save manifests on manifest update

* add unit tests for Manifest

* include the exception in logger.error() method to make it easier to debug

* include the message of ManifestException when calling respondError

* test multiple connections

* test no manifest & test invalid manifest

* adapt manage-account-dialog.js to support multiple Wikibase connections

* update instance/subclass of related translations

* beautify import-schema-dialog.html

* use "${lang}" variable in the reconciliation service endpoint of the manifest

* adapt schema-alignment.js after introducing "${lang}" variable in the reconciliation service endpoint

* use WikibaseManager.getSelectedWikibaseApi() in SchemaAlignment._getPropertyType

* replace more mentions of "Wikidata" to "Wikibase"

* use WikibaseManager.getSelectedWikibaseApi() in previewrenderer.js

* support fetching language codes of different Wikibases in the frontend

* skip EditInspector if missing 'property_constraint_pid' in the manifest

* improve unit tests for fetching lang codes

* skip scrutinizers depending on fetcher if 'property_constraint_pid' is missing in the manifest

* make sure the schema alignment panel is set up before rendering

* fix preview bug

* add getters of "instance of" and "subclass of" to the Manifest interface and use them in NewItemScrutinizer

* fix hardcode for Wikidata in WbItemVariable

* rename 'entity_prefix' to 'site_iri' and move it from 'manifest.wikibase.properties' to 'manifest.wikibase'

* include oauth configurations in the manifest & support logging in with owner-only consumer for Wikibases with the OAuth extension

* correct schema fallback logic

* select default wikibase according to the saved schema

* include maxlag in the manifest

* [backend] move maxlag setting from preferences to request parameter

* support setting maxlag when uploading edits

* rename "Manage Wikibase" to "Select Wikibase instance" and localize it

* fix manifest updating bug

* include EditGroups in the manifest

* add the reconciliation service from the manifest to standard services if it's not present yet when adding a new manifest

* update according to review feedback

1. use inherited color variable
2. rename 'gridwroks' to 'openrefine'
3. remove unnecessary 'async: true'
4. add 'format: url' validation to urls to the schema

* rename 'wikibasePrefix' to 'siteIri'
2020-08-22 11:58:56 -04:00
Antonin Delpeuch
68404abe2a
Fix race condition in service manifest fetching (#2872)
* Fix race condition in service manifest fetching. Fixes #2803

* Set own recon endpoint for Wikidata extension
2020-08-21 07:15:02 +02:00
Tom Morris
6095c44cb7
Update to jQuery 1.12.4 and jQuery Migrate 1.4.1 - fixes 2932 (#2933)
* Refactor module wiring to reduce redundancy

* Update to jQuery 1.12.4 & jQuery Migrate 1.4.1 - fixes #2932

This updates to the latest jQuery 1.x and jQuery Migrate 1.x,
the first step in upgrading to a modern jQuery.

* Add a couple of bug fixes from Google Code SVN

This is an unrelease version from the Google Code freebase-site
repo which only has a few changes from the v4.3 release, but
one of them is removing the `browser.msie` reference that
jQuery Migrate is complaining about.

* Use prop() for 'checked' and 'disabled'

* Update jQuery 'value' property setting code to use val()

* Use prop() instead of attr() to set 'selected'

* Patch for jQuery >1.9
2020-08-06 13:47:31 +02:00
afkbrb
cdb02004fd improve frontend 2020-06-18 23:51:22 -04:00
Lu Liu
335e81a26c OAuth support for the Wikidata extension (#2661)
Closes #1612 

Merges @afkbrb work to finish @wetneb protype, including:
* adding support for OAuth in addition to basic auth
* supporting registration of single user Wikidata OAuth consumers.
* adding extensive tests
* cleaning up the login dialog

This depends on the next release of the Wikidata Toolkit, but we're currently publishing our own snapshot that includes the necessary changes (thanks @wetneb!)

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2020-06-18 23:51:22 -04:00
Tom Morris
f88c0e3657
Preserve international characters in project/file names on import/export (#2720)
* Preserve international characters on import/export

Fixes #1352. Preserve non-ASCII characters in project names on
project creation and filenames on export.

Uses existing filename cleaner with the addition of a few
more characters from StackOverflow, plus "#" which messes
up the download URL. Also URIencode download URL.

Removes unused I18N-incompatible cleaning function from
Wikidata extension rather than fixing it.

* Use common name cleaner function

Also preview cleaned table name instead of raw name, so user can see it.
Also add a TODO for better preview of column names
2020-06-18 22:06:46 +02:00
Antonin Delpeuch
6441a2a1f6
Fix Enter key behaviour in Wikidata login form. Closes #2565 (#2566) 2020-04-26 15:39:10 +02:00
Antoine Beaubien
da5bdcfdad
Update perform-edits-dialog.js to trap [RETURN] in editSummary and proceed to action (#2550)
* Update perform-edits-dialog.js

Adding PerformEditsDialog.doFormSubmit() to share with keypress() [RETURN] from editField and « Edit Uploads ».

* var doFormSubmit = function()…

Change PerformEditsDialog.doFormSubmit to  var doFormSubmit = function()

* Update perform-edits-dialog.js

Convert [TAB] to 2x [SPACE].

* Update perform-edits-dialog.js

Move evt.preventDefault(); to where it belongs.

* Update perform-edits-dialog.js

Spacing corrections.

* Update perform-edits-dialog.js

Spacing corrections.
2020-04-20 09:16:06 +02:00
zengchu2
8b94b142cb
Enable auto complete in chrome (#2387)
Co-authored-by: zengchu2 <1450834797z@gmail.com>
2020-03-11 09:49:04 +00:00
Antonin Delpeuch
1046c38727 Fix Wikidata login form, closes #2194 2020-01-06 11:40:02 +01:00
Antonin Delpeuch
8ceaeb0743 Use jQuery.submit to bind form to login 2019-12-22 23:40:57 +01:00
Bhanu Gupta
7c06afc3bb Enter key press issues resolved 2019-12-22 20:01:29 +05:30
Bhanu Gupta
acba3e59ae Enter key press issues resolved 2019-12-22 19:56:39 +05:30
Bhanu Gupta
cfc962668c Added fuctionality of form submit by enter key in Wikidata Login dialogue 2019-12-21 05:21:43 +05:30
Antonin Delpeuch
fe7c71aecd Update Wikidata extension for 3.3 2019-10-21 10:06:37 +01:00
Antonin Delpeuch
1ee5068f0d CSRF protection for Wikidata extension 2019-10-17 10:42:05 +01:00
Antonin Delpeuch
30c0108241 Change override term UI to use checkbox 2019-06-13 10:56:06 +01:00
Antonin Delpeuch
f7a8085bab Update UI to allow for non-overriding terms. Closes #2063 2019-06-13 09:21:30 +01:00
Antonin Delpeuch
432f16bb6b Remove useless condition in Wikidata schema 2019-04-18 18:24:01 +01:00
Antonin Delpeuch
9cb9f4639e Reset copied reference earlier in Wikidata schema 2019-03-01 09:59:08 +00:00
Antonin Delpeuch
dccc20f149
Merge pull request #1961 from OpenRefine/issue1927
Add ability to copy references in Wikidata schema
2019-02-27 10:01:23 +00:00
Antonin Delpeuch
70094f68b2
Merge pull request #1958 from OpenRefine/issue1934
Make suggest items clickable with the middle button.
2019-02-25 10:30:31 +00:00
Antonin Delpeuch
ac07457306 Fix suggest middle click in Wikidata schema 2019-02-25 10:16:10 +00:00
Antonin Delpeuch
d0a27543f5 Add paste button on new statements, fix invalidation of 'copied' state 2019-02-22 18:24:55 +00:00
Antonin Delpeuch
6d820dfea5 Update frontend date validation and format 2019-02-19 22:46:33 +00:00
Antonin Delpeuch
a7482ff0d2 Add ability to copy references. Closes #1912. 2019-02-19 21:55:27 +00:00
Antonin Delpeuch
2f298b4093 Also make suggestions clickable in Wikidata extension 2019-02-19 14:42:04 +00:00
Antonin Delpeuch
10931e1e4d Migrate js to new localization syntax 2018-11-21 17:30:00 +00:00
Antonin Delpeuch
9bf0bb2154 Merge JS i18n strings with slash 2018-11-21 15:24:57 +00:00
Antonin Delpeuch
9b111952fe
Merge pull request #1795 from OpenRefine/issue1776
Add import and export for Wikidata schema
2018-11-07 10:31:51 +00:00
Antonin Delpeuch
fe6aef5290
Merge pull request #1796 from OpenRefine/issue1774
Re-render table view when switching back from Wikidata schema.
2018-11-05 17:33:26 +00:00
Antonin Delpeuch
91e624e09f Re-render table view when switching back from Wikidata schema. Closes #1774. 2018-11-01 18:46:37 +00:00
Antonin Delpeuch
8bed3022a1 Enable file input on import schema dialog. 2018-11-01 18:30:24 +00:00
Antonin Delpeuch
825c4ad213 Add importer UI for Wikibase schema 2018-11-01 15:01:08 +00:00
Antonin Delpeuch
218e0adb15
Merge pull request #1789 from OpenRefine/issue1778
Enable autocomplete for Wikidata upload form
2018-11-01 12:05:13 +00:00
Antonin Delpeuch
66072f5d05
Merge pull request #1790 from OpenRefine/issue1780
Make reference toggle clickable.
2018-11-01 12:04:34 +00:00
Antonin Delpeuch
32805b19a4 Make reference toggle clickable. Closes #1780. 2018-10-28 10:14:34 +01:00
Antonin Delpeuch
5b810f7c6e Enable autocomplete on summaries. Closes #1778. 2018-10-28 10:07:39 +01:00
Antonin Delpeuch
90ac54ff86 Focus property input when adding qualifiers and references, closes #1777 2018-10-27 21:58:16 +02:00
Antonin Delpeuch
97e16d6e8e Add number of edits in preview and upload dialog 2018-04-28 11:25:49 +02:00
Antonin Delpeuch
adfa60ef14 Fix scrolling in Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
60db2828a8 Add spinner to indicate that Wikidata preview is in progress 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
5fda43a5c7 Make edit summaries mandatory 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
2d549b79f1 Prevent double clicks with e.preventDefault in Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
3bf3f84ca6 Cap number of terms and statements displayed in the preview 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
30defdd2c4 Add save and discard buttons on the Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
d6232efd95 Refresh the column variables when changes are made 2018-04-27 09:17:33 +02:00