Commit Graph

89 Commits

Author SHA1 Message Date
Tom Morris
b3f5fada95 FIXED - task 578 & 596: Clean up JSON importer
http://code.google.com/p/google-refine/issues/detail?id=578
http://code.google.com/p/google-refine/issues/detail?id=596

Extend tree parser framework to allow any Serializable instead of just Strings. Use this in JSON importer to: Import keywords null, true, false; Import empty strings and don't trim whitespace from strings on import;  Import numbers directly instead of importing them as text and then parsing them ourselves. Add tests to verify all this stuff

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2543 7d457c2a-affb-35e4-300a-418c747d4874
2012-09-08 01:20:25 +00:00
Tom Morris
7c7e10d9f5 Fix silly cut & paste test name.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2530 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-14 23:11:42 +00:00
Tom Morris
1e043dcc94 FIXED - task 604: The common transform “Trim leading and trailing whitespace” doesn’t trim non-breaking spaces
http://code.google.com/p/google-refine/issues/detail?id=604

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2529 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-14 23:00:13 +00:00
Tom Morris
4bf212c03d FIXED - task 154: Can't import RDF/XML Data
http://code.google.com/p/google-refine/issues/detail?id=154

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2526 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-05 16:31:41 +00:00
Tom Morris
b2ae74d23f FIXED - task 586: Only one parse date format is attempted from list in toDate(format1,format2)
http://code.google.com/p/google-refine/issues/detail?id=586

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2520 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-03 18:01:01 +00:00
Tom Morris
4319314675 FIXED - task 594: Date diff function doesn't work for two Calendar objects
http://code.google.com/p/google-refine/issues/detail?id=594

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2519 7d457c2a-affb-35e4-300a-418c747d4874
2012-08-02 21:41:19 +00:00
Tom Morris
e97e7523b2 Issue 548 - Convert non-strings to strings before escaping
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2463 7d457c2a-affb-35e4-300a-418c747d4874
2012-03-14 03:06:11 +00:00
Tom Morris
ab4c0cb21c Some basic type conversion tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2456 7d457c2a-affb-35e4-300a-418c747d4874
2012-03-08 14:49:03 +00:00
Tom Morris
593c4123a9 Update one Windmill UI test for Refine 2.5. Another 6 still need to be done.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2433 7d457c2a-affb-35e4-300a-418c747d4874
2012-01-27 16:26:42 +00:00
Tom Morris
fdac0c30cf Issue 524 - shorten __anonymous__ names for JSON importer
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2432 7d457c2a-affb-35e4-300a-418c747d4874
2012-01-26 22:38:25 +00:00
Tom Morris
254d4468cc Fix failing test
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2431 7d457c2a-affb-35e4-300a-418c747d4874
2012-01-26 22:34:39 +00:00
David Huynh
cdca6fff8f Checked in Shardul Deo's patch from
http://groups.google.com/group/google-refine-dev/browse_thread/thread/5222a68396c56405
to support HTTP PUT and DELETE.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2387 7d457c2a-affb-35e4-300a-418c747d4874
2011-11-25 03:48:03 +00:00
Stefano Mazzocchi
856ef6a65a commented out unused variables
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2352 7d457c2a-affb-35e4-300a-418c747d4874
2011-11-01 21:47:24 +00:00
Tom Morris
fe7bf1d1f0 Refactor to conform to method naming conventions
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2344 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-21 16:57:52 +00:00
Tom Morris
ab950689dd Add debugging info - mostly toString() methods for types missing them
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2343 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-21 16:46:55 +00:00
Tom Morris
4966dcc61f Basic trivial test for Excel importer. Please add to this...
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2329 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-12 23:42:29 +00:00
Stefano Mazzocchi
1f67866258 fixing a bunch of inconsistencies and potential bugs as indicated by findbugs, pmd and eclipse
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2301 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 21:23:23 +00:00
Stefano Mazzocchi
af5b49eab9 whitespace (no functional changes)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2299 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:25:15 +00:00
Tom Morris
6b97f6602f Fix last(?) failing test
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2297 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:16:19 +00:00
Tom Morris
31073d7712 Refactor importer interfaces to narrow exceptions thrown and handled
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2296 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 19:06:53 +00:00
Tom Morris
e3f1fab4e8 Issue 453 - Add test for importing top level JSON array - from Thad
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2287 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:52:31 +00:00
Tom Morris
79c795138c Provide exception info for failures
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2286 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:51:06 +00:00
Tom Morris
4a4daf7112 Add some Javadoc. No functional changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2285 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-07 16:29:14 +00:00
Tom Morris
cf206c33bc Update test to accommodate new test for pending operations
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2282 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 21:09:31 +00:00
Tom Morris
97dda9f577 Refactor option mock setup and verification - all tests green (for this module)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2281 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:53:19 +00:00
Tom Morris
90c2715901 Back out workaround for cell numbering
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2280 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:29:53 +00:00
David Huynh
58414f72df Got more tests to pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2279 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 20:01:27 +00:00
David Huynh
a9279e2997 Got more tests to pass.
Note that the automatic column naming behavior did change from { "Column", "Column2", "Column3", ... } to { "Column 1", "Column 2", "Column 3", ... }.

Also note that the tsv/csv importer no longer supports the option not to split into columns. That's another importer (the line-based importer).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2277 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 07:09:05 +00:00
David Huynh
1c5dc32b88 Fixed tsv/csv tests.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2276 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 06:22:30 +00:00
David Huynh
3c6358d518 Fixed json tests.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2275 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-06 04:50:05 +00:00
Tom Morris
850e147779 Changes needed to get FixedWidthImporter test to pass
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2274 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-05 23:49:14 +00:00
Tom Morris
e064dcce3e Add support for getTempDir() as required by new importers
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2273 7d457c2a-affb-35e4-300a-418c747d4874
2011-10-05 23:42:15 +00:00
Tom Morris
1b197d93d8 Issue 447 - allow users to specify delimiters for toTitlecase function
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2253 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-20 05:07:46 +00:00
Tom Morris
884d0ea8d4 Look up functions by name to make tests more directly analogous to user view
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2252 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-20 05:00:48 +00:00
Tom Morris
59d6020979 Add basic test coverage for ToTitleCase and (commented out) support for 2nd parameter
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2250 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-19 15:47:33 +00:00
Tom Morris
f309a26a95 Fix XML importer test to handle new exception being thrown
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2249 7d457c2a-affb-35e4-300a-418c747d4874
2011-09-19 15:34:29 +00:00
David Huynh
90ad8247b7 Minor layout change in custom tabular exporter dialog from Thad's suggestion.
Fixed small compile error in main/tests/.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2226 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-30 21:21:46 +00:00
Tom Morris
da7347e7b1 Make sure all conditionals and loops are in blocks (too bug-prone otherwise)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2183 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 22:21:47 +00:00
Tom Morris
97a0f2a33e Organize imports. com.google.refine last in a section of its own. Everything alphabetical in its section.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2180 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 21:10:22 +00:00
Tom Morris
7fd6e22af4 Convert tabs to spaces. No functional changes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2172 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 20:26:32 +00:00
Tom Morris
123614539d Add missing @Override annotations
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2171 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 19:30:23 +00:00
David Huynh
78edff6f7f Merged new importer UI work from branch over.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2170 7d457c2a-affb-35e4-300a-418c747d4874
2011-08-02 03:34:47 +00:00
Tom Morris
d03c8a1f70 Issue 415: Add some tests for arithmetic expressions in GREL
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2122 7d457c2a-affb-35e4-300a-418c747d4874
2011-06-23 23:41:35 +00:00
Tom Morris
73acd497e9 Fix for issue 358 from Tomaz Solc. Don't return a NaN when comparing two 0-length word lists.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2088 7d457c2a-affb-35e4-300a-418c747d4874
2011-06-06 21:30:46 +00:00
Tom Morris
bbc2b3d363 Test provided by Gabriel Sjoberg. Thank you!
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2002 7d457c2a-affb-35e4-300a-418c747d4874
2011-02-04 20:09:01 +00:00
Tom Morris
3e08aca4ec Issue 304 - Apply patch to fix test. Thanks to GabrielS
git-svn-id: http://google-refine.googlecode.com/svn/trunk@2001 7d457c2a-affb-35e4-300a-418c747d4874
2011-02-04 04:55:05 +00:00
David Huynh
6fb2b05739 Fixed issue 294: "Exporting date type column to TSV/CSV shows java debugging information instead of value" with help from Gabriel Sjoberg.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1967 7d457c2a-affb-35e4-300a-418c747d4874
2010-12-28 15:54:24 +00:00
Iain Sproat
2f564589f5 Adding a Fixed Width data importer (Issue 85) and associated tests.
Although this importer is 'wired up', it requires a property "fixed-column-widths" which is not (yet) implemented in the UI.  But the ImporterRegister.guessImporter method will probably select the CsvTsvImporter before the FixedWidthImporter anyway.  I suggest an improvement to the project creation UI and/or the guessImporter method will be required.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@1857 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 13:15:41 +00:00
Iain Sproat
4f9dc38066 TsvCsvImporter now uses the CSV test methods to also test the TSV importer. Separate tests for the two importers are no longer required.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1856 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 13:06:39 +00:00
Iain Sproat
37a6f938c3 The TestNG DataProvider for the Tsv/Csv importer tests was previously providing just one test case with two parameters, rather than the two test cases of one parameter each which is required. This is now fixed, and the tests pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@1855 7d457c2a-affb-35e4-300a-418c747d4874
2010-11-11 10:52:18 +00:00