* Validate Host header of incoming HTTP requests
* Always allow requests with loopback IP addresses and localhost
* Split off ValidateHostHandler to a separate file
* Allow IPv4-mapped loopback addresses in ValidateHostHandler
* Add error description to 404 error returned by ValidateHostHandler
* Add refine.interface parameter to override interface and host separately
* Fix some whitespace inconsistencies
* Update refine and refine.bat with separate host and interface arguments
* Add -h switch to usage message
* Use -H instead of -h for the host argument
* Bring changes in line with new Jetty version
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
* build(deps): bump butterfly from 1.0.4 to 1.1.0
Bumps [butterfly](https://github.com/OpenRefine/simile-butterfly) from 1.0.4 to 1.1.0.
- [Release notes](https://github.com/OpenRefine/simile-butterfly/releases)
- [Commits](https://github.com/OpenRefine/simile-butterfly/commits)
Signed-off-by: dependabot[bot] <support@github.com>
* Update Butterfly configuration after Jetty upgrade
* Fix main class name in web.xml
* Upgrade Butterfly to Jetty 9
* Temporary debugging output to understand why RefineServlet is not found
* Upgrade servlet-api
* Fix javax.servlet-api artifactId
* Reinstate debug logging temporarily
* Update butterfly to 1.1.1 to solve servlet-api version conflict
* Update javax.servlet-api in the rest of the code base
* Silence server logs in ./refine ui_test again
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
* Add Google API key - fixes#3604
Enables access to public data in Google Sheets/Drive. API key must be
sent if OAuth token isn't.
* Don't force authentication for GData import from URL
* Fixed flaky tests
* Refactored ui_test commans-line, added documentation
* Attempt to build a workflow with cypress
* Fixed CI UX tests build
* Changed cyprss actions for pull-request
* Merged Cypress workflow into the regular PR target workflow
* Refactored Github workflows to include Cypress Tests
* Revert Ci build to pull_request_target
In strict shell environments, the "$?" is reset when evaluated.
Here, the "boolean if" statements compares it to "7", then reset it and compares it to "22".
If the "$?" is intially "22", it is not evaluated and the NOT_RUNNING variable is ignored while it shouldn't. this leads to the error
"Something is already running on http://127.0.0.1:3333/"
To avoid this, the solution is to first affect the value of "$?" to a non-system variable and then evaluate this new variable.
* pass options as proper bash list items so that even if directories
contain spaces, they will be properly passed on to java - #1623
* ignore empty options
