Commit Graph

349 Commits

Author SHA1 Message Date
Iain Sproat
ec7ac81246 Applying Tom Morris's patch to GridworksServlet.(issue #48). GridworksServlet creates classes from a string, so is no longer dependent on (imports) any of the Command Classes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@821 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-19 07:09:40 +00:00
David Huynh
1e737e3238 Factored row dependency code from Row class and Project class out as Record and RecordModel classes.
Simplified RdfTripleImporter.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@820 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-19 04:22:45 +00:00
David Huynh
e1861eb1d9 Let the RdfTripleImporter handle .rdf and application/rdf+xml files.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@819 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 21:28:31 +00:00
Iain Sproat
0e4682f453 RdfTripleImporter handles row dependencies.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@818 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 21:08:37 +00:00
Iain Sproat
cfd0f2219e RdfTripleImporter does basic reconciliation on Rdf subject - data model is no longer sparse (now possible to have more than one data point per row)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@816 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 13:48:52 +00:00
Iain Sproat
043f46c562 RdfTripleImporter correctly adds empty cells to existing rows when a column is added.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@815 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 13:04:51 +00:00
Iain Sproat
25d3a9dfc1 Added a basic RDF triple importer plus unit tests. Some more work required - it's not plugged into the client and it creates a very sparse data structure (each triple is a new row). It uses JRDF library (Apache 1.1 license).
git-svn-id: http://google-refine.googlecode.com/svn/trunk@813 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 12:41:40 +00:00
David Huynh
ee82ec2642 Issue 45: "Renaming Cells with Ctrl-Enter produced ERROR"
Tentative fix by sprinkling in "synchronized".


git-svn-id: http://google-refine.googlecode.com/svn/trunk@809 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 00:02:58 +00:00
Stefano Mazzocchi
6c9ef24336 lower verbosity of scatterplot generation
git-svn-id: http://google-refine.googlecode.com/svn/trunk@808 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 23:59:56 +00:00
David Huynh
0c70d281c7 Issue 28: mql-like preview is not properly unquoting numbers.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@807 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 23:47:09 +00:00
David Huynh
fa2be33709 Fixed issue 16: Column name collision when adding data from Freebase.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@804 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 21:33:46 +00:00
David Huynh
4cf476630e Fixed issue 15: Ability to rename projects - added rename command in both index.html and project.html (main menu bar)
Updated CHANGES.txt with other fixes committed previously.
Made sure releases.js doesn't hold up the initialization code of project.html.
Some polishing on the rendering of projects' last modified dates in index.html.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@799 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 19:22:58 +00:00
Iain Sproat
092d4602b9 TsvCsvImporter passes all unit tests. TsvCsvImporter again uses opencsv library.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@797 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 11:57:26 +00:00
Iain Sproat
03b1ab01f4 RowParser is no longer a parameter of read method in TsvCsvImporter (now handled in the method itself)
CSVRowParserTests is now tidied - with expected and actual being input into the correct parameters of Assert.assertEquals.  One more test passes, but still 2 tests failing.


git-svn-id: http://google-refine.googlecode.com/svn/trunk@792 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 06:24:58 +00:00
David Huynh
bd8d214a49 Resolved issue 19 for TSV as well, not just for CSV.
Touched up TsvCsvImporterTests to leave the comma vs. tab guessing to the importer itself. All tests still pass.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@790 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:55:02 +00:00
Iain Sproat
6f74bcaa26 comments tidied in TsvCsvImporterTests and ImporterUtilities
git-svn-id: http://google-refine.googlecode.com/svn/trunk@789 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:40:46 +00:00
David Huynh
68fbd3320b Got disabled tests in Issue 41 to pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@788 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:26:29 +00:00
Iain Sproat
22fb3a1585 fixing issue introduced in r782. - importer now autodetects separator correctly.
Uses original CSV parser, but 4no tests do not pass (ignored with enabled=false flag).

git-svn-id: http://google-refine.googlecode.com/svn/trunk@787 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 03:22:22 +00:00
David Huynh
4cbd5a3b49 More re-organization of commands.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@786 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 02:33:01 +00:00
David Huynh
590358ca63 More new commands.* packages for better organization of commands. More re-organization of commands.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@785 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 02:24:45 +00:00
David Huynh
7d6a3cbe87 More new commands.* packages for better organization of commands. Some re-organization of commands.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@784 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 02:01:08 +00:00
Stefano Mazzocchi
f28e23e503 Committing patches by Iain:
- use OpenCSV parser instead of our own
 - use TestNG instead of JUnit which is a lot more configurable in test selection (and allows us to do a much better job a leaving the tree green even while developing tests that are known to fail)
 - integrated TestNG in './gridworks test'
 - added Iain to the list of contributors in README.txt
 - changed the Eclipse test launch file to use the TestNG launcher (unfortunately, this is not shipped by default in Eclipse, so you have to install it yourself from the http://beust.com/eclipse update file, I'll add this to the wiki shortly)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@782 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-16 18:42:52 +00:00
David Huynh
6450921c02 Fixed issue 4: Match All bug with ZIP code.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@767 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 17:03:33 +00:00
David Huynh
bd87e079b2 Fixed issue 34: Behavior of Text Filter is unpredictable when "regular expression" mode is enabled.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@766 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 16:51:31 +00:00
Stefano Mazzocchi
ea459aed07 Applied a bunch of patches from Tom Morris (Issue 25, 26 and 27)
- make java6 dependency explicit in eclipse project files
- avoid using NotImplementException especially the sun.* one
- avoid using internal sun signal handling and rely on standard java.* APIs
 (I tested this one and it seems to be working fine)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@756 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 21:02:19 +00:00
Iain Sproat
a096fae7a0 ParsingUtilities.evaluateJsonStringToObject is now unit tested
CommandTests and CancelProcessesCommandTests are slightly formatted to match code standards.
Command and CancelProcessesCommand are slightly tweaked to pass under all unit tests.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@753 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 09:23:37 +00:00
Stefano Mazzocchi
5070de6446 committing Iain's new tests and polished things a little
(also added a test-specific log4j conf so that we don't show all the warnings during the tests that were distracting)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@744 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 00:54:02 +00:00
Stefano Mazzocchi
1b9cfbbf90 detabbing (no functional changes)
David, you might want to check your editor settings, you're mixing tabs with spaces


git-svn-id: http://google-refine.googlecode.com/svn/trunk@724 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 09:02:41 +00:00
Stefano Mazzocchi
11da70d223 Applying patch for Issue 21 from iainsproat
git-svn-id: http://google-refine.googlecode.com/svn/trunk@722 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 08:59:05 +00:00
Stefano Mazzocchi
fe0afa0bc3 Fixed Issue #18
git-svn-id: http://google-refine.googlecode.com/svn/trunk@721 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 07:53:26 +00:00
David Huynh
8412aa72dd Fixed Issue 17: Conflated triples - all rows are producing triple with "s" :" $Name_0".
Also exposed "id" field for recon objects.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@720 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 07:45:22 +00:00
David Huynh
992cb964eb Fixed Issue 2: Undo History bug. The MassChange class didn't write out each elemental change's class and so they couldn't be read back in.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@719 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 06:35:01 +00:00
David Huynh
7ad438078f Fixed Issue 19: CSV import is too basic. Quoted cells in a CSV file can now contain line breaks. Added a CSV file to test that.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@717 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 06:07:44 +00:00
Stefano Mazzocchi
a643eabc88 fixed eclipse warning
git-svn-id: http://google-refine.googlecode.com/svn/trunk@710 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 18:18:07 +00:00
David Huynh
f341fa8db2 Fixed Issue 13: float rejected from sandbox upload as Json object.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@708 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 06:45:49 +00:00
David Huynh
114be582e8 Fixed issue 5: Localized Windows cause save problems for Gridworks. jdatapath library returns a path in which each unicode character (in the user ID) has been replaced by ?. So we need to grab the actual user ID from environment variables such as APPDATA or USERPROFILE.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@707 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 04:16:26 +00:00
Stefano Mazzocchi
a626ea51ff if the user's computer's clock is not synchronized with Freebase's, the initial oauth handshake will fail because Freebase believe there is a replay attack going on. To avoid that we ask Acre to tell us what time it is in Freebase land and we sign the request with that instead. We default back to the user clock only if Acre is down or swamped.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@704 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 23:24:58 +00:00
David Huynh
60ef31012a Check for missing "target" in protograph link node's serialized json object when reloading from project files.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@702 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 20:49:45 +00:00
David Huynh
2161255cdb Fixed issue 11: missing "lang" attribute in MQL generated in schema alignment.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@700 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 20:08:53 +00:00
David Huynh
9fa9401ccb Fixed a bug in which if the target of a protograph link was somehow missing, the project.html wouldn't load.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@665 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-09 19:35:42 +00:00
David Huynh
510df55ea5 Oops, forgot to change the autosave period back to 5 minutes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@628 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-09 04:37:36 +00:00
David Huynh
8c03c1ddcf Prevent autosave timer events from bunching up when the computer is put into sleep mode.
Don't autosave while creating or importing projects, exporting rows, or uploading data to Freebase. Those are potentially intensive operations.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@627 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-09 04:34:36 +00:00
David Huynh
33895a7a6d In scatterplot facets, made sure in log/log mode no point falls in the negative quadrants.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@615 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-06 22:49:19 +00:00
David Huynh
fae6701493 Added support for exporting a scatterplot facet's image as a large image.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@614 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-06 20:44:40 +00:00
David Huynh
f37d24e04a Scatterplot facets:
- Changed coordinate systems of selection to zero to one, as fraction of plot's size
- Used affine transform to do proper plot rotation
- Filled negative quadrants of plot to indicate rotation
- Set default dot size of actual facet's plot to regular

git-svn-id: http://google-refine.googlecode.com/svn/trunk@612 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-06 19:34:51 +00:00
Stefano Mazzocchi
fc5dd69c33 wrong fix
git-svn-id: http://google-refine.googlecode.com/svn/trunk@602 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-05 01:50:54 +00:00
Stefano Mazzocchi
c32899aea6 clearing PMD warnings
git-svn-id: http://google-refine.googlecode.com/svn/trunk@600 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-05 01:42:08 +00:00
Stefano Mazzocchi
e6d36710ff findbug cleanups
git-svn-id: http://google-refine.googlecode.com/svn/trunk@599 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-05 01:35:51 +00:00
Stefano Mazzocchi
92ecc0c0f5 detab + dedos for java files (no functional changes)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@594 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-04 23:24:48 +00:00
David Huynh
883fc65304 Minor bug: blank maxColumns param caused SplitColumnCommand to throw an exception.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@587 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-04 16:14:13 +00:00