s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,713 Commits 6 Branches 0 Tags 1.3 GiB
fdc8d073e3
Commit Graph

637 Commits

Author SHA1 Message Date
Joanne Ong
d57d76f7df
Fix imprecise facet statistics in records mode (#2607) 
* Fix bug in choice counts for records mode

* Add test for value grouper on records

* Refactor and comment code

* Count distinct instances of null/blank data

* Update test to check for blank data count in records

* Remove unnecessary import statement
 2020-06-15 19:38:50 +02:00
Lisa Chandra
947356ddad
[FEAT]Adds new options for split (#2471) 
* added options ui

* added definition for both separators

* added tests

* removed definitions from backend and added them to frontend

* added reverse order and handling for accented characters

* added tests for accented characters and reverse split

* fixed build errors

* unicode character ranges instead

* added examples
 2020-06-15 19:30:18 +02:00
chuhao zeng
9b03ecae41
Convert illegal characters into legal ones. (#2431) 
* Convert illegal characters into leagal ones.

* Test tab in key & value string

Also fix up test that depended on previous TAB
related error message and clean up logging

Co-authored-by: Tom Morris <tfmorris@gmail.com>
 2020-06-14 09:47:58 +02:00
Tom Morris
18c18e587e
Replace Apache Ant with Commons Compress (#2691) 
NOTE: Changes the public API where some of the old types were
embedded which means that any extensions that extend these
interfaces will have to be updated.

Fixes #2690.
 2020-06-11 16:39:51 +02:00
Tom Morris
e6ed8e5d62
Save preferences JSON using UTF-8 encoding. Bulletproof prefs load. (#2657) 
* Save preferences JSON using UTF-8 encoding. Bulletproof prefs load.

Fixes #2543. Fixes #2627.

Always use UTF-8 to write JSON because platform default encoding
might not be legal JSON (e.g. ISO 8859-1).

Also be more conservative about keeping backups if we fail to write.

* Handle case where backup prefs is better than more recent

* Recover from corrupted prefs with null starred list.

Fixes #2544. Replaces null with an empty list.

* Run tests with non-UTF-8 encoding

Make sure that we don't depend on UTF-8 being the default encoding
because it isn't true everywhere (e.g. Windows)

* Add test for non-ASCII chars in workspace.json

This depends on the default Java encoding being something
other than UTF-8 to test properly.
 2020-06-06 10:00:01 +01:00
Antoine Beaubien
3ca08f6ff1
Changed cell.error to cell.errorMessage & added help data. (#2628) 
* Changed cell.error to cell.errorMessage & added help data.

Changed cell.error to cell.errorMessage and added the informations into the internal help system.

* FR Text correction

* HU Fix text

3 instead of 2.
 2020-05-23 14:05:25 +02:00
Lu Liu
e89eaf0ee2
support default project name and column name for cross() (#2518) 2020-05-22 09:39:57 +02:00
Tom Morris
557ffad920
Merge pull request #2586 from OpenRefine/issue-2510-type-boolean 
Support "boolean" return for type() function.  Closes #2510
 2020-05-18 17:24:47 -04:00
Antoine2711
0e86619d86 Fix the true.type() == "boolean" 
Fix the true.type() == "boolean" instead of java.lang.Boolean.

Remove all the references to "error" result  in Type(). This will be addressed in:
@ToDo fix this with issue #2562
 2020-05-18 17:23:43 -04:00
Antonin Delpeuch
825e687b0b
Fix bug when both trim and autodetect are enabled in tabular parser. Closes #2584 (#2610) 2020-05-05 14:00:17 +02:00
PJ Fanning
ab64303cbb
allow xlsx files to have more columns (#2602) 2020-04-26 17:07:26 +02:00
PJ Fanning
fe7fcce94b
small improvement to xls tests (#2599) 2020-04-26 16:02:20 +02:00
PJ Fanning
1a0e187561
correct excel mime types (#2596) 
* correct excel mime types

* address PR issue

* remove use of wildcard
 2020-04-26 14:36:37 +02:00
Thad Guidry
009c587437
remove unused imports (#2574) 2020-04-21 15:51:01 +02:00
Lu Liu
bf84fc9cf1
use string representation for matching (#2571) 2020-04-20 09:07:09 +02:00
Ekta Mishra
05b6a7b2ae
Provides more intuitive representation for arrays in GREL (#2488) 
Added test for same
closes #2040
 2020-04-01 10:59:25 +02:00
chuhao zeng
1f0111eaed
Fix silent error in JSON/XML importers (#2414) 
* Add error handler for parse error

* Add test for parsing json with incorrect strecture

* Enable localization from front-end

* Add methods to get localized error messages

* Update returned exception message

* Remove unused log and fix file diff issue

* Test auto build

* Refactor getOptions in newly created test

* Use new exception to unwrap original message

* Undo unexpected fix

* Remove unused lines

* Fix exception logic

* Fix typo
 2020-03-27 09:41:49 +01:00
Lu Liu
f2b06418da
Support lookup by numbers for GREL cross function (#2468) 
* support int & long argument for cross function

* support any types of a cell value
 2020-03-26 08:57:10 +01:00
chuhao zeng
70b4c6a6d0
Enable gzip compression (#2475) 
* Enable gzip compression

* Add test for gzip parser
 2020-03-26 08:42:55 +01:00
chuhao zeng
e484625adf
Fix: Data losses when importing multiple sheets from same Excell file (#2404) 
* Fix loosing data when importing multiple sheets from same source Excell file

* Add test for importing multi sheets with different column size

* Fix space issues

* Restore old tests and implement new test cases for the new feature

* Restore unexpected delete

* Refactor fix

* Restore unexpected line delete

* Add new unit test for new feature
 2020-03-23 22:41:23 +01:00
Lu Liu
9ad3b1080f
Make cross() function work for all columns (#2456) 
* fix #1950

* migrate from join to lookup

* reformat
 2020-03-23 14:48:32 +01:00
Lisa Chandra
ef8ad85c3c
Adds trim whitespace option to separator based files (#2408) 
* added trim ui to csv importer

* added trim functionality

* trimStrings handler only for strings

* added test for trimStrings option in csv/tsv files

* made trim option enabled by default
 2020-03-21 10:38:43 +00:00
Albin Larsson
9745bfe374
consistent usage of Apache http status constants (#2432) 2020-03-18 06:40:52 +00:00
Albin Larsson
0233e7186b
CSVExporter: add test case for quoteAll option (#2430) 2020-03-18 04:39:32 +00:00
Lisa Chandra
a91691cb6b
[FIX] json/xml trim whitespace configuration option (#2415) 
* trimStrings condition

* added test for trimString xml

* added trimStrings check for json
 2020-03-15 16:04:01 +00:00
Lu Liu
14ef45efb2
mock reconciliation service (#2410) 2020-03-14 09:40:15 +00:00
zengchu2
c90fd31daf
Add cell.error field for error messages (#2363) 
* Add case for querying cell.error for error messages

* Add testing file

* Refactor test case for cell with error

* Reformat spaces
 2020-03-10 10:14:15 +00:00
jamessspanggg
67b62c5c16 EditOneCellCommandTests: Add number parsing tests 2020-01-08 09:55:51 +08:00
Antonin Delpeuch
904129d0f7 Fix other NPE in expression logging, for #2264 2020-01-06 06:30:56 +01:00
Antonin Delpeuch
14dd4c0112
Merge pull request #2264 from OpenRefine/issue-2086-expression-logging-npe 
Fix NPE in expression logging.
 2019-12-30 21:52:58 +01:00
Antonin Delpeuch
08e175dc66 Fix NPE in expresion logging. Closes #2086. 2019-12-25 12:33:42 +01:00
Antonin Delpeuch
78853f8fb2 More robust URI detection in tabular exporter. Closes #2213. 2019-12-25 11:33:03 +01:00
Antonin Delpeuch
cc5498a42a
Return best loaded language code in LoadLanguageCommand. (#2232) 
Closes #2227.
 2019-11-27 15:35:18 +00:00
Antonin Delpeuch
85e40b8c45 Fix typo 2019-11-07 17:52:38 +01:00
Antonin Delpeuch
efbfce29bb Add server-side language fallback. 
This allows to keep the same Javascript calls to load languages, so it
does not require any change for extensions to benefit from this.

Closes #1350. Fixes #2209.
 2019-11-07 17:23:02 +01:00
Antonin Delpeuch
5dc005749a Add CSRF protection to remaining commands 2019-10-15 12:07:13 +01:00
Antonin Delpeuch
3559eeb11f CSRF protection for project and recon commands 2019-10-15 12:07:12 +01:00
Antonin Delpeuch
a340c137d0 CSRF protection for OpenWorkspaceDirCommand and language loading 2019-10-15 12:07:04 +01:00
Antonin Delpeuch
91cead27f8 CSRF protection for ImportingController 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
70e37b9085 Add CSRF protection to cell, history, column and expr commands 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
51ddd27909 Require CSRF token in EditOneCellCommand 2019-10-14 16:24:26 +01:00
Antonin Delpeuch
21b841a089 Add CSRF token generation capabilities, for #2164 2019-10-14 16:24:26 +01:00
viniciusbds
6743d5c878 Change strings comparison to use equals comparator 2019-10-01 23:05:24 -03:00
Antonin Delpeuch
bbb5766a33
Merge pull request #2155 from OpenRefine/issue-2152-lonely-clusters 
Fix clusters with single candidates.
 2019-09-18 19:08:18 +01:00
Antonin Delpeuch
36150a874d Fix scatterplot facet filtering 2019-09-12 11:52:28 +01:00
Antonin Delpeuch
573ba18e6d Fix scatterplot drawing command, closes #2117 2019-09-12 10:43:12 +01:00
Antonin Delpeuch
fdf742b052 Unlink wikidata extension from RefineTest 2019-09-12 10:24:25 +01:00
Antonin Delpeuch
95b063162d Fix clusters with single candidates. Closes #2152. 2019-09-11 12:12:32 +01:00
Antonin Delpeuch
3e241871cc Mock HTTP calls in data extension tests. Closes #1904. 2019-08-27 19:52:21 +01:00
Antonin Delpeuch
a8b6f63c90 Update testng configuration after package change 2019-08-23 15:19:30 +01:00
Antonin Delpeuch
29f3cef3ec Remove uses of junit, closes #2133 2019-08-23 14:09:27 +01:00
Antonin Delpeuch
46acc21a43 Move tests to their appropriate packages and deduplicate them, for #2133 2019-08-23 13:27:20 +01:00
Antonin Delpeuch
2b03efd84f Rename test packages to match tested ones, for #2133 2019-08-23 11:55:31 +01:00
Antonin Delpeuch
6e96441684 Merge test files for Find function 2019-07-21 16:18:19 +01:00
Owen Stephens
ac7b5a0a19 Update Find and Tests 2019-07-21 13:34:18 +01:00
Owen Stephens
d6999de0da Match only accepts regular expressions 2019-07-21 13:19:34 +01:00
Owen Stephens
0560b772f1 Add test for finding literals 2019-07-21 12:46:12 +01:00
Antonin Delpeuch
33ff7be18a Fix NPE in StandardReconConfig. Closes #2076. 2019-07-03 10:21:45 +02:00
Antonin Delpeuch
cde59a0dca
Merge pull request #2070 from OpenRefine/issue-2068-duplicate-json-key 
Remove duplicate JSON keys.
 2019-07-02 10:19:16 +02:00
Antonin Delpeuch
8390d234b1
Merge pull request #2058 from OpenRefine/issue-1994-customMetadata 
Fix parsing and display of custom metadata
 2019-06-14 14:53:19 +01:00
Antonin Delpeuch
9d76b04a1c Remove duplicate JSON keys. Closes #2068. 2019-06-14 11:38:24 +01:00
Krzysztof 'impune-pl' Prorok
ceb367b906 Updated tests for issue 1998 2019-06-04 17:05:44 +02:00
Antonin Delpeuch
b9573d83e0 Add customMetadata to project metadata parsing test 2019-06-04 12:02:49 +01:00
Antonin Delpeuch
51a8cbf946
Merge pull request #2042 from stanakaj/issue-2041 
Fix column removal in reorder leaves undeleted hidden cells.
 2019-05-31 08:41:13 +01:00
Antonin Delpeuch
b366b29da1 Fix #2025: XLSX tests locale dependency 2019-05-15 11:49:53 +01:00
s_tanaka
b8b9feac0c Fix column removal in reorder leaves undeleted hidden cells. 2019-05-15 19:37:40 +09:00
Antonin Delpeuch
0332be312f Fix JSON history corruption. 
Also adds new logic to preserve the JSON representation of unknown operations,
to protect from version downgrading or removal of extensions.

Closes #1990.
 2019-04-18 20:31:41 +01:00
Owen Stephens
794a17c98e Added XLSX exporter tests 2019-04-09 16:58:58 +01:00
Owen Stephens
e2aa929908 Ensure workbooks are closed after reading/writing 2019-04-09 15:02:10 +01:00
Owen Stephens
461b352035 Add test for reading XLSX 2019-04-09 13:50:42 +01:00
Owen Stephens
81a82499b5 Added tests for serializing cells containing dates and numbers 2019-04-04 23:00:56 +01:00
Owen Stephens
62bcc80dcc Add tests for serialisation of Booleans and Numbers in cells 2019-04-04 11:41:35 +01:00
Owen Stephens
7425418011 Add RandomNumber GREL function 2019-03-24 20:16:43 +00:00
Owen Stephens
fe6abedc52 Add inArray function to GREL 2019-03-24 19:50:25 +00:00
Antonin Delpeuch
5c44acc0b3
Merge pull request #1985 from ostephens/cross-error-reporting 
Cross error reporting
 2019-03-24 08:16:58 +00:00
Owen Stephens
722db56071 Add tests for new Cross errors 2019-03-23 14:15:23 +00:00
Antonin Delpeuch
7f6831523e
Merge pull request #1969 from OpenRefine/revert-1888-fix-reconcile-facets 
Revert "Fix Reconcile facets affected by change to list facet boolean handling"
 2019-02-27 10:33:21 +00:00
Antonin Delpeuch
7144798aac
Merge pull request #1967 from OpenRefine/compute_recon_features_bug 
Fix Recon features computation for empty recons
 2019-02-23 19:08:11 +00:00
Antonin Delpeuch
2bfc268e69 Revert "Merge pull request #1666 from ostephens/list-facet-changes" 
This reverts commit 29a818f7b4, reversing
changes made to 1189cdb4f9.
 2019-02-22 18:38:45 +00:00
Antonin Delpeuch
deb7335848 Fix Recon features computation for empty recons 2019-02-22 09:15:42 +00:00
Antonin Delpeuch
a072328637 Accept URIs in 'Use values as ids' operation. 
Closes #1953.
 2019-02-19 22:06:35 +00:00
Antonin Delpeuch
3a213b482c Fix failing test 2019-02-19 12:39:50 +00:00
Antonin Delpeuch
fcc6aa05d7 Provide default identifierSpace and schemaSpace for reconciliation services. Closes #1936. 2019-01-22 19:04:25 +01:00
Antonin Delpeuch
eb16784f01
Merge pull request #1924 from OpenRefine/issue1907 
Disable DTDs in XML importer.
 2019-01-07 14:07:30 +01:00
Antonin Delpeuch
e5da39fa4a
Merge pull request #1920 from OpenRefine/issue1913 
Reorder reconciliation results by decreasing score
 2019-01-06 15:55:51 +01:00
Antonin Delpeuch
6a0d7d56e4 Disable DTDs in XML importer. Closes #1907. 2018-12-31 16:02:34 +01:00
Antonin Delpeuch
ddd9bf9aa8
Merge pull request #1906 from OpenRefine/issue1893 
Make clustering extensible
 2018-12-31 14:13:46 +01:00
Antonin Delpeuch
79ec6988d6 Fix GetCLusteringFunctionANdDistancesCommandTest 2018-12-30 22:22:50 +01:00
Antonin Delpeuch
074765f816 Add test to ensure sort is stable. 2018-12-30 20:49:18 +01:00
Antonin Delpeuch
b03dbf2446 Reorder reconciliation results by decreasing score. Fixes #1913. 2018-12-30 20:47:12 +01:00
Jacky
150ee12058
Merge pull request #1902 from OpenRefine/cleanup 
Tidy up various things
 2018-12-11 20:59:50 -05:00
Antonin Delpeuch
8063ca63d9 Add license headers 2018-12-11 12:10:11 +00:00
Antonin Delpeuch
7ae71470ef Add new command to expose known clustering functions and distances 2018-12-11 10:51:29 +00:00
Jacky
7f7b71459c
Merge pull request #1901 from OpenRefine/issue1840 
Fix zip slip vulnerability
 2018-12-09 12:05:16 -05:00
Antonin Delpeuch
d4222c05ef
Merge pull request #1877 from OpenRefine/issue1876 
Fix reconciliation result deserialization
 2018-12-09 22:47:40 +09:00
Antonin Delpeuch
caf2b4d915 Add missing license headers 2018-12-09 12:22:40 +09:00
Antonin Delpeuch
79994e86da Create dedicated temporary dir for zip slip test 2018-12-09 11:01:58 +09:00
Antonin Delpeuch
e243e73e40 Fix zip slip vulnerability. Closes #1840. 2018-12-09 10:41:33 +09:00
jackyq2015
d1ed842f02 support both jdk 8 and 9 2018-12-08 15:31:01 -05:00
Antonin Delpeuch
be137fc53c Add serialization tests in different timezone 2018-12-06 15:46:20 +09:00
Antonin Delpeuch
44c43253a1 Avoid localizing time for dates with unspecified time. Closes #1874. 2018-12-02 12:58:05 +09:00
Antonin Delpeuch
82598ae1d5 Fix reconciliation result deserialization. Closes #1876. 2018-12-02 11:59:47 +09:00
Antonin Delpeuch
2e81c9ff2e Remove uses of org.json after merge 2018-12-01 05:11:21 +09:00
Antonin Delpeuch
70d0e9b283 Support UI json format for ColumnDetail 2018-11-30 19:39:42 +09:00
Antonin Delpeuch
1e578384e2 Avoid double serialization of json mode in recon config 2018-11-30 19:39:42 +09:00
Antonin Delpeuch
a4117b470c Remove leftover merge conflicts 2018-11-30 19:39:42 +09:00
Antonin Delpeuch
f667a78657 Migrate recent PRs to Jackson 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
99e98a2e78 Remove all references to org.json in core 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
d6ca879558 Migrate ColumnRenameOperation to Jackson 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
b0e9e21a6b Remove spurious references to org.json 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
59175daf38 Migrate GuessTypesOfColumnCommand to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
ba8e406a97 Clustering config Jackson deserialization 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
d311810c2c Migrate SortingConfig to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
86d1159926 Migrate Engine to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
c9786d0f9a Fix bug in join() GREL function 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
b569490eef Migrate ProjectMetadata to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
6d05631a07 Migrate GREL functions and controls to Jackson 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
5a4a79028f Revert "data package metadata (#1398)" 
This reverts commit c4b0ff6bea.
 2018-11-30 19:35:31 +09:00
Antonin Delpeuch
ac444b8b50 Add project metadata serialization test 2018-11-30 19:23:08 +09:00
Antonin Delpeuch
ccb1ac84c1 Migrate GREL AST to Jackson 2018-11-30 19:23:08 +09:00
Antonin Delpeuch
e4e73d0b92 Migrate importers to use Jackson classes 2018-11-30 19:23:08 +09:00
Antonin Delpeuch
fc7da40055 Jackson deserialization for PreferenceStore 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
5cf58d874b Fix deserialization of MassEditOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
2873035ee2 Migrate TabularExporter to use JsonNode 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
52426b98a3 Jackson deserialization for CsvExporter 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
d012ea7f8d Remove reconstruct method on operations 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
6358a4aeb5 Jackson deserialization for TransposeColumnsIntoRowsOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
d493bf0720 Jackson deserialization for MassEditOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
5f671e5e81 Jackson deserialization for sorting Criterion and subclasses 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
242a3abb7d Jackson deserialization for RowRemovalOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
c58854d947 Jackson deserialization for ReconUseValuesAsIdsOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
3271e53ecf Jackson deserialization for ReconJudgeSimilarCellsOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
eb66619840 Jackson deserialization for ExtendDataOperation 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
393eec1586 Jackson deserialization for EngineConfig 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
ae61368796 Jackson deserialization for TextSearchFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
c4caf1eba7 Jackson deserialization for TimeRangeFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
d8bc841dae Jackson deserialization for RangeFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
39498233fb Jackson deserialization for ListFacetConfig 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
d4bdd37bda Jackson deserialization for Recon 2018-11-30 19:21:22 +09:00
Antonin Delpeuch
487f6bc131 Jackson deserialization for Row 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
0dae0811b0 Jackson deserialization for ReconConfig 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
bc6f1b0146 Fix failing tests after JSONWriter replacement 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
c9620a5d9a Add missing .flush(); .close() on JsonGenerator 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
fec28b99bc Various serialization fixes 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
1790799bfe Remove Jsonizable interface and write methods 2018-11-30 19:21:21 +09:00
Antonin Delpeuch
fd69e4b980 Serialization tests for expression commands 2018-11-30 19:20:34 +09:00
Antonin Delpeuch
65231e2140 Refactor GetRowsCommand for Jackson migration 2018-11-30 19:20:34 +09:00
Antonin Delpeuch
0583ae659d Make FileProjectManagerTests independent from RefineTest 2018-11-30 19:20:34 +09:00
Antonin Delpeuch
987c2d1c80 Jackson serialization for project managers 2018-11-30 19:20:34 +09:00
Antonin Delpeuch
49b84574da Move EvalErrorTests 2018-11-30 19:20:34 +09:00