Commit Graph

149 Commits

Author SHA1 Message Date
Ekta Mishra
fe275ae634
Move findValues method to EditScrtuinzer (#2941)
* Move findValues method to EditScrtuinzer

As findValues method is not concerned with fetching, therefore moving it to EditScrtuinizer

* updated test classes accordingly

* updated test classes accordingly

* test files updated after shifting the findValues method
2020-07-15 11:46:06 +02:00
Ekta Mishra
c7a8dfb329
Reuse Constraint IDs and Property IDs (#2937)
* Revert "Revert "Reused Constraint IDs and Parameter PIDs (#2893)""

This reverts commit 4c739be843.

* Reuse Constraint IDs and Parameter PIDs

After the cleanup of MockConstraintFetcher, using constraint IDs and property IDs defined in the corresponding scrtinizer for the test files.
2020-07-14 20:51:18 +02:00
Antonin Delpeuch
4c739be843 Revert "Reused Constraint IDs and Parameter PIDs (#2893)"
This introduces a build failure since other refactorings took place.

This reverts commit f41ce3a752.
2020-07-14 20:15:59 +02:00
Ekta Mishra
f41ce3a752
Reused Constraint IDs and Parameter PIDs (#2893)
Reused the hardcodedd constraint & paramter IDs from the scrutinizer classes into the test classes repectively.
2020-07-14 20:12:46 +02:00
Ekta Mishra
c5e6ac9f90
Remove unused scrutinizer specific methods (#2935)
After adding the code for fetching parameters for different scrutinizers in their corresponding classes, we should remove the redundant code from the ConstraintFetcher
2020-07-14 17:51:06 +02:00
Ekta Mishra
bf3d7234b9
Add ItemRequires Constraint (#2901)
* Add ItemRequires Constraint

Implemented Item requires constraint as part of #2354

* done with implementation of ItemRequiresScrutinizer Class

* Test class added with suitable test cases
2020-07-14 16:11:25 +02:00
Ekta Mishra
29f6885ccc
MockConstraintFetcher cleanup part-I (#2882)
* MockConstraintFetcher cleanup part-I

Removed its use from different test files

* Removed MockConstraintFetcher's use from various test files
2020-07-06 18:27:16 +02:00
Ekta Mishra
d871a2e151
Implemented RestrictedPosition Scrutinizer tests using mocks (#2868)
* Implemented RestrictedPosition Scrutinizer tests using mocks

Added RestrictedPositionConstraint class and updated test cases using mocks

* Tests updated & working fine
2020-07-04 14:25:00 +02:00
Ekta Mishra
a0a164bb8b
Implemented ResctrictedValue Scrutinizer tests using mocks (#2877)
* Implemented RestrictedValueScrutinizer tests using mocks

Added AllowedValueConstraint & DisallowedValueConstraint classes & updated the test cases too.

* Tests updated
2020-07-04 14:23:52 +02:00
Antonin Delpeuch
952447461f
Fix wikidata logout when credentials have expired. Fixes #2873 (#2878) 2020-07-04 08:38:17 +02:00
Ekta Mishra
c68047a614
Implemented QuantityScrutinizer tests using Mocks (#2862)
* Implemented QunatityScrutinizer tests using Mockito

Updated test cases and added AllowedUnitsConstraint class

* Test cases updated
2020-07-03 14:14:32 +02:00
Ekta Mishra
9edb1e514d
Implemented Difference-within-range Scrutinizer tests using mocks (#2864)
Updated all test cases and added DifferenceWithinRangeConstraint class.
2020-07-03 14:13:31 +02:00
Ekta Mishra
cd0ed11dad
Implemented Format Scrutinizer tests using Mockito (#2849)
* Implemented Format Scrutinizer tests using Mockito

Updated implementation of the scrutinzer & tests

* Testcases updated in FormatScrutinizerTest
2020-07-02 16:28:56 +02:00
Ekta Mishra
9dfb9114c4
Implemented QualifierComaptibilty Scrutinizer tests using Mockito (#2860)
Updated test cases & added AlLowedQualifierConstraint and MandatoryQualifierConstraint classes.
2020-07-02 14:22:50 +02:00
Ekta Mishra
67bc8581ce
Implemented InverseScrutinizer tests using Mocks (#2855)
* Implemented InverseScrutinizer tests using Mocks

updated testcases and added InverseConstraint Class

* Test cases updated & working fine
2020-07-01 20:49:15 +02:00
Ekta Mishra
cef2e84e7f
Implemented EntityTypeScrutinizer tests usings mocks (#2839)
Updates all the testcases in EntityTypeScrutinizerTest
2020-06-30 22:59:43 +02:00
Ekta Mishra
bc672047f6
Implemented DistinctValueScrutinizer tests using mockito (#2833)
* Implemented DistinctValueScrutinizer tests using mcokito

Added inner class to the scrutinizer and updated the tests using mocks.

* Tests updated-testNoIssue added

* all tests updated & working fine
2020-06-29 16:00:37 +02:00
Ekta Mishra
46c510b5e2
Implemented SingleValue Scrutinizer tests using mocks (#2818)
* Implemented SingleValue Scrutinizer tests using mocks

Updated test class & added inner class to the scrutinizer

* tests updated

* Updated SingleValueConstraint class
2020-06-29 15:59:53 +02:00
Ekta Mishra
f32f6a6ea2
Change return type of getConstraintsByType method (#2838)
changed the return type of getConstraintsByTpye method from Stream<Statement> to List<Statement>
2020-06-29 08:43:38 +02:00
Ekta Mishra
1b04927d12
Add constraint class (#2822)
* Add constraint class

* Add constraint class

* updated names
2020-06-28 10:20:18 +02:00
Ekta Mishra
7ac41b4609
Implemented ConflictsWithScrutinizer tests using Mockito (#2804)
updated test class by creating mocks for ConstraintFetcher

Implemented tests for conflicts-with scrutinizer using mocks

Added testcase for no statementList & multiple constraint.

Implemented tests using mock for conflicts-with scrutinizer

Implemented tests using mock for conflicts-with scrutinizer

Added test case for multiple constraints

Added test case for multiple constraints
2020-06-27 17:17:20 +02:00
Ekta Mishra
8c1d8cdcb7
New implementation for Multivalue Scrutinizer (#2807)
Created inner class for Multivalue & mocks for unit tests

New implementation for multivalue scrutinizer

tests updated
2020-06-26 10:14:34 +02:00
Tom Morris
b59228185e
Merge pull request #2756 from OpenRefine/wikidata-extension-oauth
Wikidata extension two-legged OAuth support
2020-06-19 12:49:52 -04:00
Ekta Mishra
45fab05bf6
New implementation for Conflicts-With Scrutinizer (#2693)
part of #2354
2020-06-19 10:18:21 +02:00
afkbrb
7b237b4d83 call setSecure explicitly & fix HTTP response splitting 2020-06-19 14:38:35 +08:00
Lu Liu
335e81a26c OAuth support for the Wikidata extension (#2661)
Closes #1612 

Merges @afkbrb work to finish @wetneb protype, including:
* adding support for OAuth in addition to basic auth
* supporting registration of single user Wikidata OAuth consumers.
* adding extensive tests
* cleaning up the login dialog

This depends on the next release of the Wikidata Toolkit, but we're currently publishing our own snapshot that includes the necessary changes (thanks @wetneb!)

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2020-06-18 23:51:22 -04:00
james-cui
04055153a1
add archive column (#2573)
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2020-06-15 19:56:00 +02:00
darecoder1999
4983dbc0f7 Fixed typos made in PR #2641 2020-06-10 09:45:53 +05:30
Ekta Mishra
cf851ee636
Added conflicts-with constraints (#2641)
Implemented conflicts-with scrutinizer as part of #2354
2020-06-09 20:45:15 +02:00
Ekta Mishra
1638d68e35
Added difference-within-range Scrutinizer (#2634) 2020-06-06 19:48:14 +01:00
Ekta Mishra
29a757dc57
Added support for Multi-value Constraint in Wikidata extension (#2629) 2020-05-31 14:24:51 +01:00
james-cui
7311581df0
make maxlag configurable (#2469) 2020-03-26 08:46:49 +01:00
Lu Liu
c20dc69294
mock Wikidata service (#2412) 2020-03-14 15:36:09 +00:00
afkbrb
be5f6e6402 move check functions in DescriptionScrutinizer to CommonDescriptionScrutinizer 2020-03-02 21:59:55 +08:00
afkbrb
82f95f2bbf update DescriptionScrutinizer & create EnglishDescriptionScrutinizer 2020-03-02 14:35:42 +08:00
afkbrb
077b4c7afa add DescriptionScrutinizerTest 2020-03-01 22:04:37 +08:00
afkbrb
6ad252c55a add corresponding tests 2020-02-29 11:05:23 +08:00
Antonin Delpeuch
d77d54803f Fix Wikidata TODAY test 2020-01-06 13:30:10 +01:00
Antonin Delpeuch
ae41348e00 Fix bug with TODAY in Wikidata schema 2020-01-06 11:40:14 +01:00
Antonin Delpeuch
fe57897e8e Fix Wikidata login CSRF issue. Closes #2228. 2019-12-25 11:02:19 +01:00
Antonin Delpeuch
1355a373c9 Mock HTTP calls in EntityCache 2019-12-21 19:09:03 +01:00
Antonin Delpeuch
1f708637b6 Fix overflow error for quantities stored as doubles. Closes #2244. 2019-12-13 15:23:24 +01:00
Antonin Delpeuch
b19e8a9a74
Update Wikidata-Toolkit to solve various issues (#2215)
Updates Wikidata-Toolkit to 0.11.0

This enables the following improvements:
- https://github.com/Wikidata/Wikidata-Toolkit/issues/431
- https://github.com/Wikidata/Wikidata-Toolkit/issues/456

This closes #2196 although the feature will not be enabled until 3.4 for technical reasons
(the openrefine-3.3 tag on Wikidata can only be applied by an AbuseFilter, not manually through
the API).

* Update WDTK and add timeouts to Wikidata editing, closes #2211.

* Explicitly add wdtk-util as a dependency

* Catch MediaWikiApiError following change of interface
2019-11-21 21:47:49 +01:00
Antonin Delpeuch
de6dedb43d Skip update if rewriting failed 2019-11-05 17:49:47 +00:00
Antonin Delpeuch
ec5c9cd418 Fix duplicate creations, closes #2206 2019-11-04 21:17:18 +00:00
Antonin Delpeuch
1ee5068f0d CSRF protection for Wikidata extension 2019-10-17 10:42:05 +01:00
Antonin Delpeuch
c35b2e154f
Merge pull request #2141 from OpenRefine/issue-1904-mock-data-extension-tests
Mock HTTP calls in data extension tests.
2019-09-12 10:41:47 +01:00
Antonin Delpeuch
fdf742b052 Unlink wikidata extension from RefineTest 2019-09-12 10:24:25 +01:00
Antonin Delpeuch
29f6d1d14b
Merge pull request #2137 from OpenRefine/issue-2136-wikidata-calendar
Improved support for Wikidata dates
2019-09-11 17:16:49 +01:00
Antonin Delpeuch
80eea8635b Add support for TODAY constant in Wikidata schemas 2019-08-25 13:42:28 +01:00