RandomSec/main
Tom Morris 1849e62234
Better error handling for reconciliation process - fixes #2590 (#2671)
* Harden reconciliation - Fixes #2590

- check for non-JSON / unparseable JSON returns
- handle malformed results response with no name for candidates
- catch any Exception, not just IOExceptions
- call processManager.onFailedProcess() for cleanup on error

* Add default constructor for Jackson

Jackson complains about needing a default constructor for the
NON_DEFAULT annotation, but I'm not sure why this worked before.

* Clean up indentation and unused variable - no functional changes

Make indentation consistent throughout the module, changing recently
added lines to use the standard all spaces convention.

Remove unused count variable

* Simplify control flow

* Update limit parameter comment. No functional change.

* Replace ternary expression which is causing NPE

* Add reconciliation tests using mock HTTP server
2020-06-23 21:54:54 +02:00
..
IDEs/eclipse Thad no longer supports Netbeans config (#2466) 2020-03-27 09:30:30 +01:00
src Better error handling for reconciliation process - fixes #2590 (#2671) 2020-06-23 21:54:54 +02:00
tests Better error handling for reconciliation process - fixes #2590 (#2671) 2020-06-23 21:54:54 +02:00
webapp Translated using Weblate (Portuguese (Brazil)) 2020-06-22 12:03:51 +02:00
pom.xml Merge pull request #2745 from OpenRefine/dependabot/maven/org.codehaus.mojo-build-helper-maven-plugin-3.1.0 2020-06-22 13:06:02 -04:00