refactor in Submit: map submit inputs

This commit is contained in:
Mateusz Tylka 2023-05-24 10:16:18 +02:00
parent e31bb7ff0f
commit 2c4c89ef80
3 changed files with 29 additions and 19 deletions

View File

@ -2,7 +2,6 @@ import React from 'react';
import { createPortal } from 'react-dom';
import { FlexColumn } from '../../utils/containers';
import { H2, Menu } from '../../utils/fonts';
import SubmitInput from '../../components/generic/SubmitInput';
import Button from '../../components/generic/Button';
import theme from '../../utils/theme';
import challengeSubmission from '../../api/challengeSubmissionPost';
@ -12,6 +11,7 @@ import SubmitReducer from './model/SubmitReducer';
import SUBMIT_ACTION from './model/SubmitActionEnum';
import SubmitStyle from './SubmitStyle';
import SubmissionLoading from './components/SubmissionLoading/SubmissionLoading';
import renderSubmitInputs from './functions/renderSubmitInputs';
const Submit = (props) => {
const [state, dispatch] = React.useReducer(SubmitReducer, {
@ -52,24 +52,7 @@ const Submit = (props) => {
Submit a solution to the challenge
</H2>
<FlexColumn className="SubmitStyle__form">
<SubmitInput
label="Submission description"
handler={(value) => {
dispatch({ type: SUBMIT_ACTION.SET_DESCRIPTION, payload: value });
}}
/>
<SubmitInput
label="Submission repo URL"
handler={(value) => {
dispatch({ type: SUBMIT_ACTION.SET_REPO_URL, payload: value });
}}
/>
<SubmitInput
label="Submission repo branch"
handler={(value) => {
dispatch({ type: SUBMIT_ACTION.SET_REPO_BRANCH, payload: value });
}}
/>
{renderSubmitInputs(dispatch)}
<TagsChoose
label="Submission tags"
updateTags={(submissionTags, tags) => {

View File

@ -0,0 +1,18 @@
import { SUBMIT_INPUTS } from '../utils';
import SubmitInput from '../../../components/generic/SubmitInput';
const renderSubmitInputs = (dispatch) => {
return SUBMIT_INPUTS.map((input, index) => {
return (
<SubmitInput
key={`submit-input-${index}`}
label={input.label}
handler={(value) => {
dispatch({ type: input.action, payload: value });
}}
/>
);
});
};
export default renderSubmitInputs;

View File

@ -0,0 +1,9 @@
import SUBMIT_ACTION from './model/SubmitActionEnum';
const SUBMIT_INPUTS = [
{ label: 'Submission description', action: SUBMIT_ACTION.SET_DESCRIPTION },
{ label: 'Submission repo URL', action: SUBMIT_ACTION.SET_REPO_URL },
{ label: 'Submission repo branch', action: SUBMIT_ACTION.SET_REPO_BRANCH },
];
export { SUBMIT_INPUTS };