From 3e80e9c0163062f59d83351a8d775bf40ca18447 Mon Sep 17 00:00:00 2001
From: jan-kordas <jan.kordas90@gmail.com>
Date: Tue, 14 Jan 2025 15:49:37 +0100
Subject: [PATCH] fixed bug caused by empty user input, added full names of
 models and Alibaba recommended

---
 src/app/main.py              | 14 ++++++++++----
 src/app/templates/index.html | 18 ++++++++++++------
 2 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/src/app/main.py b/src/app/main.py
index 6b26e4d..2f726ba 100644
--- a/src/app/main.py
+++ b/src/app/main.py
@@ -33,11 +33,17 @@ alibaba_embeddings=load_embeddings(alibaba_embeddings_path)
 @app.route("/", methods=["GET", "POST"])
 def index():
     if request.method == "POST":
-        user_input = request.form["description"]
-        model_type = request.form["model_type"]
-        performance_choice = request.form["preference_choice"]
-        similarity_metric = request.form["similarity_metric"] 
+        user_input = request.form.get("description", "").strip() 
+        if not user_input:
+            return render_template(
+                "index.html",
+                error="Please provide a description to get movie recommendations."
+            )
 
+        model_type = request.form.get("model_type", "")
+        performance_choice = request.form.get("preference_choice", "")
+        similarity_metric = request.form.get("similarity_metric", "")
+        
         if model_type == "bert":
             model = bert_model
             tokenizer = bert_tokenizer
diff --git a/src/app/templates/index.html b/src/app/templates/index.html
index 5ff440f..24745d7 100644
--- a/src/app/templates/index.html
+++ b/src/app/templates/index.html
@@ -42,10 +42,16 @@
         <h1 class="text-center mb-4">Filmosfera</h1>
         <div class="card shadow-sm p-4">
             <div id="content">
+                {% if error %}
+                <div class="alert alert-danger" role="alert">
+                    {{ error }}
+                </div>
+                {% endif %}
+
                 <form method="POST">
                     <div class="mb-3">
                         <label for="description" class="form-label">Describe the kind of movie you want:</label>
-                        <textarea id="description" name="description" class="form-control" rows="3" required></textarea>
+                        <textarea id="description" name="description" class="form-control" rows="3"></textarea>
                     </div>
                 <div class="mb-3">
                     <label for="preference_choice" class="form-label">Choose performance preference:</label>
@@ -65,10 +71,10 @@
                     <div class="mb-3">
                         <label for="model_type" class="form-label">Choose a model:</label>
                         <select id="model_type" name="model_type" class="form-select">
-                            <option value="bert">BERT</option>
-                            <option value="sentence-transformer">SentenceTransformer</option>
-                            <option value="sentence-bert">Sentence-BERT</option>
-                            <option value="alibaba">Alibaba</option>
+                            <option value="alibaba">Alibaba-NLP/gte-large-en-v1.5 (recommended)</option> 
+                            <option value="bert">google-bert/bert-base-uncased</option>
+                            <option value="sentence-transformer">sentence-transformers/all-MiniLM-L6-v2</option>
+                            <option value="sentence-bert">sentence-transformers/paraphrase-mpnet-base-v2</option>
                         </select>
                     </div>
                 <div class="mb-3">
@@ -94,4 +100,4 @@
     </div>
 </body>
 
-</html>
\ No newline at end of file
+</html>