kalmar
/
GroupRings.jl
mirror of https://github.com/kalmarek/GroupRings.jl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

no need for prefix to fmac!: it is not exported

This commit is contained in:
kalmarek 2019-01-09 16:54:45 +01:00
parent e39a1c8b4d
commit 01071414f7
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/GroupRings.jl
View File

@ -340,7 +340,7 @@ function -(X::GroupRingElem{S}, Y::GroupRingElem{T}) where {S, T}
end end
@doc doc""" @doc doc"""
GRfmac!(result::AbstractVector{T}, fmac!(result::AbstractVector{T},
X::AbstractVector, X::AbstractVector,
Y::AbstractVector, Y::AbstractVector,
pm::Array{Int,2}) where {T<:Number} pm::Array{Int,2}) where {T<:Number}
@ -354,7 +354,7 @@ end
> Use with extreme care! > Use with extreme care!
""" """
function GRfmac!(result::AbstractVector{T}, function fmac!(result::AbstractVector{T},
X::AbstractVector, X::AbstractVector,
Y::AbstractVector, Y::AbstractVector,
pm::Array{Int,2}) where {T<:Number} pm::Array{Int,2}) where {T<:Number}
@ -395,7 +395,7 @@ function GRmul!(result::AbstractVector{T},
z = zero(T) z = zero(T)
result .= z result .= z
return GRfmac!(result, X, Y, pm) return fmac!(result, X, Y, pm)
end end
@doc doc""" @doc doc"""
@ -463,7 +463,7 @@ function *(X::GroupRingElem{T}, Y::GroupRingElem{T}, check::Bool=true) where {T<
result = parent(X)(similar(X.coeffs)) result = parent(X)(similar(X.coeffs))
result = mul!(result, X, Y) result = mul!(result, X, Y)
else else
result = RGmul!(similar(X.coeffs), X.coeffs, Y.coeffs, parent(X).pm) result = GRmul!(similar(X.coeffs), X.coeffs, Y.coeffs, parent(X).pm)
result = GroupRingElem(result, parent(X)) result = GroupRingElem(result, parent(X))
end end
return result return result

2
test/runtests.jl
View File

@ -234,7 +234,7 @@ using SparseArrays
@test Z.coeffs == GroupRings.GRmul!(W.coeffs, X.coeffs, Y.coeffs, RG.pm) == W.coeffs @test Z.coeffs == GroupRings.GRmul!(W.coeffs, X.coeffs, Y.coeffs, RG.pm) == W.coeffs
@test (2*X*Y).coeffs == @test (2*X*Y).coeffs ==
GroupRings.GRfmac!(W.coeffs, X.coeffs, Y.coeffs, RG.pm) == GroupRings.fmac!(W.coeffs, X.coeffs, Y.coeffs, RG.pm) ==
GroupRings.mul!(2, X*Y).coeffs GroupRings.mul!(2, X*Y).coeffs
end end
end end