kalmar
/
GroupRings.jl
mirror of https://github.com/kalmarek/GroupRings.jl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

short-circuting -> proper if...ends

This commit is contained in:
kalmar 2017-05-17 11:47:59 +02:00
parent 3a50399fb0
commit 04257e9054
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/GroupRings.jl
View File

@ -298,15 +298,20 @@ function create_pm{T<:GroupElem}(basis::Vector{T}, basis_dict::Dict{T, Int},
end
function complete(A::GroupRing)
isdefined(A, :basis) || A.basis = collect(elements(A.group))
isdefined(A, :basis_dict) || A.basis_dict = reverse_dict(A.basis)
if !isdefined(A, :basis)
A.basis = collect(elements(A.group))
end
if !isdefined(A, :basis_dict)
A.basis_dict = reverse_dict(A.basis)
end
if !isdefined(A, :pm)
A.pm = try
create_pm(basis, basis_dict)
create_pm(A.basis, A.basis_dict)
catch err
isa(err, KeyError) && throw("Product is not supported on basis!"))
isa(err, KeyError) && throw("Product is not supported on basis")
throw(err)
end
end
return A
end