s416084/find-my-tutor-android
1
0
Fork 0
Code Issues Pull Requests Releases 9 Wiki Activity

Retrofit with jwt Interceptor, MainActivity with MapBox #3

Closed
s411201 wants to merge 0 commits from service-models-coordinates into develop
pull from: service-models-coordinates
merge into: s416084:develop
Conversation 1 Commits - Files Changed -
s411201 commented 2018-08-28 21:24:09 +02:00
Collaborator
Copy Link
No description provided.
s416204 commented 2018-08-28 22:59:33 +02:00
Collaborator
Copy Link

#1. In this class there are a few typos in API paths:
5b2dfff4dd/app/src/main/java/com/uam/wmi/findmytutor/service/UserService.java

For instance:
@GET("/api/users/tutors/page/{pageNum}")
should be
@GET("api/users/tutors/page/{pageNum}")

#2. A Result model class is useless. In PagedResult model result variable should have had a type of User instead of Result.

Please change:
private List results = null;
to
private List tutorList = null;

#1. In this class there are a few typos in API paths: https://git.wmi.amu.edu.pl/s416084/find-my-tutor-android/src/5b2dfff4ddffad213e44fa5fe5c2c2198381278e/app/src/main/java/com/uam/wmi/findmytutor/service/UserService.java For instance: @GET("/api/users/tutors/page/{pageNum}") should be @GET("api/users/tutors/page/{pageNum}") #2. A Result model class is useless. In PagedResult model result variable should have had a type of User instead of Result. Please change: private List<Result> results = null; to private List<User> tutorList = null;
s416204 closed this pull request 2018-09-08 15:18:51 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
s416204
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: s416084/find-my-tutor-android#3
No description provided.
Delete Branch "service-models-coordinates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?