s434730/RandomSec
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Attempt to fix flaky reconciliation tests (#4091)

Browse Source 
Attempt to fix flaky reconciliation tests
This commit is contained in:
Florian Giroud 2021-08-30 12:47:26 +02:00 committed by GitHub
parent 005e8b77a7
commit b7652e9036
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
main/tests/cypress/cypress/integration/project/grid/column/reconcile/reconcile.spec.js
View File

@ -89,7 +89,7 @@ describe('Base reconciliation tests', () => {
.siblings('input') .siblings('input')
.uncheck(); .uncheck();
cy.get('.dialog-container button').contains('Start Reconciling...').click(); cy.get('.dialog-container button').contains('Start Reconciling...').click();
cy.assertNotificationContainingText('Reconcile cells in column species'); cy.wait(10000); // eslint-disable-line
cy.assertColumnIsReconciled('species'); cy.assertColumnIsReconciled('species');
// "Choose new match" appear when there is a match, if it's not there it means nothing is matched // "Choose new match" appear when there is a match, if it's not there it means nothing is matched
@ -110,7 +110,7 @@ describe('Base reconciliation tests', () => {
.siblings('input') .siblings('input')
.check(); .check();
cy.get('.dialog-container button').contains('Start Reconciling...').click(); cy.get('.dialog-container button').contains('Start Reconciling...').click();
cy.assertNotificationContainingText('Reconcile cells in column species'); cy.wait(10000); // eslint-disable-line
cy.assertColumnIsReconciled('species'); cy.assertColumnIsReconciled('species');
// 4 rows should have been automatched // 4 rows should have been automatched
@ -130,6 +130,7 @@ describe('Base reconciliation tests', () => {
cy.get('.recon-dialog-service-panel.recon-dialog-standard-service-panel').should('be.visible'); cy.get('.recon-dialog-service-panel.recon-dialog-standard-service-panel').should('be.visible');
cy.get('.dialog-container input[bind="maxCandidates"]').type(2); cy.get('.dialog-container input[bind="maxCandidates"]').type(2);
cy.get('.dialog-container button').contains('Start Reconciling...').click(); cy.get('.dialog-container button').contains('Start Reconciling...').click();
cy.wait(10000); // eslint-disable-line
cy.assertColumnIsReconciled('species'); cy.assertColumnIsReconciled('species');
cy.get('.data-table-cell-content .data-table-recon-topic').should( cy.get('.data-table-cell-content .data-table-recon-topic').should(
'have.length', 'have.length',

2
main/tests/cypress/cypress/support/commands.js
View File

@ -349,7 +349,7 @@ Cypress.Commands.add(
); );
Cypress.Commands.add('assertNotificationContainingText', (text) => { Cypress.Commands.add('assertNotificationContainingText', (text) => {
cy.get('#notification-container'); cy.get('#notification-container').should('be.visible');
cy.get('#notification').should('be.visible').should('to.contain', text); cy.get('#notification').should('be.visible').should('to.contain', text);
}); });