Commit Graph

84 Commits

Author SHA1 Message Date
Matías García Isaía
282cfa6e93
Fix null precondition while importing a Google Sheet (#3801)
`Credential.Builder()` requires a non-null `AccessMethod`[0], and we were sending
it `null` when actually importing the spreadsheet.

This commit defaults to the same `BearerToken.authorizationHeaderAccessMethod()` that the
`getDriveService()` function was already using.

[0]: https://github.com/googleapis/google-oauth-java-client/blob/v1.31.0/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/Credential.java#L636-L638

Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2021-06-28 09:35:05 +02:00
Tom Morris
314dbb560d
Add Google API key - fixes #3604 (#3611)
* Add Google API key - fixes #3604

Enables access to public data in Google Sheets/Drive. API key must be
sent if OAuth token isn't.

* Don't force authentication for GData import from URL
2021-02-11 19:50:54 +01:00
Tom Morris
83ed9ffdaf
Refactor importer APIs - Fixes #2963 (#2978)
* Make sure data directory is directory, not a file

* Add a test for zip archive import

Also tests the saving of the archive file name and source filename

* Add TODOs - no functional changes

* Cosmetic cleanups

* Revert importer API changes for archive file name parameter

Fixes #2963
- restore binary compatibility to the API
- hoist the handling of both fileSource and archiveFileName from
TabularImportingParserBase and TreeImportingParserBase to
ImportingParserBase so that there's only one copy. These 3 classes are
all part of the internal implementation, so there should be no
compatibility issue.

* Revert weird flow of control for import options metadata

This reverts the very convoluted control flow that was introduced
when adding the input options to the project metadata. Instead
the metadata is all handled in the importer framework rather than
having to change APIs are have individual importers worry about
it.

The feature never had test coverage, so that is still to be added.

* Add test for import options in project metadata & fix bug

Fixes bug where same options object was being reused and overwritten,
so all copies in the list ended up the same.
2020-07-23 18:36:14 +02:00
Tom Morris
de2c2aa778
Correct mimetype for Google Drive project exports (#2829)
Fixes #2797. Changes mimetype from zip to gzip
and adds .tar.gz extension to the name.
2020-07-03 14:24:25 +02:00
Tom Morris
bc540a880e
Fix update to deprecated Google Drive credential code (#2828)
No issue. Restore missing piece of commit 42354c0 so that Builder
has the method parameter that it needs.
2020-06-28 23:07:06 +02:00
Tom Morris
3aa610d6aa
Improve Google Sheets upload (#2784)
* Support more than 26 columns

Google Sheets default to just 26 columns (A-Z) and we need to
explicitly add more columns if we need them.

Fixes #2760

* Improve Google Sheets upload

- upload in chunks instead of serializing the entire document at once
- Free up resources as we go
- stop if an error occurs
- reduce batch size to try and stay in 10MB request size limit
  (but need a more dynamic way to do this probably for very wide
   sheets or sheets with large values)

* Add basic test and do some cleanup

- add test for columns > 26
- refactor to allow testing and not depend on unnecessary fields
- add i18n TODO for translating spreadsheet description

* Preserve cell data types

Fixes #2785
- integers and floats are sent as Doubles
- bools as Boolean
- DateTimes as Strings
- nulls as the empty string
- anything else as Strings using .toString()

* Fix LGTM-flagged potentially null pointer dereference
2020-06-25 08:18:28 +02:00
Tom Morris
d97d6c66b8
Update Google API dependencies for GData extension (#2754)
* Update Google API dependencies for Sheets & Drive

Remove unnecessary direct dependencies which are transitive
dependencies of those.

* Fix use of deprecated class
2020-06-23 21:55:46 +02:00
Tom Morris
9b8e750550 Don't skip empty cells on export
Make sure we output at least an empty string as a placeholder.
Fixes #2306
2020-06-21 23:16:46 -04:00
Tom Morris
7a1451f561 Report errors to user
No errors were being reported before.
Also add TODO for progress indicator on long uploads
2020-06-21 23:09:47 -04:00
james-cui
04055153a1
add archive column (#2573)
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
2020-06-15 19:56:00 +02:00
Tom Morris
3a7812aef7
Load GDrive icon from local resource, not Github (#2689)
Fixes #2688.
2020-06-14 09:46:38 +02:00
Tom Morris
f478356e17
Restore copyrights (#2633)
* Restore copyrights deleted in c758a6b635

* Update copyright notices
2020-05-22 06:01:15 +02:00
Thad Guidry
009c587437
remove unused imports (#2574) 2020-04-21 15:51:01 +02:00
Bűn Tamás
9c911275f6
Fixed that can't select a different sheet #2307 (#2390) 2020-03-17 11:00:27 +00:00
Lu Liu
f476f01b37
support configurable credentials for gdata (#2392) 2020-03-12 10:41:04 +00:00
Lu Liu
4477fc15a5
fix Google Sheets importer when URL is missing a trailing slash (#2380) (#2382)
* fix #2380

* update test

* rename test method
2020-03-10 13:48:00 +00:00
Antonin Delpeuch
a4c4a20767 Fix Google Sheets and Google Drive export 2020-01-04 15:56:24 +01:00
Antonin Delpeuch
6dc79d965d Use state to keep redirect URI constant 2019-12-31 10:21:07 +01:00
Antonin Delpeuch
fe5871bd51 Remove Fusion Tables support in gdata extension. Closes #2113. 2019-12-31 07:17:41 +01:00
Antonin Delpeuch
24feda600a CSRF protection for gdata extension 2019-10-17 09:54:53 +01:00
Stefan Weil
ed04be1c96 extensions: Fix some typos in comments and message texts
All typos were found and fixed using codespell.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2019-04-02 17:38:47 +02:00
Antonin Delpeuch
1df2d15e6d Remove all references to org.json in gdata extension 2018-11-30 19:38:52 +09:00
Antonin Delpeuch
5a4a79028f Revert "data package metadata (#1398)"
This reverts commit c4b0ff6bea.
2018-11-30 19:35:31 +09:00
Antonin Delpeuch
5b153dcfba Migrate gdata extension importers to Jackson 2018-11-30 19:23:08 +09:00
Antonin Delpeuch
2873035ee2 Migrate TabularExporter to use JsonNode 2018-11-30 19:22:21 +09:00
Antonin Delpeuch
47d80002a8 Migrate GData extension out of JSONWriter 2018-11-30 19:21:21 +09:00
Jacky
5a6c9d72f0 fix the template load issue and package typo 2018-06-16 15:43:29 -04:00
Jacky
9a469fce17 add timeout support 2018-05-28 23:21:44 -04:00
Jacky
cf573f37de fix the NPE when there is no fusion table exists 2018-03-06 18:16:29 -05:00
Jacky
ac57eb813e changes based on code review 2018-03-06 18:10:54 -05:00
Jacky
6af7e6545c adjust timeout to 3 min 2018-03-01 22:48:14 -05:00
Jacky
77aad7eb05 changes based on the code review 2018-03-01 22:45:14 -05:00
Jacky
c758a6b635 exclude test-out 2018-02-25 12:00:40 -05:00
Jacky
efcbe4b718 upgrade the google api services 2018-02-02 13:04:27 -05:00
Jacky
c4b0ff6bea data package metadata (#1398)
* fix the appbundle issue #1209

* fix #1162

allow the JRE 9

* fix the package declarations

* remove the _ from the method name

* use the explicit scoping

* remote extra ;

* fix issued from codacy

* fix issued from codacy

* add preferences link to the index page

* handle the empty user metadata

* fix 'last modified' sorting issue #1307

* prevent overflow of the table. issue #1306

* add isoDateParser to sort the date

* prevent overflow of the project index

* remove sorter arrow for action columns

* disable editing the internal metadata

* adjust the width of the table

* change MetaData to Metadata

* change the filed name from rowNumber to rowCount

* put back the incidently deleted gitignore

* add double quote to prevent word splitting

* UI improvement on metadata view and project list view

* remove the date field in metadata

* message notification of the free RAM. Issue #1295

* UI tuning for metadata view

* shorten the ISO date to locale date format

* Added translation using Weblate (Portuguese (Brazil))

* remove the rename link

* Ignore empty language files introduced by Weblate

* Add UI for Invert text filter

* Backend support for Inverting Text search facets

* Fix reset on text search facet

* More succinct return statements

* add tests for SetProjectMetadataCommand

* Tidying up for Codacy

* Added Tests for TextSearchFilter

* Corrections for Codacy

* More code tidy up

* let the browser auto fit the table cell when resizing/zooming

* fix import multiple excel with mulitple sheets issue #1328

* check if the project has the userMetadata

* fix the unit test
support multi files with multi tables for open office

* prevent the same key for user metadata

* replace _ with variable for exception

* fix the no-undef issue

* to adjust the width of transform dialog. issue #1332

* fix the row count refresh issue

* extract method

* move the log message

* cosmatic changes for codacy

* fix typo

* bump to version 2.8

* .gitignore is now working

* preview stage won't have the metadata populated, so protect NPE

* Update README.md

No more direct link to the last version tag, which will avoid having to think of updating the readme

* refacotring the ProjectMetadata class

* introduce the IMetadata interface

* create submodule of dataschema

* add back

* setup lib for dataschema; upgrade the apache lang to lang3

* replace escape* functions from apache lang3

* replace the ProjectMetadata with IMetadata interface

* add missing jars

* set the IMetadata a field of Project

* remove PreferenceStore out of Project model

* fix test SetProjectMetadataCommandTests by casting

* introdcue the AbstractMetadata

* introdcue the AbstractMetadata

* reorganize the metadata package

* allow have mulitiple metadata for a project

* support for mulitple metadata format

* remove jdk7 since 'table schema' java implmentation only support jdk8+

* set execute permission for script

* fix the Unit Test after Metadata refactoring

* restore the apache lang2.5 since jetty 6.1.22 depend on it

* add commons lang 2.5 jar

* git submodule add  https://github.com/frictionlessdata/datapackage-java

* remove the metadata parameter from the ProjectManager.registerProject method

* remove hashmap _projectsMetadata field from the ProjectManager and FileProjectManager

* init the Project.metadataMap

* fix Unit Test

* restore the ProjectMetaData map to ProjectManager

* put the ProjectMetaDta in place for ProjectManager and Project object

* check null of singleton instead of create a constructor just for test

* load the data package metadata

* importing data package

* importing data package

* encapsulate the Package class into DataPackageMetadata

* user _ to indicate the class fields

* introduce base URL in order to download the data files

* import data package UI and draft backend

* import data package UI

* fix typo

* download the data set pointed from metadata resource

* save and load the data package metadata

* avoid magic string

* package cleanup

* set the java_version to 1.8

* set the min jdk to 1.8

* add the 3rd party src in the build.xml

* skip the file selection page if only 1 DATA file

* add files structure for json editor

* seperate out the metadata file from the retrival file list

* rename the OKF_METADATA to DATAPACKAGE_METADATA

* clean up

* implement GetMetadateCommand class

* display the metadata in json format

* git submodule update --remote --merge

* adjust the setting after pulling from datapackage origin

* fix the failed UT DateExtensionTests.testFetchCounts due to new json jar json-20160810.jar will complain: JSONObject["float"] not a string.

* clean up the weird loop array syntax get complained

* remove the unused constant

* export in data package format

* interface cleanup

* fix UT

* edit the metadata

* add UT for SetMetadataCommand

* fix UT for SetMetadataCommand

* display the data package metadata link on the project index page

* update submodule

* log the exceptions

* Ajv does not work properly, use the back end validation instead

* enable the validation for jsoneditor

* first draft of the data validation

* create a map to hold the constraint and its handler

* rename

* support for minLength and maxLength from spec

* add validate command

* test the opeation instead of validate command

* rename the UT

* format the error message and push to the report

* fix row number

* add resource bundle for validator

* inject the code of the constrains

* make the StrSubstitutor works

* extract the type and format information

* add the customizedFormat to interface to allow format properly

* get rid of magic string

* take care of missing parts of the data package

* implement RequiredConstraint

* patch for number type

* add max/min constraints

* get the constrains directly from field

* implement the PatternConstraint

* suppress warning

* fix the broken UT when expecting 2 digits fraction

* handle the cast and type properly

* fix the missing resource files for data package when run from command line

* use the copy instead of copydir

* add script for appveyor

* update script for appveyor

* do recursive clone

* correct the git url

* fix clone path

* clone folder option does not work

* will put another PR for this. delete for now

* revert the interface method name

* lazy loading the project data

* disable the validate menu for now

* add UT

* assert UTs

* add UT

* fix #1386

* remove import

* test the thread

* Revert "test the thread"

This reverts commit 779214160055afe3ccdcc18c57b0c7c72e87c824.

* fix the URLCachingTest UT

* define the template data package

* tidy up the metadata interface

* check the http response code

* fix the package

* display user friendly message when URL path is not reachable

* populate the data package schema

* Delete hs_err_pid15194.log

* populate data package info

* add username  preference and it will be pulled as the creator of the metadata

* undo the project.updateColumnChange() and start to introduce the fields into the existing core model

* tightly integrate the data package metadata

* tightly integrate the data package metadata for project level

* remove the submodule

* move the edit botton

* clean up build

* load the new property

* load the project metadata

* fix issues from codacy

* remove unused fields and annotation

* check the http response code firstly

* import zipped data package

* allow without keywords

* process the zip data package from url

* merge the tags

* check store firstly

* remove the table schema src

* move the json schema files to schema dir

* add comment

* add comment

* remove git moduels

* add incidently deleted file

* fix typo

* remove SetMetadataCommand

* revert change

* merge from master
2018-02-02 13:24:19 +00:00
Tom Morris
508fa6efc3 Fix character set for GData docs - fixes #1003 2015-05-15 15:54:09 -04:00
Tom Morris
28eafe7a5b Update Google client libs to current versions. Fix Spreadsheet #996 2015-05-14 20:41:03 -04:00
Tom Morris
dd32f37ab6 Improve error message via @annolangen in PR #853 2014-12-21 14:54:25 -05:00
Tom Morris
80b85dd6df Remove unused code 2014-12-21 13:15:26 -05:00
Tom Morris
c3d401d479 Fix CSV quote escaping via @annolangen from PR #853 2014-12-21 13:09:50 -05:00
Tom Morris
c4b6f824f0 Fix ClassCastException via @annolangen from PR #853 2014-12-21 13:04:56 -05:00
Pablo Moyano
a1cd605968 fixing bug #799 2013-12-25 13:12:13 -03:00
Tom Morris
eeb082b763 Merge remote-tracking branch 'origin/master' into fusiontables-migration
Conflicts:
	extensions/freebase/module/langs/translation-default.json
	extensions/freebase/module/langs/translation-en.json
	extensions/freebase/module/langs/translation-it.json
	extensions/freebase/src/com/google/refine/freebase/commands/LoadLanguageCommand.java
	extensions/gdata/module/MOD-INF/controller.js
	extensions/gdata/module/langs/translation-default.json
	extensions/gdata/module/langs/translation-en.json
	extensions/gdata/module/langs/translation-it.json
	extensions/gdata/src/com/google/refine/extension/gdata/commands/LoadLanguageCommand.java
	main/src/com/google/refine/commands/lang/LoadLanguageCommand.java
	main/src/com/google/refine/commands/lang/SetLanguageCommand.java
	main/webapp/modules/core/langs/translation-default.json
	main/webapp/modules/core/langs/translation-en.json
	main/webapp/modules/core/langs/translation-it.json
	main/webapp/modules/core/scripts/index/lang-settings-ui.js
2013-08-16 17:56:56 -04:00
Tom Morris
f3b18da0ea Line endings 2013-08-16 16:25:27 -04:00
Tom Morris
f4ff227340 Clean up localization - fixes #760, modifies pull request #755
- make all file loading relative to module base
- move core language files into appropriate place
- eliminate all SetLanguage commands and use SetPreference instead
- eliminate all LoadLanguage commands except for core's
- fix duplicate keys in JSON language files
- remove BOM from JSON language files

OPEN - task 760: Translations not being loaded from built kit 
http://github.com/OpenRefine/OpenRefine/issues/issue/760
2013-07-31 00:31:31 -04:00
Tom Morris
9450d483ce Fix up line endings 2013-07-29 15:49:20 -04:00
Tom Morris
00dd7f2bdd Merge branch 'master' into fusiontables-migration
Conflicts:
	.classpath
	extensions/gdata/module/MOD-INF/controller.js
	extensions/gdata/src/com/google/refine/extension/gdata/GDataImporter.java
2013-07-25 16:13:04 -04:00
Tom Morris
1e5f89e84c Centralize handling of import job config object & synchronize to allow
multiple accessors
2013-07-25 15:41:08 -04:00
Blakko
e6e6c8c002 Added a "Language Settings" menu at index
Now the language manually set has priority over the browser lang
Update translations
2013-07-12 11:12:33 +02:00
Blakko
696eccc872 gdata-extension internationalization 2013-06-27 17:25:53 +02:00