Commit Graph

213 Commits

Author SHA1 Message Date
Antonin Delpeuch
1d6226b095
Merge pull request #1594 from OpenRefine/wikidata/better-format-feedback
Give better feedback when values with invalid formats are provided.
2018-05-22 23:56:24 +02:00
Isao Matsunami
5bdcfddc95
added a file for Japanese 2018-05-19 02:04:10 +09:00
Antonin Delpeuch
844e288955 Fix inverse constraint test for Wikidata extension.
The inverse constraint on the part of property was removed.
2018-05-18 10:52:48 +02:00
Antonin Delpeuch
811b96551c Fix failing test in WbDateVariable 2018-05-06 18:29:07 +02:00
Antonin Delpeuch
484ae48c95 Give better feedback when values with invalid formats are provided. 2018-05-06 18:03:28 +02:00
Antonin Delpeuch
ee59a5037c Add test for numeric cells in Wikibase date parsing 2018-04-28 11:26:22 +02:00
Antonin Delpeuch
97e16d6e8e Add number of edits in preview and upload dialog 2018-04-28 11:25:49 +02:00
Antonin Delpeuch
f9a1a5ba18 Cleanup vocabulary for export (perform -> upload) in Wikidata extension 2018-04-28 10:56:51 +02:00
Antonin Delpeuch
68d9f448c6 Style tweaks to the Wikidata schema UI 2018-04-28 10:55:15 +02:00
Antonin Delpeuch
ff59ed7bb6 Parse dates in UTC in Wikidata extension 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
adfa60ef14 Fix scrolling in Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
60db2828a8 Add spinner to indicate that Wikidata preview is in progress 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
5fda43a5c7 Make edit summaries mandatory 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
2d549b79f1 Prevent double clicks with e.preventDefault in Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
c71bc9096c Cache results in datavalue rendering 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
3bf3f84ca6 Cap number of terms and statements displayed in the preview 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
cb81da0923 Fix display of column variables in the schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
30defdd2c4 Add save and discard buttons on the Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
0c21d6d171 Refuse reconciled cells with invalid space 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
d6232efd95 Refresh the column variables when changes are made 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
02f908b827 Fix appearance of inputs in Firefox for Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
eed1049df3 Add schema unsaved warning 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
d8d7e82be1 Restore preview tab 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
41eb14f3c0 Move the schema and issues to their own tabs in the main UI 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
21436340cd Add more client-side field validation 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
0961ff2949 Refuse empty strings in Wikidata schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
b1e368e7a8 Infer precision from engineering notation of quantity values 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
ec6d0eec64 Add workaround for issue in QuantityValue serialization.
https://github.com/Wikidata/Wikidata-Toolkit/issues/341
2018-04-27 09:17:33 +02:00
Antonin Delpeuch
81a18777cb Replace QS preview by visual preview of the edits 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
2779eb97da Add colors to signal when a suggest input has been validated or not 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
a4ece8ef6a Prettify the schema UI 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
6e4dfe67af Fix bug conflating new items 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
112f3f9308 Fix tests 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
8fab42ce8f Add error message when saving an incomplete schema 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
1d5ffddf90 Cleanup console.log 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
7ded62d78e Fix UI for quantity values 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
9583053b1b Fix Codacy issues 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
2b8ef7a9ae Improve rendering of suggest fields in Firefox 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
761f885348 Fix missing label for QS export 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
54b25d714b Speed up parsing and tweak edit comment 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
1eaaa00824 Fix typo 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
e9ce0fa59c Flatten scrutinizer hierarchy, optimize schema deserialization 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
46964862bc Change format of edit batch id 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
68e0a899b8 Use logger for JSON exception 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
7f1cfd2db7 Address review comments 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
580c0bed80 Fix ConnectionManager and add test for LoginCommand 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
3a58c6824d Prettify the UI and add a token to the edit summaries 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
999b1d4920 Update snapshot of WDTK 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
0b14a1a627 Add license headers, general cleanups on Java files 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
d6b229f25e Add support for all Wikibase datatypes 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
03c7674858 Fix siteIRI of new item ids (switch to SITE_LOCAL) 2018-04-27 09:17:33 +02:00
Antonin Delpeuch
975c3529cb Add UI support for quantity values and tidy up interface 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
15ba7fbdde Schema editing cleanup 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
6cb4386e64 Tweak the schema alignment UI 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
6b658fe87e Some rudimentary testing of operations and changes 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
a002468e7d Better testing of the editing process 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
773be2e161 Introduce a rewriter to update references to new items after creation 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
7cb8757028 Test the commands 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
973a28cc90 Test the scrutinizers 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
fd7462f749 Testing for QuickStatements exporter 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
bb044612e0 Introduce a scheduler package to reorganize item updates 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
88178d7c04 Refactor ItemUpdate and introduce ItemUpdateBuilder 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
e0cdb91520 Better testing for the schema package 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
6f9636176b Add a lot of tests in the schema 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
7cae9455da Test (and fix) ReconEntityIdValue 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
b48c78a617 Refactor and test QS value printing 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
1837926cb1 Add quantity expressions in the backend 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
487547bd27 Finish localization of the wikidata extension 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
d3023008e9 Localize perform edits dialog 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
9489cc95f0 Split js files for issues rendering 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
9513807a83 Display issues in perform edits dialog 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
1c51b32458 Fix storage of Wikibase credentials, to be updated with better serialization later on 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
ab642a52a1 Explicitly add server tests dir in classpath 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
056d0d18b0 Update JSONWriter constructor for the newer version 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
305c3a7bb9 Update WDTK jars with latest features 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
708ff44f2f Check for language code validity in WbLanguageVariable 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
75b1863c1c Testing for variables which generate wikibase values 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
fffd31382e Ignore unknown fields in schema JSON deserialization 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
8b1869414d Improve styling of schema alignment dialog 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
c845105a39 Cleanup JSON serialization and rename WbValueExpr to WbExpression 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
b99b72b071 Refactor schema expressions 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
a476b2bf0a Restore progress computation 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
0a18d61372 Request items by batches instead of one-by-one 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
54acac491d Fix EntityIdValue generation from Recon: discard nones 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
22c1d5dd9b Edit as bot by default 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
8cc282a502 Fix null pointer exception in NewItemLibrary 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
ad9d7f9f0e Update wdtk to newer snapshot 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
699ec16082 Report duplicate items in DistinctValuesScrutinizer 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
212b1b3dd3 Fix siteIRI of ReconEntityIdValues 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
784e866b4e Add scrutinizer for whitespace issues 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
42d9ca0393 Add explicit @JsonProperty decorators in schema classes 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
93883fd777 Add warning for monolingual exprs without language 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
69bfad6a47 Change architecture of custom EntityIdVales 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
43f0348ee9 Fix TermedEntityIdValue hashing 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
30ce8680c5 Add architecture to emit warnings during evaluation too 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
2687741263 Fix exceptions when constraints are not or incorrectly provided 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
6c6151ca43 Skip empty strings as values in the schema 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
bf7000e601 Move exceptions to own package 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
5d9aa9cae5 Add distinct values scrutinizer 2018-04-27 09:17:32 +02:00
Antonin Delpeuch
7518d194f0 Display the number of issues in the tab header 2018-04-27 09:17:32 +02:00