Commit Graph

727 Commits

Author SHA1 Message Date
David Huynh
d7f7d50e16 Fixed Issue 14: Limiting Freebase load to starred records
git-svn-id: http://google-refine.googlecode.com/svn/trunk@853 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 23:01:34 +00:00
Iain Sproat
3ac3feb01f opencsv-2.2.jar patched so that CsvWriter only selectively applies quotation marks around values when escape, line break, nested quotation marks or separator characters are encountered. Patch submitted to opencsv project as https://sourceforge.net/tracker/?func=detail&aid=3006635&group_id=148905&atid=773543
CsvExporter makes use of patched opencsv-2.2.jar. Quotation marks are only applied selectively.

CsvExporterTests fixed to correctly assign cellIndex when creating columns.

TsvExporterTests fixed to correctly assign cellIndex when creating columns.  Two broken tests now work.  Three tests are still marked as broken.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@851 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 22:01:37 +00:00
David Huynh
c6827fe242 Fixed issue 58: Meta facet
git-svn-id: http://google-refine.googlecode.com/svn/trunk@848 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 19:04:55 +00:00
Iain Sproat
433a047fb6 Added tests for TsvExporter - all are broken (may be the tests themselves, as they are copied from CsvExporterTests).
CsvExporter now closes writer.  CsvExporterTests includes test for a string with a comma.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@847 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 18:37:52 +00:00
David Huynh
38d5b3dbde Small refactoring: introduced RowEvaluable interface to abstract out the evaluation of an expression on a row.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@846 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 17:14:54 +00:00
Iain Sproat
015b5a92ae CsvExporter is linked to the UI, and should fully work. Unit Tests now assert that null cells can be handled by CsvExporter. CHANGES.txt is now updated to reflect Issue 59.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@845 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 12:36:35 +00:00
Iain Sproat
53e20da8f4 Issue 59 (part) - added CsvExporter and unit test to server side code. Not linked to UI.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@844 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-24 12:15:45 +00:00
David Huynh
ae1ce4ce79 Fixed issue 53: Moving the cursor inside the Text Filter box by clicking.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@843 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-23 17:33:37 +00:00
David Huynh
5fa1e2a552 Fixed Issue 55: Use stable sorting for text facets sorted by count.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@841 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-22 02:28:18 +00:00
David Huynh
23c02b870a Implemented "reorder rows" feature.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@840 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-22 01:39:27 +00:00
David Huynh
bfc7ef7739 Re-organized operations.* classes into sub-packages.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@839 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 18:15:13 +00:00
David Huynh
c5443d95eb New packages for re-organizing operations.* classes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@838 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 17:43:54 +00:00
David Huynh
4e6b915bc1 When sorting, it's now possible to specify where to put blanks and errors relative to the valid values.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@837 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 04:46:36 +00:00
David Huynh
369a02043c More work on sorting:
- added "sorted" drop down menu to data table view if it's sorted.
- set forward and reverse radio button labels depending on value type.
- don't use a whole submenu for sorting if a column isn't sorted yet.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@836 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 04:11:08 +00:00
David Huynh
80a199b4a9 Started to hook up sorting. You can sort on one column right now but there's no indicator after you've done sorting.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@835 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-21 00:48:36 +00:00
David Huynh
496823e564 Added start() and end() methods to RowVisitor and RecordVisitor so visitors can do things before and after all visitations.
Added sorting package. It's not hooked up, yet.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@834 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 22:10:34 +00:00
David Huynh
0709ec3f92 Fixed issue 46: Array literals in GEL
git-svn-id: http://google-refine.googlecode.com/svn/trunk@833 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 17:49:20 +00:00
David Huynh
bf6ba51700 Facet panel now resizes its children properly.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@832 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 06:28:00 +00:00
David Huynh
e1feec436a Made data table view render "rows" or "records" depending on the mode.
Got rid of "show dependent rows" and replaced it with 2 radio buttons for the 2 modes: row-based vs. record-based.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@831 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 05:49:13 +00:00
David Huynh
ef2079d0d8 Re-organization of classes in the browsing.* packages.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@825 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 00:33:13 +00:00
David Huynh
598258a326 New package.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@824 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 00:27:57 +00:00
David Huynh
28ca652dea More row/record model refactoring work. Everything should still be working almost as before, except contextual rows are not shown in row-based mode.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@823 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-20 00:13:19 +00:00
Iain Sproat
ec7ac81246 Applying Tom Morris's patch to GridworksServlet.(issue #48). GridworksServlet creates classes from a string, so is no longer dependent on (imports) any of the Command Classes.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@821 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-19 07:09:40 +00:00
David Huynh
1e737e3238 Factored row dependency code from Row class and Project class out as Record and RecordModel classes.
Simplified RdfTripleImporter.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@820 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-19 04:22:45 +00:00
David Huynh
e1861eb1d9 Let the RdfTripleImporter handle .rdf and application/rdf+xml files.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@819 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 21:28:31 +00:00
Iain Sproat
0e4682f453 RdfTripleImporter handles row dependencies.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@818 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 21:08:37 +00:00
Iain Sproat
cfd0f2219e RdfTripleImporter does basic reconciliation on Rdf subject - data model is no longer sparse (now possible to have more than one data point per row)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@816 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 13:48:52 +00:00
Iain Sproat
043f46c562 RdfTripleImporter correctly adds empty cells to existing rows when a column is added.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@815 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 13:04:51 +00:00
Iain Sproat
311cc14dcd adding ommitted libraries for r813
git-svn-id: http://google-refine.googlecode.com/svn/trunk@814 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 12:49:24 +00:00
Iain Sproat
25d3a9dfc1 Added a basic RDF triple importer plus unit tests. Some more work required - it's not plugged into the client and it creates a very sparse data structure (each triple is a new row). It uses JRDF library (Apache 1.1 license).
git-svn-id: http://google-refine.googlecode.com/svn/trunk@813 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 12:41:40 +00:00
David Huynh
c9303a884d The process widget was catching all keystrokes with meta or ctrl flag and performed an undo. We actually need to test for ctrl-z or meta-z.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@812 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 02:52:02 +00:00
Stefano Mazzocchi
5d4ce3fee2 updating about page
git-svn-id: http://google-refine.googlecode.com/svn/trunk@811 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 00:37:00 +00:00
Stefano Mazzocchi
18ce4b68b7 avoid showing the version number when running trunk
git-svn-id: http://google-refine.googlecode.com/svn/trunk@810 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 00:30:26 +00:00
David Huynh
ee82ec2642 Issue 45: "Renaming Cells with Ctrl-Enter produced ERROR"
Tentative fix by sprinkling in "synchronized".


git-svn-id: http://google-refine.googlecode.com/svn/trunk@809 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-18 00:02:58 +00:00
Stefano Mazzocchi
6c9ef24336 lower verbosity of scatterplot generation
git-svn-id: http://google-refine.googlecode.com/svn/trunk@808 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 23:59:56 +00:00
David Huynh
0c70d281c7 Issue 28: mql-like preview is not properly unquoting numbers.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@807 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 23:47:09 +00:00
Stefano Mazzocchi
5ec73daabe logging more changes
git-svn-id: http://google-refine.googlecode.com/svn/trunk@806 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 23:28:44 +00:00
David Huynh
fa2be33709 Fixed issue 16: Column name collision when adding data from Freebase.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@804 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 21:33:46 +00:00
David Huynh
4cf476630e Fixed issue 15: Ability to rename projects - added rename command in both index.html and project.html (main menu bar)
Updated CHANGES.txt with other fixes committed previously.
Made sure releases.js doesn't hold up the initialization code of project.html.
Some polishing on the rendering of projects' last modified dates in index.html.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@799 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 19:22:58 +00:00
Stefano Mazzocchi
2cf360b723 adding even runtime jars to the eclipse build path so that people running gw from IDEs don't get ClassNotFound messages at runtime
git-svn-id: http://google-refine.googlecode.com/svn/trunk@798 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 16:35:20 +00:00
Iain Sproat
092d4602b9 TsvCsvImporter passes all unit tests. TsvCsvImporter again uses opencsv library.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@797 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 11:57:26 +00:00
Iain Sproat
648e7ee5fa 'broken' exclusion test group added to tests.xml configuration file.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@796 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 10:19:19 +00:00
Iain Sproat
fcdb926e94 TsvCsvImporterTests tests are parameterized, so that both TsvCsvRowParser and SeparatorRowParser are both tested without writing additional tests.
Removed enabled=false as the ./gridworks file should exclude group 'broken', the indicator for failing tests.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@795 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 10:12:21 +00:00
Iain Sproat
7886016dd1 Test added to TsvCsvImporterTests for multiple blank lines in quoted CSV value, see issue #19. Test does not pass, so is enabled=false and grouped as 'broken'.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@794 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 07:03:19 +00:00
Iain Sproat
075e985865 Rename CSVRowParserTests to TsvCsvRowParserTests.
TsvCsvImporterTests - identified 3 tests which now fail when using different parser.  Tests are enabled=false and in 'broken' testing group.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@793 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 06:50:30 +00:00
Iain Sproat
03b1ab01f4 RowParser is no longer a parameter of read method in TsvCsvImporter (now handled in the method itself)
CSVRowParserTests is now tidied - with expected and actual being input into the correct parameters of Assert.assertEquals.  One more test passes, but still 2 tests failing.


git-svn-id: http://google-refine.googlecode.com/svn/trunk@792 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 06:24:58 +00:00
David Huynh
71b08ebdd9 Added TSV test file for issue 19.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@791 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:55:43 +00:00
David Huynh
bd8d214a49 Resolved issue 19 for TSV as well, not just for CSV.
Touched up TsvCsvImporterTests to leave the comma vs. tab guessing to the importer itself. All tests still pass.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@790 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:55:02 +00:00
Iain Sproat
6f74bcaa26 comments tidied in TsvCsvImporterTests and ImporterUtilities
git-svn-id: http://google-refine.googlecode.com/svn/trunk@789 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:40:46 +00:00
David Huynh
68fbd3320b Got disabled tests in Issue 41 to pass.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@788 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-17 05:26:29 +00:00