Commit Graph

2570 Commits

Author SHA1 Message Date
dependabot-preview[bot]
e081961c1f
Bump testng from 7.1.0 to 7.3.0
Bumps [testng](https://github.com/cbeust/testng) from 7.1.0 to 7.3.0.
- [Release notes](https://github.com/cbeust/testng/releases)
- [Changelog](https://github.com/cbeust/testng/blob/master/CHANGES.txt)
- [Commits](https://github.com/cbeust/testng/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-03 09:01:36 +00:00
Tom Morris
0ebd89c952
Clustering dialog choices limit & performance improvements - fixes #695 (#2996)
* Clustering dialog choices limit & performance improvements - fixes #695

Fixes #695
- Caps the total number of choices displayed at 10,000 and warns when
  over the limit. Users can use facets to tune which clusters are displayed.
- Doubles the performance of the Javascript processing
- Only displays count of rows for a choice if it's > 1 to DOM elements
- Adds internationalization for row count

For 41K clusters containing 118K choices, processing dropped from
3m20s to 1m20s, but with the 10K choice cap total time is ~10sec.

* Restore even/odd row class

* Updates from review feedback
2020-08-01 10:59:41 +02:00
Tom Morris
5985f95ce1
Explicitly set SameSite=Lax on cookie - fixes #3007 (#3014) 2020-08-01 10:58:16 +02:00
Lisa Chandra
1dcc83209c
Faster rendering of rows and cells (#2973)
* changes to rendering of rows

* some cell rendering improvements

* more render row improvements

* fixed jQuery methods on js elements

* added comment for nbsp
2020-07-28 18:25:32 +02:00
Tom Morris
db42bcab92
Update to vicino 1.2 and drop transitive dependencies - fixes #2959 (#2998)
Bump to vicino 1.2 with bug fix and real POM.

Drop dependencies on secondstring and arithcode which are just
transitive dependencies from simile-vicino, now that it has a
proper POM. Fixes #2959.
2020-07-28 08:19:58 +02:00
dependabot-preview[bot]
d258e9bd05
Bump commons-text from 1.8 to 1.9
Bumps commons-text from 1.8 to 1.9.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-27 08:30:43 +00:00
Chetan Verma
86ec7e6b40
Give the name to button 'Back' (#2989)
* Give the name to button 'Back'

* Using DOM to add name of button
2020-07-26 09:08:50 +02:00
Chetan Verma
602149db6e
Fix Import Project form to check for the presence of a file (#2979) 2020-07-25 09:45:45 +02:00
Tom Morris
a49ce47a87
Merge pull request #2919 from tfmorris/2917-butterfly-1.0.4
Update to Butterfly 1.0.4 - fixes #2917
2020-07-23 14:14:37 -04:00
Tom Morris
83ed9ffdaf
Refactor importer APIs - Fixes #2963 (#2978)
* Make sure data directory is directory, not a file

* Add a test for zip archive import

Also tests the saving of the archive file name and source filename

* Add TODOs - no functional changes

* Cosmetic cleanups

* Revert importer API changes for archive file name parameter

Fixes #2963
- restore binary compatibility to the API
- hoist the handling of both fileSource and archiveFileName from
TabularImportingParserBase and TreeImportingParserBase to
ImportingParserBase so that there's only one copy. These 3 classes are
all part of the internal implementation, so there should be no
compatibility issue.

* Revert weird flow of control for import options metadata

This reverts the very convoluted control flow that was introduced
when adding the input options to the project metadata. Instead
the metadata is all handled in the importer framework rather than
having to change APIs are have individual importers worry about
it.

The feature never had test coverage, so that is still to be added.

* Add test for import options in project metadata & fix bug

Fixes bug where same options object was being reused and overwritten,
so all copies in the list ended up the same.
2020-07-23 18:36:14 +02:00
Tom Morris
7512f3cb52 Update to Butterfly 1.0.4 - fixes #2917
Fixes #2917
Update to Butterfly 1.0.4 which catches NoClassDefFound errors
for Butterfly modules (ie OpenRefine extensions) which are missing
Java dependencies (e.g. those built against earlier versions
of OpenRefine)
2020-07-23 12:21:24 -04:00
Tom Morris
d5abaac6df
Update marc4j to 2.9.1 - Fixes #2962 (#2977)
* Add a MARC import test

* Make sure data directory is directory, not a file

* Update to marc4j 2.9.1 - fixes #2962
2020-07-22 22:12:30 +02:00
Tom Morris
8cfdd5747a
Merge pull request #2952 from OpenRefine/dependabot/maven/org.mockito-mockito-core-3.4.2
Bump mockito-core from 3.3.3 to 3.4.2
2020-07-17 13:07:42 -04:00
Tom Morris
5336eca63e Remove redundant mockito dependencies 2020-07-17 12:48:06 -04:00
dependabot-preview[bot]
edf8595977
Bump mockito-core from 3.3.3 to 3.4.2
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.3.3 to 3.4.2.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v3.3.3...v3.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-17 08:17:43 +00:00
dependabot-preview[bot]
0f391b5343
Bump commons-lang3 from 3.10 to 3.11
Bumps commons-lang3 from 3.10 to 3.11.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-17 08:17:12 +00:00
Antonin Delpeuch
858bd463a4 Revert "Bump git-commit-id-plugin from 4.0.0 to 4.0.1 (#2948)"
The dependency update broke the snapshot release process on GitHub Actions:
https://github.com/OpenRefine/OpenRefine/runs/876878262

This reverts commit 52bb2c4d38.
2020-07-16 11:07:54 +02:00
dependabot-preview[bot]
52bb2c4d38
Bump git-commit-id-plugin from 4.0.0 to 4.0.1 (#2948)
Bumps git-commit-id-plugin from 4.0.0 to 4.0.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-16 11:01:43 +02:00
Tom Morris
f2e61b6628
Add tests for wide XLS/XLSX export (#2945)
Refs #2122. Also reenable a couple of disabled tests
2020-07-16 10:01:17 +02:00
Tom Morris
a3fab26cca
Fix the text format guesser so it doesn't inappropriately guess WikiText (#2924)
* Fix text guesser so it doesn't guess wikitext

Fixes #2850
- Add simple magic detector for zip & gzip files to keep
  it from attempting to guess binary files
- Add a counter for C0 controls for the same reason
- Tighten wikitable counters to require marker at
  beginning of the line, per the specification
- Refactor to use Apache Commons instead of private
  counting methods
- Add tests for most TextGuesser formats

* Remove misplaced duplicate test data file

* Fix LGTM warning + minor cleanups

* Use BoundedInputStream to prevent runaway lines
2020-07-15 08:56:00 +02:00
Hosted Weblate
f9d6c2b93b
Merge branch 'origin/master' into Weblate. 2020-07-14 22:41:55 +02:00
Isao Matsunami
a2100f64f7
Translated using Weblate (Japanese)
Currently translated at 100.0% (753 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ja/
2020-07-14 22:41:51 +02:00
Tom Morris
561619399c
Fix order dependent NPE in LoadLanguage test (#2922)
* Ensure ProjectManager is initialized before test - fixes #2895

* Fix indentation (detabify)
2020-07-14 18:06:04 +02:00
Tom Morris
ed68541988
Remove informational logging from tests that are passing (#2923)
* Change logging from info to debug

* Make tests less chatty when they're passing
2020-07-14 17:47:36 +02:00
Urvashi Gupta
f00129b852
fixes service panel toggling (#2915) 2020-07-14 16:46:10 +02:00
Tom Morris
233cb95289
Ignore events which don't change text input - fixes #1134 (#2846)
* Ignore events which don't change text input - fixes #1134

* Fix bind
2020-07-14 08:35:46 +02:00
dependabot-preview[bot]
396efc0d1b
Bump mockwebserver from 4.7.2 to 4.8.0
Bumps [mockwebserver](https://github.com/square/okhttp) from 4.7.2 to 4.8.0.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/square/okhttp/compare/parent-4.7.2...parent-4.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-13 08:39:23 +00:00
Allan Nordhøy
98b64b7a01
Translated using Weblate (Norwegian Bokmål)
Currently translated at 51.6% (389 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/nb_NO/
2020-07-12 13:41:50 +02:00
Rafael Fontenelle
f329f5085b
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (753 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/pt_BR/
2020-07-12 13:41:49 +02:00
Hosted Weblate
6c69525545
Merge branch 'origin/master' into Weblate. 2020-07-11 12:55:18 +02:00
Allan Nordhøy
128a3089ed
Translated using Weblate (Norwegian Bokmål)
Currently translated at 51.1% (385 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/nb_NO/
2020-07-11 12:55:18 +02:00
Rafael Fontenelle
b0177e6e33
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (753 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/pt_BR/
2020-07-11 12:55:17 +02:00
Isao Matsunami
1a7ae77431
Translated using Weblate (Japanese)
Currently translated at 100.0% (753 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ja/
2020-07-11 12:55:17 +02:00
Tom Morris
306b541c69
Fix Excel date import - Fixes #1908 (#2909)
* Add utility functions to check/convert dates

* Add date tests and refactor to DRY up

* Fix date import - fixes #1908

Change from java.util.Date to OpenRefine 3.0+'s OffsetDateTime
Fixes #1908

* Centralize date conversion

* Moving utility methods to ParsingUtilities

* Fix tests
2020-07-09 23:13:44 +02:00
Urvashi Gupta
a0f2d11255
addStandardServiceOnEnter (#2914) 2020-07-09 22:57:24 +02:00
dependabot-preview[bot]
380942d53f
Bump httpmime from 4.5.2 to 4.5.12 (#2904)
Bumps httpmime from 4.5.2 to 4.5.12.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-08 10:29:09 +02:00
Tom Morris
0562638ffa
Use standard text normalization - fixes #2898 (#2900)
* Use standard text normalization - fixes #2898

Fixes #2898. Fixes #409. Refs #650

Replaces homegrown ISO Latin-1 only character subsitition
with standard Java Normalize to NFD, followed by diacritic
removal and a few custom character expansions/replacements.

* Fix Mac build

* Improve compatibility with previous code

One intentional change is folding O with stroke to
oe instead of o.

- Use more powerful NFKD instead of NFD
- strip punctuation after decomposition since it can generate
  new punctuation
- Add compatibility test for old asciify() method
- Add some graphically similar characters to substitution table

* Add oe character/ligature & more long S forms

* More tests for ligatures and Latin Extended

* Add Latin-1 Supplement tests
2020-07-07 21:35:41 +02:00
Urvashi Gupta
f62f63706c
Report HTTP error codes to the user when creating a project from a URL (#2870)
* HTTP Error

* urlImportingTestCompleted
2020-07-07 11:58:47 +02:00
Tom Morris
e61d50a1aa
Fix NGramFingerprintKeyer to ignore accents - fixes #1161 (#2899)
Fixes #1161
This change parallels what was done in #1257 1da3c00 to fix
the FingerprintKeyer and moves the diacritic removal before
the deduping. Includes a test.
2020-07-07 09:02:49 +02:00
morrme
66aeaa4409
Remove incorrect "dates" from guess data type label - fixes #2883
Fixes #2883.
2020-07-06 19:55:23 -04:00
Hosted Weblate
f421cfd76f
Merge branch 'origin/master' into Weblate. 2020-07-06 03:42:12 +02:00
Tijs De Schacht
dfcd5a0f25
Translated using Weblate (Dutch)
Currently translated at 54.4% (410 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/nl/
2020-07-06 03:42:08 +02:00
Mohamed El ouard Baouche
a6a5935585
Translated using Weblate (Arabic)
Currently translated at 5.8% (44 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ar/
2020-07-06 03:41:49 +02:00
Isao Matsunami
948d1acae1
Translated using Weblate (Japanese)
Currently translated at 100.0% (753 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ja/
2020-07-06 03:41:49 +02:00
Tom Morris
8a6171432d
Translated using Weblate (French)
Currently translated at 99.0% (746 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/fr/
2020-07-06 03:41:48 +02:00
Tom Morris
3717111db8
Fix Open Office Spreadsheet (ODS) dates (#2843)
* Truncate any completely empty columns on the right

Fixes #565
The current versions of Open Office create default spreadsheets
with over 1000 empty columns. Keep track of the rightmost
non-empty column when importing and truncate everything else.

Also adds a basic ODS import test.

* Fix dates in ODS spreadsheets

Fixes #2224
2020-07-04 08:42:33 +02:00
Antonin Delpeuch
f4692de9e1 Increase maximum wait for testInvalidUrl, follow-up for #2876 #2875 2020-07-03 21:48:43 +02:00
Tom Morris
df8d092132
Micro benchmark harness & ToNumber optimizations (#2859)
* Performance optimized version of ToNumber

Approximately 5x faster for floats (data dependent)
and about the same speed for integers.

- Instead of blindly trying to parse as Long, do a quick check
  for obvious problems (e.g. decimal point).
- Don't trim. It's already done by called methods.
- Use valueOf() instead of parse() to avoid object creation

* Add Java Microbenchmark Harness

The shaded JAR is missing the OpenRefine classes, for a reason
that I haven't figured out, so requires openrefine-main.jar at runtime.

* Remove old implementations of ToNumber

* Remove unneeded dependencies from main project

* Clean up and reformat
2020-07-03 21:42:44 +02:00
Tom Morris
5d6af9cb6c
Merge pull request #2865 from tfmorris/2863-tree-column-ordering
Remove shortest-column-name ordering - fixes #2863
2020-07-03 15:23:36 -04:00
Tom Morris
f5786afa35
Increase test timeout - fixes #2875 (#2876) 2020-07-03 21:20:01 +02:00