Commit Graph

672 Commits

Author SHA1 Message Date
Stefano Mazzocchi
f28e23e503 Committing patches by Iain:
- use OpenCSV parser instead of our own
 - use TestNG instead of JUnit which is a lot more configurable in test selection (and allows us to do a much better job a leaving the tree green even while developing tests that are known to fail)
 - integrated TestNG in './gridworks test'
 - added Iain to the list of contributors in README.txt
 - changed the Eclipse test launch file to use the TestNG launcher (unfortunately, this is not shipped by default in Eclipse, so you have to install it yourself from the http://beust.com/eclipse update file, I'll add this to the wiki shortly)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@782 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-16 18:42:52 +00:00
Stefano Mazzocchi
c3934c041f fixing mime type (no functional change)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@781 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-16 16:40:00 +00:00
Stefano Mazzocchi
828acfc694 better way to ignore tests
git-svn-id: http://google-refine.googlecode.com/svn/trunk@780 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-15 03:12:23 +00:00
Stefano Mazzocchi
2afe01414d we don't need these classes any longer
git-svn-id: http://google-refine.googlecode.com/svn/trunk@779 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-15 02:47:55 +00:00
Stefano Mazzocchi
9f1358ea38 comment out tests that don't pass
(leaving the tree in a broken state is a nono)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@778 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-15 02:45:54 +00:00
Iain Sproat
9b2aa5290c split method of CSVRowParserTests is now unit tested. 3 tests fail (related to issue #19) - behaviour of CSV importer needs some further work.
logger now correct on GridworksServletTests


git-svn-id: http://google-refine.googlecode.com/svn/trunk@777 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 22:34:50 +00:00
David Huynh
ae986ebe49 Text search facet didn't reconstruct from permalink properly.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@771 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 19:33:59 +00:00
David Huynh
1a87d672cf Browsing engine didn't initialize properly from permalink: it triggered an update when other parts of the UI hadn't been constructed.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@770 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 19:27:01 +00:00
Iain Sproat
624b421da9 doGet and doPost methods of GridworksServlet now unit tested. @Ignore attribute added to GridworksServletStub to prevent ./gridworks server_test failing.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@769 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 17:34:40 +00:00
David Huynh
6450921c02 Fixed issue 4: Match All bug with ZIP code.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@767 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 17:03:33 +00:00
David Huynh
bd87e079b2 Fixed issue 34: Behavior of Text Filter is unpredictable when "regular expression" mode is enabled.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@766 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 16:51:31 +00:00
Iain Sproat
0af4e294f8 GridworksServlet is now unit tested with a single regression test
git-svn-id: http://google-refine.googlecode.com/svn/trunk@765 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-14 14:57:04 +00:00
Stefano Mazzocchi
2703457863 - use the OS's temporary dir instead of an internal dir
- make windmill exit after the tests, silence some of its output and make the test results get out


git-svn-id: http://google-refine.googlecode.com/svn/trunk@760 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 22:44:19 +00:00
Stefano Mazzocchi
ea459aed07 Applied a bunch of patches from Tom Morris (Issue 25, 26 and 27)
- make java6 dependency explicit in eclipse project files
- avoid using NotImplementException especially the sun.* one
- avoid using internal sun signal handling and rely on standard java.* APIs
 (I tested this one and it seems to be working fine)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@756 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 21:02:19 +00:00
Iain Sproat
a096fae7a0 ParsingUtilities.evaluateJsonStringToObject is now unit tested
CommandTests and CancelProcessesCommandTests are slightly formatted to match code standards.
Command and CancelProcessesCommand are slightly tweaked to pass under all unit tests.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@753 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 09:23:37 +00:00
Stefano Mazzocchi
1f2531f303 uniform newlines and seeting the proper svn controls for native line ending
(so that diffs from windows don't end up all screwed up)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@751 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 02:22:31 +00:00
Stefano Mazzocchi
70a8e46cbe turns out that /? is the default for help on windows
git-svn-id: http://google-refine.googlecode.com/svn/trunk@747 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 01:40:01 +00:00
Stefano Mazzocchi
a7e06721da Issue 23 making gridworks print out the parameters that it was initialized with
(we have to pass them from the command line because there is no way to access it directly from java from the standard java library)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@745 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 01:10:41 +00:00
Stefano Mazzocchi
5070de6446 committing Iain's new tests and polished things a little
(also added a test-specific log4j conf so that we don't show all the warnings during the tests that were distracting)


git-svn-id: http://google-refine.googlecode.com/svn/trunk@744 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-13 00:54:02 +00:00
Stefano Mazzocchi
95b37b876a adding eclipse special files (and a README to explain what these are and how to use them)
Thanks to Tom Morris for the suggestion.


git-svn-id: http://google-refine.googlecode.com/svn/trunk@739 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 23:47:19 +00:00
Stefano Mazzocchi
64b35a6380 fixed the old URL
git-svn-id: http://google-refine.googlecode.com/svn/trunk@738 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 23:40:11 +00:00
David Huynh
a77533151c Properly quote json keys in suggested release version json.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@735 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 23:25:54 +00:00
David Huynh
83bd1a368e Got build script to support building Windows .exe of x.x.x versions.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@732 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 22:57:31 +00:00
Stefano Mazzocchi
93823899b7 adding the first release and dates
git-svn-id: http://google-refine.googlecode.com/svn/trunk@730 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 21:08:21 +00:00
David Huynh
db5d94cadf Added CHANGES.txt file.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@727 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 18:22:06 +00:00
Stefano Mazzocchi
1b9cfbbf90 detabbing (no functional changes)
David, you might want to check your editor settings, you're mixing tabs with spaces


git-svn-id: http://google-refine.googlecode.com/svn/trunk@724 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 09:02:41 +00:00
Stefano Mazzocchi
86465c2d6f forgot these pieces of for the previous commit
git-svn-id: http://google-refine.googlecode.com/svn/trunk@723 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 09:00:38 +00:00
Stefano Mazzocchi
11da70d223 Applying patch for Issue 21 from iainsproat
git-svn-id: http://google-refine.googlecode.com/svn/trunk@722 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 08:59:05 +00:00
Stefano Mazzocchi
fe0afa0bc3 Fixed Issue #18
git-svn-id: http://google-refine.googlecode.com/svn/trunk@721 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 07:53:26 +00:00
David Huynh
8412aa72dd Fixed Issue 17: Conflated triples - all rows are producing triple with "s" :" $Name_0".
Also exposed "id" field for recon objects.

git-svn-id: http://google-refine.googlecode.com/svn/trunk@720 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 07:45:22 +00:00
David Huynh
992cb964eb Fixed Issue 2: Undo History bug. The MassChange class didn't write out each elemental change's class and so they couldn't be read back in.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@719 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 06:35:01 +00:00
David Huynh
59ab6c0a78 Added a CSV file to test fix to issue 19.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@718 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 06:09:34 +00:00
David Huynh
7ad438078f Fixed Issue 19: CSV import is too basic. Quoted cells in a CSV file can now contain line breaks. Added a CSV file to test that.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@717 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 06:07:44 +00:00
Stefano Mazzocchi
c0e006861a d'oh (typo)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@716 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 02:24:44 +00:00
Stefano Mazzocchi
f53449966e make it possible run the ant script without having to pass parameters to it from the ./gridworks script (this helps with IDE integration)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@715 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 02:21:46 +00:00
Stefano Mazzocchi
c5e24fb563 move log4j.properties into the classpath so that it's easier to run gw directly from an IDE
git-svn-id: http://google-refine.googlecode.com/svn/trunk@714 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 02:05:17 +00:00
Stefano Mazzocchi
06da318eef removing jackson sources since they're huge and not really that useful
git-svn-id: http://google-refine.googlecode.com/svn/trunk@713 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 00:25:58 +00:00
Stefano Mazzocchi
8285083fb9 fixing classpath so that gw can be run direclty from eclipse
git-svn-id: http://google-refine.googlecode.com/svn/trunk@712 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-12 00:25:39 +00:00
Stefano Mazzocchi
0813d85712 make sure to recompile the tests everytime because eclipse is actually saving the classes somewhere else
git-svn-id: http://google-refine.googlecode.com/svn/trunk@711 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 22:38:03 +00:00
Stefano Mazzocchi
a643eabc88 fixed eclipse warning
git-svn-id: http://google-refine.googlecode.com/svn/trunk@710 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 18:18:07 +00:00
Stefano Mazzocchi
668b763f6b introducing a wrapper around windmill-js that adds support for macros in order to make it easier to make gridworks-specific UI testing a lot more compact (this is a tiny bit more verbose than the previuos method, but it allows us to group waits with actions and assertions which wasn't possible before, so it's a good price to pay).
git-svn-id: http://google-refine.googlecode.com/svn/trunk@709 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 17:17:34 +00:00
David Huynh
f341fa8db2 Fixed Issue 13: float rejected from sandbox upload as Json object.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@708 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 06:45:49 +00:00
David Huynh
114be582e8 Fixed issue 5: Localized Windows cause save problems for Gridworks. jdatapath library returns a path in which each unicode character (in the user ID) has been replaced by ?. So we need to grab the actual user ID from environment variables such as APPDATA or USERPROFILE.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@707 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 04:16:26 +00:00
Jeff Fry
3d59ba713e minor edits.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@706 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 00:46:44 +00:00
Jeff Fry
938bcfe7b0 added waits to get additional asserts to succeed. working on numeric filter
git-svn-id: http://google-refine.googlecode.com/svn/trunk@705 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-11 00:45:05 +00:00
Stefano Mazzocchi
a626ea51ff if the user's computer's clock is not synchronized with Freebase's, the initial oauth handshake will fail because Freebase believe there is a replay attack going on. To avoid that we ask Acre to tell us what time it is in Freebase land and we sign the request with that instead. We default back to the user clock only if Acre is down or swamped.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@704 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 23:24:58 +00:00
David Huynh
60ef31012a Check for missing "target" in protograph link node's serialized json object when reloading from project files.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@702 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 20:49:45 +00:00
David Huynh
2161255cdb Fixed issue 11: missing "lang" attribute in MQL generated in schema alignment.
git-svn-id: http://google-refine.googlecode.com/svn/trunk@700 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 20:08:53 +00:00
Stefano Mazzocchi
861516cd92 Applying patch for Issue 9 (thanks again to iainsproat)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@685 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 16:06:07 +00:00
Stefano Mazzocchi
b23f6e0fa1 Issue 6: fixed by applying patch from iainsproat (thanks!)
git-svn-id: http://google-refine.googlecode.com/svn/trunk@684 7d457c2a-affb-35e4-300a-418c747d4874
2010-05-10 15:52:45 +00:00