code refactor

src/ap_mine.py

@@ -1,6 +1,5 @@
-#anti-personnel mine
+from mine import Mine
-from src.mine import Mine
 
 
-class AP_Mine(Mine):
+class APMine(Mine):
-    pass
+    pass

src/at_mine.py

@@ -1,6 +1,5 @@
-#anti-tank mine
+from mine import Mine
-from src.mine import Mine
 
 
-class AT_Mine(Mine):
+class ATMine(Mine):
-    pass
+    pass

src/environment.py

@@ -1,13 +1,14 @@
 from typing import List
 from random import choices
-from fieldsFactory import FieldsFactory
+
 from field import Field
+from fieldsFactory import FieldsFactory
 
 
 def generate_field () -> List[List[Field]]:
-    fieldsFactory = FieldsFactory()
+    fields_factory = FieldsFactory()
-    fieldsList = fieldsFactory.getFieldsList()
+    fields_list = fields_factory.get_fields_list()
-    return [choices(fieldsList, weights=[10, 10, 4, 4, 4, 4, 4, 4, 4, 4, 4], k=10) for _ in range(10)]
+    return [choices(fields_list, weights=[10, 10, 4, 4, 4, 4, 4, 4, 4, 4, 4], k=10) for _ in range(10)]
 
 
 class Environment:

src/field.py

@@ -1,4 +1,4 @@
 class Field:
-	def __init__(self, number, isMined):
+	def __init__(self, number: int, is_mined: bool):
 		self.number = number
-		self.isMined = isMined
+		self.is_mined = is_mined

src/fieldsFactory.py

@@ -1,13 +1,14 @@
 from typing import List
+
 from field import Field
 
 
 class FieldsFactory:
-	def createField(self, number) -> Field:
+	def create_field(self, number: int) -> Field:
 		if number > 3:
 			return Field(number, True)
 		else:
 			return Field(number, False)
 	
-	def getFieldsList(self) -> List[Field]:
+	def get_fields_list(self) -> List[Field]:
-		return [self.createField(i) for i in range(11)]
+		return [self.create_field(i) for i in range(11)]

src/mine.py

@@ -1,3 +1,3 @@
 class Mine:
-    def __init__(self, isArmed):
+    def __init__(self, is_armed: bool):
-        self.isArmed = isArmed
+        self.is_armed = is_armed