Commit Graph

2613 Commits

Author SHA1 Message Date
Tom Morris
aa43445c99
Extend forEach() to support JSON objects (#3150)
* Refactor GREL Get tests

- move helper up to RefineTest
- move tests to the correct module

* Extend forEach() to support JSON objects - fixes #3149

Also add tests for existing forEach forms in addition to the new one

* Add a couple more tests
2020-08-30 08:40:17 +02:00
Tom Morris
0f15c61ef0
Merge pull request #3119 from OpenRefine/dependabot/maven/com.squareup.okhttp3-mockwebserver-4.8.1
Bump mockwebserver from 4.7.2 to 4.8.1
2020-08-27 17:25:51 -04:00
Lisa Chandra
5ca5f3cb7b
Restructured the Facets (#3097)
* added class to List Facet

* added class to Timerange Facet

* added class to Range Facet

* added class to Text Filter Facet

* added class to Scatterplot Facet

* added base class

* added end line in facet.js

* fixed indentations facet.js

* fixed indentation again

* removed fields

* added suggested changes
2020-08-25 12:29:27 -04:00
dependabot-preview[bot]
e0646716f4
Bump mockwebserver from 4.7.2 to 4.8.1
Bumps [mockwebserver](https://github.com/square/okhttp) from 4.7.2 to 4.8.1.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/square/okhttp/compare/parent-4.7.2...parent-4.8.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-24 06:41:48 +00:00
Tom Morris
95756bf11f Replace deprecated constant 2020-08-23 14:17:40 -04:00
Tom Morris
441c069bc5 Add some string function tests
Including a test for Apache TEXT-149 behavior change
https://github.com/apache/commons-text/pull/119

Add some more string function tests
2020-08-23 14:17:40 -04:00
Tom Morris
b5aea3b780 Remove unused imports 2020-08-23 14:17:40 -04:00
Tom Morris
a50669800f Split up multifunction test modules
Distributes the tests to individual modules per function and
deletes the former multifunction test modules.
2020-08-23 14:11:49 -04:00
Tom Morris
392a64b25e Refactor tests to hoist common methods into RefineTest
Moves the invoke() method and the associated fields into
the super class and deletes the redundant implementations.
2020-08-23 14:11:49 -04:00
Antonin Delpeuch
9ac54edbba
Migrate reconciliation calls to Apache HTTP client (#2906)
* Migrate reconciliation calls to OkHTTP, for #2903

* Migrate to Apache HTTP Commons

* Migrate data extension to Apache HTTP client

* Deprecate HttpURLConnection in RefineServlet

* Use LaxRedirectStrategy, clean up imports

* Remove read and pool timeouts, only keep the connection timeout

* Adapt mocking of HTTP calls after migration
2020-08-23 14:04:59 +02:00
Tom Morris
259705ad5f
assertEqualAsJson test helper refactor (#3113)
* Refactor test helper

Create a version of the assert that uses the standard parameter
order and deprecate the version that uses inverted order.

* Use consistent Assert class and parameter ordering
2020-08-23 11:04:44 +02:00
Isao Matsunami
9470c47031 Translated using Weblate (Japanese)
Currently translated at 100.0% (751 of 751 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ja/
2020-08-22 18:14:45 +02:00
Tom Morris
f74e3e048e
Fix i18n key typo - fixes #3093 (#3094) 2020-08-17 22:45:50 +02:00
Tom Morris
5eff85b76c
Update jQuery UI to 1.12 - fixes #3001 (#3010)
* Update jQuery UI from 1.10.3 to 1.12.1 and associated theme CSS

* Fix sidebar tab layout issue with new jQuery UI

* Update initialization jQuery UI Tabs widgets

selected is now active, but the first tab is selected by default
so we don't need to do it manually.

* Patch GData initialization error

Don't attempt to initialize if we get no docs back (ie unauthorized)
2020-08-17 14:49:56 +02:00
Tom Morris
591d47abe3
Fix About page script references - fixes #3088 (#3090)
* Fix About page - fixes #3088

Update jQuery version
Include correct Javascript file to get version information
Fix version display

* Remove obsolete Freebase logo license reference
2020-08-17 13:16:11 +02:00
Tom Morris
fc21d58ed1
Don't count TABs as control characters - fixes #3061 (#3068)
* Don't count TABs as control characters - fixes #3061

* Add TSV test. Replace info logging w/assert message
2020-08-16 10:35:25 +02:00
vuod
907b0d5169
Translated using Weblate (French)
Currently translated at 98.2% (738 of 751 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/fr/
2020-08-15 00:32:54 +02:00
Shih-Chan Fan
97fe642ceb Translated using Weblate (Chinese (Traditional))
Currently translated at 6.3% (48 of 751 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/zh_Hant/
2020-08-13 12:16:06 -04:00
Shih-Chan Fan
6ab25d8fb6 Added translation using Weblate (Chinese (Traditional)) 2020-08-13 12:16:06 -04:00
dependabot-preview[bot]
937bb94a0e
Bump maven-resources-plugin from 3.1.0 to 3.2.0
Bumps [maven-resources-plugin](https://github.com/apache/maven-resources-plugin) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/apache/maven-resources-plugin/releases)
- [Commits](https://github.com/apache/maven-resources-plugin/compare/maven-resources-plugin-3.1.0...maven-resources-plugin-3.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-12 08:15:08 +00:00
Tom Morris
109aa78cf9
Merge pull request #3051 from OpenRefine/dependabot/maven/commons-validator-commons-validator-1.7
Bump commons-validator from 1.6 to 1.7
2020-08-10 13:04:12 -04:00
Tom Morris
b73b480d7d
Remove tests of third party code (#3050)
Neither of these tests are testing OpenRefine code
(and a negative NotEquals test is useless anyway)
2020-08-10 12:39:30 +02:00
dependabot-preview[bot]
1060a117ca
Bump commons-validator from 1.6 to 1.7
Bumps commons-validator from 1.6 to 1.7.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-10 08:19:45 +00:00
Rafael Fontenelle
680cfa996d
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (751 of 751 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/pt_BR/
2020-08-09 18:32:49 +02:00
Tom Morris
9c403d59d2
Add separator to zip slip check - fixes #3043 (#3048) 2020-08-09 14:48:55 +02:00
Tom Morris
55edae2b7b
Fix ToDate test failure & inefficiency - fixes #3026 (#3027)
* Fix ToDate test failure - fixes #3026

Instead of computing offset from UTC at current
point in time, use the offset from the parsed
date so that we're not affected by crossing
a daylight savings time boundary.

* Fix date parsing with locale as first format string

Also refactors for simpicity, restore some dropped tests,
and restores previous behavior of considering a bad
format string an error instead of silently ignoring it.

It does NOT address another issue which was introduced
in May 2018 of treating date/times without timzone
information as UTC instead of local.

* Restore error checking and messages

* Save & restore default timezone for tests

Also add some ToDos for places where LocalDate is being misused.
2020-08-09 13:53:43 +02:00
Isao Matsunami
2f604e551a
Translated using Weblate (Japanese)
Currently translated at 100.0% (751 of 751 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/ja/
2020-08-08 12:47:41 +02:00
Hosted Weblate
478aeff793
Merge branch 'origin/master' into Weblate. 2020-08-08 02:20:33 +02:00
Tom Morris
c90f0f4cff
Translated using Weblate (French)
Currently translated at 99.0% (746 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/fr/
2020-08-08 02:20:32 +02:00
Tom Morris
79399691a4
Translated using Weblate (Spanish)
Currently translated at 99.4% (749 of 753 strings)

Translation: OpenRefine/Translations
Translate-URL: https://hosted.weblate.org/projects/openrefine/translations/es/
2020-08-08 02:20:32 +02:00
Thad Guidry
f220d6b989 Speed up git commit extraction
Fixes #3039
Limits only asking Git for 2 properties, branch and commit id abbrev

Also add warning about version of git-commit-id-plug
2020-08-07 14:16:08 -04:00
Tom Morris
e38d586a0e Revert "Merge pull request #3037 from OpenRefine/dependabot/maven/pl.project13.maven-git-commit-id-plugin-4.0.2"
This reverts commit ebdb15fc8c, reversing
changes made to 8fb2402432.

git-commit-id plugin doesn't work at 4.0.2
2020-08-07 13:44:46 -04:00
Tom Morris
ebdb15fc8c
Merge pull request #3037 from OpenRefine/dependabot/maven/pl.project13.maven-git-commit-id-plugin-4.0.2
Bump git-commit-id-plugin from 4.0.0 to 4.0.2
2020-08-07 12:13:44 -04:00
dependabot-preview[bot]
72f5f5fde9
Bump mockwebserver from 4.8.0 to 4.8.1
Bumps [mockwebserver](https://github.com/square/okhttp) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/square/okhttp/compare/parent-4.8.0...parent-4.8.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-07 08:06:07 +00:00
dependabot-preview[bot]
6404434333
Bump git-commit-id-plugin from 4.0.0 to 4.0.2
Bumps git-commit-id-plugin from 4.0.0 to 4.0.2.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-07 08:05:39 +00:00
Tom Morris
6095c44cb7
Update to jQuery 1.12.4 and jQuery Migrate 1.4.1 - fixes 2932 (#2933)
* Refactor module wiring to reduce redundancy

* Update to jQuery 1.12.4 & jQuery Migrate 1.4.1 - fixes #2932

This updates to the latest jQuery 1.x and jQuery Migrate 1.x,
the first step in upgrading to a modern jQuery.

* Add a couple of bug fixes from Google Code SVN

This is an unrelease version from the Google Code freebase-site
repo which only has a few changes from the v4.3 release, but
one of them is removing the `browser.msie` reference that
jQuery Migrate is complaining about.

* Use prop() for 'checked' and 'disabled'

* Update jQuery 'value' property setting code to use val()

* Use prop() instead of attr() to set 'selected'

* Patch for jQuery >1.9
2020-08-06 13:47:31 +02:00
Tom Morris
05fb4e355f
Replace Javascript string concatenation with i18n parameters - addresses #1858 (#3019)
* Replace js string concatenation with i18n parameters

refs #1858
Remove Javascript string concatentation and use jquery i18n()
instead so that translators have the needed context and
flexibility to be able to do a good job. Also remove code-based
plurals conditionalization and replace with i18n.

* Update French translation so I can test non-English support

* Add missing localization

* Clean up formatting of service API link
2020-08-04 10:10:38 +02:00
Tom Morris
2f7a357023
Merge pull request #3025 from OpenRefine/dependabot/maven/org.testng-testng-7.3.0
Bump testng from 7.1.0 to 7.3.0
2020-08-03 21:09:01 -04:00
Tom Morris
a0819acbd6 Move ProjectManager initialization to beforeMethod 2020-08-03 20:42:31 -04:00
Tom Morris
52194e1685 Add https for all TestNG DTDs 2020-08-03 12:27:58 -04:00
dependabot-preview[bot]
50b21f0474
Bump signpost-commonshttp4 from 2.0.0 to 2.1.1 (#3024)
Bumps [signpost-commonshttp4](https://github.com/mttkay/signpost) from 2.0.0 to 2.1.1.
- [Release notes](https://github.com/mttkay/signpost/releases)
- [Changelog](https://github.com/mttkay/signpost/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mttkay/signpost/compare/oauth-signpost-2.0.0...oauth-signpost-2.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-03 14:44:45 +02:00
dependabot-preview[bot]
807cd4ccf3
Bump signpost-core from 2.0.0 to 2.1.1 (#3023)
Bumps [signpost-core](https://github.com/mttkay/signpost) from 2.0.0 to 2.1.1.
- [Release notes](https://github.com/mttkay/signpost/releases)
- [Changelog](https://github.com/mttkay/signpost/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mttkay/signpost/compare/oauth-signpost-2.0.0...oauth-signpost-2.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-03 14:44:16 +02:00
Chetan Verma
04309dcfb4
Add improvement-message for vantage. (#3011)
Fixed self mistakes

modified line forVantage

Revert "modified line forVantage"

This reverts commit f252bde77cedf2f85fbfaf2059e551078ad62c2c.

modification in one anathor line

Co-authored-by: chetan <you@example.com>
2020-08-03 14:15:39 +02:00
dependabot-preview[bot]
e081961c1f
Bump testng from 7.1.0 to 7.3.0
Bumps [testng](https://github.com/cbeust/testng) from 7.1.0 to 7.3.0.
- [Release notes](https://github.com/cbeust/testng/releases)
- [Changelog](https://github.com/cbeust/testng/blob/master/CHANGES.txt)
- [Commits](https://github.com/cbeust/testng/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-03 09:01:36 +00:00
Tom Morris
0ebd89c952
Clustering dialog choices limit & performance improvements - fixes #695 (#2996)
* Clustering dialog choices limit & performance improvements - fixes #695

Fixes #695
- Caps the total number of choices displayed at 10,000 and warns when
  over the limit. Users can use facets to tune which clusters are displayed.
- Doubles the performance of the Javascript processing
- Only displays count of rows for a choice if it's > 1 to DOM elements
- Adds internationalization for row count

For 41K clusters containing 118K choices, processing dropped from
3m20s to 1m20s, but with the 10K choice cap total time is ~10sec.

* Restore even/odd row class

* Updates from review feedback
2020-08-01 10:59:41 +02:00
Tom Morris
5985f95ce1
Explicitly set SameSite=Lax on cookie - fixes #3007 (#3014) 2020-08-01 10:58:16 +02:00
Lisa Chandra
1dcc83209c
Faster rendering of rows and cells (#2973)
* changes to rendering of rows

* some cell rendering improvements

* more render row improvements

* fixed jQuery methods on js elements

* added comment for nbsp
2020-07-28 18:25:32 +02:00
Tom Morris
db42bcab92
Update to vicino 1.2 and drop transitive dependencies - fixes #2959 (#2998)
Bump to vicino 1.2 with bug fix and real POM.

Drop dependencies on secondstring and arithcode which are just
transitive dependencies from simile-vicino, now that it has a
proper POM. Fixes #2959.
2020-07-28 08:19:58 +02:00
dependabot-preview[bot]
d258e9bd05
Bump commons-text from 1.8 to 1.9
Bumps commons-text from 1.8 to 1.9.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-27 08:30:43 +00:00
Chetan Verma
86ec7e6b40
Give the name to button 'Back' (#2989)
* Give the name to button 'Back'

* Using DOM to add name of button
2020-07-26 09:08:50 +02:00